From: Tom Herbert Subject: [PATCH net-next] kcm: Call strp_stop before strp_done in kcm_attach Date: Wed, 14 Feb 2018 09:22:42 -0800 Message-ID: <20180214172242.3896-1-tom@quantonium.net> Cc: netdev@vger.kernel.org, Tom Herbert To: davem@davemloft.net Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:40255 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033384AbeBNRW7 (ORCPT ); Wed, 14 Feb 2018 12:22:59 -0500 Received: by mail-pf0-f193.google.com with SMTP id u20so2937460pfl.7 for ; Wed, 14 Feb 2018 09:22:59 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: In kcm_attach strp_done is called when sk_user_data is already set to fail the attach. strp_done needs the strp to be stopped and warns if it isn't. Call strp_stop in this case to eliminate the warning message. Reported-by: syzbot+88dfb55e4c8b770d86e3@syzkaller.appspotmail.com Fixes: e5571240236c5652f ("kcm: Check if sk_user_data already set in kcm_attach" Signed-off-by: Tom Herbert --- net/kcm/kcmsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index f297d53a11aa..435594648dac 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm/kcmsock.c @@ -1417,6 +1417,7 @@ static int kcm_attach(struct socket *sock, struct socket *csock, */ if (csk->sk_user_data) { write_unlock_bh(&csk->sk_callback_lock); + strp_stop(&psock->strp); strp_done(&psock->strp); kmem_cache_free(kcm_psockp, psock); return -EALREADY; -- 2.11.0