From: Daniel Vetter Subject: Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC Date: Mon, 19 Feb 2018 15:30:02 +0100 Message-ID: <20180219143002.GC22199@phenom.ffwll.local> References: <1518511456-28257-1-git-send-email-andr2000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45F4389F41 for ; Mon, 19 Feb 2018 14:30:07 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id z81so15529313wmb.4 for ; Mon, 19 Feb 2018 06:30:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <1518511456-28257-1-git-send-email-andr2000@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko Cc: airlied@linux.ie, daniel.vetter@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Oleksandr Andrushchenko List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMTMsIDIwMTggYXQgMTA6NDQ6MTZBTSArMDIwMCwgT2xla3NhbmRyIEFuZHJ1 c2hjaGVua28gd3JvdGU6Cj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5k cl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPgo+IAo+IEl0IGlzIHBvc3NpYmxlIHRoYXQgZHJtX3Np bXBsZV9rbXNfcGxhbmVfYXRvbWljX2NoZWNrIGNhbGxlZAo+IHdpdGggbm8gQ1JUQyBzZXQsIGUu Zy4gd2hlbiB1c2VyLXNwYWNlIGFwcGxpY2F0aW9uIHNldHMgQ1JUQ19JRC9GQl9JRAo+IHRvIDAg YmVmb3JlIGRvaW5nIGFueSBhY3R1YWwgZHJhd2luZy4gVGhpcyBsZWFkcyB0byBOVUxMIHBvaW50 ZXIKPiBkZXJlZmVyZW5jZSBiZWNhdXNlIGluIHRoaXMgY2FzZSBuZXcgQ1JUQyBzdGF0ZSBpcyBO VUxMIGFuZCBtdXN0IGJlCj4gY2hlY2tlZCBiZWZvcmUgYWNjZXNzaW5nLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0Bl cGFtLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5j IHwgNiArKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gaW5kZXgg OWNhOGE0YTU5Yjc0Li5hMDVlY2E5Y2VjOGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1w bGVfa21zX2hlbHBlci5jCj4gQEAgLTEyMSw4ICsxMjEsMTAgQEAgc3RhdGljIGludCBkcm1fc2lt cGxlX2ttc19wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlw aXBlID0gY29udGFpbmVyX29mKHBsYW5lLCBzdHJ1Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUs IHBsYW5lKTsKPiAgCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShw bGFuZV9zdGF0ZS0+c3RhdGUsCj4gIAkJCQkJCSAgICZwaXBlLT5jcnRjKTsKPiAtCWlmICghY3J0 Y19zdGF0ZS0+ZW5hYmxlKQo+IC0JCXJldHVybiAwOyAvKiBub3RoaW5nIHRvIGNoZWNrIHdoZW4g ZGlzYWJsaW5nIG9yIGRpc2FibGVkICovCj4gKwo+ICsJaWYgKCFjcnRjX3N0YXRlIHx8ICFjcnRj X3N0YXRlLT5lbmFibGUpCj4gKwkJLyogbm90aGluZyB0byBjaGVjayB3aGVuIGRpc2FibGluZyBv ciBkaXNhYmxlZCBvciBubyBDUlRDIHNldCAqLwo+ICsJCXJldHVybiAwOwo+ICAKPiAgCWlmIChj cnRjX3N0YXRlLT5lbmFibGUpCj4gIAkJZHJtX21vZGVfZ2V0X2h2X3RpbWluZygmY3J0Y19zdGF0 ZS0+bW9kZSwKCkhtLCB0aGlzIGlzIGEgYml0IGFubm95aW5nLCBzaW5jZSB0aGUgY2FuX3Bvc2l0 aW9uID0gZmFsc2UgcGFyYW1ldGVyIHRvCmRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0 YXRlIGlzIHN1cHBvc2VkIHRvIGNhdGNoIGFsbCB0aGlzLiBXb3VsZAptb3ZpbmcgYWxsIHRoZSBj aGVja3MgYWZ0ZXIgdGhlIGNhbGwgdG8gdGhhdCBoZWxwZXIsIGFuZCBnYXRpbmcgdGhlbSBvbgpw bGFuZV9zdGF0ZS0+dmlzaWJsZSBhbHNvIHdvcms/CgpXZSdkIG5lZWQgdG8gYWRkIGEgZ3VhcmFu dGVlIHRvIGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0YXRlIHRoYXQKaXQgY2FuIGNv cGUgd2l0aCBjcnRjX3N0YXRlID09IE5VTEwsIGJ1dCBJIHRoaW5rIHRoYXQncyBhIGdvb2QgaWRl YQphbnl3YXkuIEF0bSBpdCBzaG91bGRuJ3QgZW5kIHVwIGxvb2tpbmcgYXQgdGhlIGNydGNfc3Rh dGUgcG9pbnRlciBpbiB0aGF0CmNhc2UuCgpPdGhlcndpc2Ugd2UnbGwganVzdCBnbyB3aXRoIHlv dXIgZml4LCBidXQgaXQgZmVlbHMgYWxsIGEgYml0IHRvbyBmcmFnaWxlLApoZW5jZSB3aHkgSSB3 YW50IHRvIGV4cGxvcmUgbW9yZSByb2J1c3Qgb3B0aW9ucyBhIGJpdC4KLURhbmllbAotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==