Received: from eggs.gnu.org ([2001:4830:134:3::10]:48203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoYMX-00053N-AA for qemu-devel@nongnu.org; Wed, 21 Feb 2018 12:39:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoYMU-00058n-5U for qemu-devel@nongnu.org; Wed, 21 Feb 2018 12:39:25 -0500 Date: Wed, 21 Feb 2018 18:39:18 +0100 From: Cornelia Huck Message-ID: <20180221183918.7cc4fad1.cohuck@redhat.com> In-Reply-To: References: <20180219174231.10874-1-david@redhat.com> <493dbfb3-086b-cc89-2d8d-4298345c6bb2@de.ibm.com> <20180220155759.17dfd955.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Richard Henderson , Alexander Graf On Tue, 20 Feb 2018 16:05:54 +0100 David Hildenbrand wrote: > On 20.02.2018 15:57, Cornelia Huck wrote: > > On Tue, 20 Feb 2018 13:16:37 +0100 > > David Hildenbrand wrote: > > > >> On 20.02.2018 13:05, Christian Borntraeger wrote: > >>> > >>> > >>> On 02/19/2018 06:42 PM, David Hildenbrand wrote: > >>>> From an architecture point of view, nothing can be mapped into the address > >>>> space on s390x. All there is is memory. Therefore there is also not really > >>>> an interface to communicate such information to the guest. All we can do is > >>>> specify the maximum ram address and guests can probe in that range if > >>>> memory is available and usable (TPROT). > >>> > >>> In fact there is an interface in SCLP that describes the memory sizes (maximum in > >>> read scp info) and the details (read_storage_element0_info). I am asking myself > >>> if we should re-introduce read_storage_element_info and use that to avoid tprot > >> > >> Yes, we could do that (basically V1 of this patch) but have to glue it > >> to the a compatibility machine then. > > > > Actually, this makes quite a bit of sense (introduce the interface for > > everyone in 2.12 and turn it off in compat machines). > > Jup, either 2.12 or 2.13, no need to hurry. > > > > > Does real hardware have configurations where you can get the memory > > sizes, but not the attach/deattach support? (Hardware with the feature, > > but no standby memory defined?) > > I would guess that "0" for standby memory is valid but only people with > access to documentation can answer that :) So, should we go with this patch now and re-introduce the read functions if the above is indeed true? > > >> Interesting, didn't know about that. Will rephrase then to > >> > >> "While the hypervisor can deny to online an increment, all increments > >> have to be predefined and there is no way of telling the guest about a > >> newly "hotplugged" increment." > > > > Rephrase which part? :) > > "And nobody can really hinder it from doing so." OK.