Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35647 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbeBUT0o (ORCPT ); Wed, 21 Feb 2018 14:26:44 -0500 Date: Wed, 21 Feb 2018 21:26:41 +0200 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, nikolay@cumulusnetworks.com Subject: Re: [PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case Message-ID: <20180221192641.GB15987@splinter.mtl.com> References: <20180221190054.31613-1-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180221190054.31613-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 21, 2018 at 11:00:54AM -0800, David Ahern wrote: > The result of the skb flow dissect is copied from keys to hash_keys to > ensure only the intended data is hashed. The original L4 hash patch > overlooked setting the addr_type for this case; add it. > > Fixes: bf4e0a3db97eb ("net: ipv4: add support for ECMP hash policy choice") > Reported-by: Ido Schimmel > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel Thanks!