Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem From: Joe Moriarty Message-Id: <20180226171002.46979-2-joe.moriarty@oracle.com> Date: Mon, 26 Feb 2018 12:10:02 -0500 To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org List-ID: VGhlIFBhcmZhaXQgKHZlcnNpb24gMi4xLjApIHN0YXRpYyBjb2RlIGFuYWx5c2lzIHRvb2wgZm91 bmQgdGhlCmZvbGxvd2luZyBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgcHJvYmxlbS4KCmRldl90 b19zaG9zdCgpIGluIGluY2x1ZGUvc2NzaS9zY3NpX2hvc3QuaCBoYXMgdGhlIGFiaWxpdHkgdG8g cmV0dXJuCk5VTEwgaWYgdGhlIHNjc2kgaG9zdCBkZXZpY2UgZG9lcyBub3QgaGF2ZSB0aGUgU2Nz aV9ob3N0LT5wYXJlbnQKZmllbGQgc2V0LiAgV2l0aCB0aGUgcG9zc2liaWx0eSBvZiBhIE5VTEwg cG9pbnRlciBiZWluZyBzZXQgZm9yCnRoZSBTY3NpX0hvc3QtPnBhcmVudCBmaWVsZCwgY2FsbHMg dG8gaG9zdF90b191cygpIGhhdmUgdG8gbWFrZQpzdXJlIHRoZSByZXR1cm4gcG9pbnRlciBpcyBu b3QgbnVsbC4gIENoYW5nZXMgd2VyZSBtYWRlIHRvIGNoZWNrCmZvciBhIHJldHVybiB2YWx1ZSBv ZiBOVUxMIG9uIGNhbGxzIHRvIGhvc3RfdG9fdXMoKS4KClNpZ25lZC1vZmYtYnk6IEpvZSBNb3Jp YXJ0eSA8am9lLm1vcmlhcnR5QG9yYWNsZS5jb20+ClJldmlld2VkLWJ5OiBTdGV2ZW4gU2lzdGFy ZSA8c3RldmVuLnNpc3RhcmVAb3JhY2xlLmNvbT4KQWNrZWQtYnk6IEhha29uIEJ1Z2dlIDxoYWtv bi5idWdnZUBvcmFjbGUuY29tPgotLS0KIGRyaXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYyB8 IDUzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1ZS5jIGIvZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1 ZS5jCmluZGV4IGMyNjdmMjgxMmEwNC4uOTRhZjYwOWQ0OWJmIDEwMDY0NAotLS0gYS9kcml2ZXJz L3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMKKysrIGIvZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1 ZS5jCkBAIC02Niw2ICs2Niw5IEBAIHN0YXRpYyBpbnQgc2xhdmVfYWxsb2MgKHN0cnVjdCBzY3Np X2RldmljZSAqc2RldikKIHsKIAlzdHJ1Y3QgdXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKHNkZXYt Pmhvc3QpOwogCisJaWYgKCF1cykKKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxu IiwgX19mdW5jX18pOworCiAJLyoKIAkgKiBTZXQgdGhlIElOUVVJUlkgdHJhbnNmZXIgbGVuZ3Ro IHRvIDM2LiAgV2UgZG9uJ3QgdXNlIGFueSBvZgogCSAqIHRoZSBleHRyYSBkYXRhIGFuZCBtYW55 IGRldmljZXMgY2hva2UgaWYgYXNrZWQgZm9yIG1vcmUgb3IKQEAgLTEwMiw2ICsxMDUsMTEgQEAg c3RhdGljIGludCBzbGF2ZV9jb25maWd1cmUoc3RydWN0IHNjc2lfZGV2aWNlICpzZGV2KQogewog CXN0cnVjdCB1c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoc2Rldi0+aG9zdCk7CiAKKwlpZiAoIXVz KSB7CisJCXByX3dhcm4oIkVycm9yIGluICVzOiB1cyA9IE5VTExcbiIsIF9fZnVuY19fKTsKKwkJ cmV0dXJuIDA7CisJfQorCiAJLyoKIAkgKiBNYW55IGRldmljZXMgaGF2ZSB0cm91YmxlIHRyYW5z ZmVycmluZyBtb3JlIHRoYW4gMzJLQiBhdCBhIHRpbWUsCiAJICogd2hpbGUgb3RoZXJzIGhhdmUg dHJvdWJsZSB3aXRoIG1vcmUgdGhhbiA2NEsuIEF0IHRoaXMgdGltZSB3ZQpAQCAtMzMxLDYgKzMz OSwxMSBAQCBzdGF0aWMgaW50IHRhcmdldF9hbGxvYyhzdHJ1Y3Qgc2NzaV90YXJnZXQgKnN0YXJn ZXQpCiB7CiAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhkZXZfdG9fc2hvc3Qoc3Rh cmdldC0+ZGV2LnBhcmVudCkpOwogCisJaWYgKCF1cykgeworCQlwcl93YXJuKCJFcnJvciBpbiAl czogdXMgPSBOVUxMXG4iLCBfX2Z1bmNfXyk7CisJCXJldHVybiAwOworCX0KKwogCS8qCiAJICog U29tZSBVU0IgZHJpdmVzIGRvbid0IHN1cHBvcnQgUkVQT1JUIExVTlMsIGV2ZW4gdGhvdWdoIHRo ZXkKIAkgKiByZXBvcnQgYSBTQ1NJIHJldmlzaW9uIGxldmVsIGFib3ZlIDIuICBUZWxsIHRoZSBT Q1NJIGxheWVyCkBAIC0zNjEsNiArMzc0LDExIEBAIHN0YXRpYyBpbnQgcXVldWVjb21tYW5kX2xj ayhzdHJ1Y3Qgc2NzaV9jbW5kICpzcmIsCiB7CiAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90 b191cyhzcmItPmRldmljZS0+aG9zdCk7CiAKKwlpZiAoIXVzKSB7CisJCXByX3dhcm4oIkVycm9y IGluICVzOiB1cyA9IE5VTExcbiIsIF9fZnVuY19fKTsKKwkJcmV0dXJuIDA7CisJfQorCiAJLyog Y2hlY2sgZm9yIHN0YXRlLXRyYW5zaXRpb24gZXJyb3JzICovCiAJaWYgKHVzLT5zcmIgIT0gTlVM TCkgewogCQlwcmludGsoS0VSTl9FUlIgVVNCX1NUT1JBR0UgIkVycm9yIGluICVzOiB1cy0+c3Ji ID0gJXBcbiIsCkBAIC0zOTUsNiArNDEzLDExIEBAIHN0YXRpYyBpbnQgY29tbWFuZF9hYm9ydChz dHJ1Y3Qgc2NzaV9jbW5kICpzcmIpCiB7CiAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191 cyhzcmItPmRldmljZS0+aG9zdCk7CiAKKwlpZiAoIXVzKSB7CisJCXByX3dhcm4oIkVycm9yIGlu ICVzOiB1cyA9IE5VTExcbiIsIF9fZnVuY19fKTsKKwkJcmV0dXJuIEZBSUxFRDsKKwl9CisKIAl1 c2Jfc3Rvcl9kYmcodXMsICIlcyBjYWxsZWRcbiIsIF9fZnVuY19fKTsKIAogCS8qCkBAIC00Mzgs MTIgKzQ2MSwxNyBAQCBzdGF0aWMgaW50IGRldmljZV9yZXNldChzdHJ1Y3Qgc2NzaV9jbW5kICpz cmIpCiAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhzcmItPmRldmljZS0+aG9zdCk7 CiAJaW50IHJlc3VsdDsKIAotCXVzYl9zdG9yX2RiZyh1cywgIiVzIGNhbGxlZFxuIiwgX19mdW5j X18pOworCWlmICh1cykgeworCQl1c2Jfc3Rvcl9kYmcodXMsICIlcyBjYWxsZWRcbiIsIF9fZnVu Y19fKTsKIAotCS8qIGxvY2sgdGhlIGRldmljZSBwb2ludGVycyBhbmQgZG8gdGhlIHJlc2V0ICov Ci0JbXV0ZXhfbG9jaygmKHVzLT5kZXZfbXV0ZXgpKTsKLQlyZXN1bHQgPSB1cy0+dHJhbnNwb3J0 X3Jlc2V0KHVzKTsKLQltdXRleF91bmxvY2soJnVzLT5kZXZfbXV0ZXgpOworCQkvKiBsb2NrIHRo ZSBkZXZpY2UgcG9pbnRlcnMgYW5kIGRvIHRoZSByZXNldCAqLworCQltdXRleF9sb2NrKCYodXMt PmRldl9tdXRleCkpOworCQlyZXN1bHQgPSB1cy0+dHJhbnNwb3J0X3Jlc2V0KHVzKTsKKwkJbXV0 ZXhfdW5sb2NrKCZ1cy0+ZGV2X211dGV4KTsKKwl9IGVsc2UgeworCQlwcl93YXJuKCJFcnJvciBp biAlczogdXMgPSBOVUxMXG4iLCBfX2Z1bmNfXyk7CisJCXJlc3VsdCA9IC1FTlhJTzsKKwl9CiAK IAlyZXR1cm4gcmVzdWx0IDwgMCA/IEZBSUxFRCA6IFNVQ0NFU1M7CiB9CkBAIC00NTQsOSArNDgy LDE1IEBAIHN0YXRpYyBpbnQgYnVzX3Jlc2V0KHN0cnVjdCBzY3NpX2NtbmQgKnNyYikKIAlzdHJ1 Y3QgdXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKHNyYi0+ZGV2aWNlLT5ob3N0KTsKIAlpbnQgcmVz dWx0OwogCi0JdXNiX3N0b3JfZGJnKHVzLCAiJXMgY2FsbGVkXG4iLCBfX2Z1bmNfXyk7CisJaWYg KHVzKSB7CisJCXVzYl9zdG9yX2RiZyh1cywgIiVzIGNhbGxlZFxuIiwgX19mdW5jX18pOworCisJ CXJlc3VsdCA9IHVzYl9zdG9yX3BvcnRfcmVzZXQodXMpOworCX0gZWxzZSB7CisJCXByX3dhcm4o IkVycm9yIGluICVzOiB1cyA9IE5VTExcbiIsIF9fZnVuY19fKTsKKwkJcmVzdWx0ID0gLUVOWElP OworCX0KIAotCXJlc3VsdCA9IHVzYl9zdG9yX3BvcnRfcmVzZXQodXMpOwogCXJldHVybiByZXN1 bHQgPCAwID8gRkFJTEVEIDogU1VDQ0VTUzsKIH0KIApAQCAtNTA2LDYgKzU0MCwxMSBAQCBzdGF0 aWMgaW50IHNob3dfaW5mbyAoc3RydWN0IHNlcV9maWxlICptLCBzdHJ1Y3QgU2NzaV9Ib3N0ICpo b3N0KQogCXN0cnVjdCB1c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoaG9zdCk7CiAJY29uc3QgY2hh ciAqc3RyaW5nOwogCisJaWYgKCF1cykgeworCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMgPSBO VUxMXG4iLCBfX2Z1bmNfXyk7CisJCXJldHVybiAwOworCX0KKwogCS8qIHByaW50IHRoZSBjb250 cm9sbGVyIG5hbWUgKi8KIAlzZXFfcHJpbnRmKG0sICIgICBIb3N0IHNjc2klZDogdXNiLXN0b3Jh Z2VcbiIsIGhvc3QtPmhvc3Rfbm8pOwogCg==