Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem From: Greg Kroah-Hartman Message-Id: <20180226193557.GB21453@kroah.com> Date: Mon, 26 Feb 2018 20:35:57 +0100 To: Joe Moriarty Cc: linux-usb@vger.kernel.org List-ID: T24gTW9uLCBGZWIgMjYsIDIwMTggYXQgMDI6MDg6MDhQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdy b3RlOgo+IE9uIDIvMjYvMjAxOCAxOjEyIFBNLCBHcmVnIEtIIHdyb3RlOgo+ID4gT24gTW9uLCBG ZWIgMjYsIDIwMTggYXQgMTI6MTA6MDJQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdyb3RlOgo+ID4g PiBUaGUgUGFyZmFpdCAodmVyc2lvbiAyLjEuMCkgc3RhdGljIGNvZGUgYW5hbHlzaXMgdG9vbCBm b3VuZCB0aGUKPiA+ID4gZm9sbG93aW5nIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBwcm9ibGVt Lgo+ID4gCj4gPiBXaGF0IGlzIHRoZSAiQ1dFIDQ3NiIgdGhpbmcgaW4gdGhlIHN1YmplY3QgbGlu ZSBmb3I/Cj4gPiAKPiBbSkRNXQo+IChDV0UgNDc2KSBzdGFuZHMgZm9yIENvbW1vbiBXZWFrbmVz cyBFbnVtZXJhdGlvbi4KPiBodHRwczovL3NlY3VyMXR5LmNvbS9jd2UvQ1dFLTQ3Ni8KPiAKPiBJ dCBpcyB0aGUgdHlwZSBvZiBzZWN1cml0eSBmbGF3IHJlbGF0ZWQgdG8gYSBOVUxMIHBvaW50ZXIg ZGVyZWZlcmVuY2UKCk9rLCB3aHkgcHV0IHRoYXQgaW4gdGhlIHN1YmplY3QgbGluZSBhbmQgbm90 IGp1c3QgdGhlIGJvZHkgb2YgdGhlCmNoYW5nZWxvZyBpZiB5b3UgcmVhbGx5IHdhbnQgdG8gY2Fs bCBzb21ldGhpbmcgb3V0IGxpa2UgdGhpcz8KCj4gPiA+IGRldl90b19zaG9zdCgpIGluIGluY2x1 ZGUvc2NzaS9zY3NpX2hvc3QuaCBoYXMgdGhlIGFiaWxpdHkgdG8gcmV0dXJuCj4gPiA+IE5VTEwg aWYgdGhlIHNjc2kgaG9zdCBkZXZpY2UgZG9lcyBub3QgaGF2ZSB0aGUgU2NzaV9ob3N0LT5wYXJl bnQKPiA+ID4gZmllbGQgc2V0LiAgV2l0aCB0aGUgcG9zc2liaWx0eSBvZiBhIE5VTEwgcG9pbnRl ciBiZWluZyBzZXQgZm9yCj4gPiA+IHRoZSBTY3NpX0hvc3QtPnBhcmVudCBmaWVsZCwgY2FsbHMg dG8gaG9zdF90b191cygpIGhhdmUgdG8gbWFrZQo+ID4gPiBzdXJlIHRoZSByZXR1cm4gcG9pbnRl ciBpcyBub3QgbnVsbC4gIENoYW5nZXMgd2VyZSBtYWRlIHRvIGNoZWNrCj4gPiA+IGZvciBhIHJl dHVybiB2YWx1ZSBvZiBOVUxMIG9uIGNhbGxzIHRvIGhvc3RfdG9fdXMoKS4KPiA+ID4gCj4gPiA+ IFNpZ25lZC1vZmYtYnk6IEpvZSBNb3JpYXJ0eSA8am9lLm1vcmlhcnR5QG9yYWNsZS5jb20+Cj4g PiA+IFJldmlld2VkLWJ5OiBTdGV2ZW4gU2lzdGFyZSA8c3RldmVuLnNpc3RhcmVAb3JhY2xlLmNv bT4KPiA+ID4gQWNrZWQtYnk6IEhha29uIEJ1Z2dlIDxoYWtvbi5idWdnZUBvcmFjbGUuY29tPgo+ ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMgfCA1MyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiA+ID4gICAxIGZpbGUgY2hh bmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMgYi9kcml2ZXJzL3VzYi9zdG9y YWdlL3Njc2lnbHVlLmMKPiA+ID4gaW5kZXggYzI2N2YyODEyYTA0Li45NGFmNjA5ZDQ5YmYgMTAw NjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYwo+ID4gPiArKysg Yi9kcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMKPiA+ID4gQEAgLTY2LDYgKzY2LDkgQEAg c3RhdGljIGludCBzbGF2ZV9hbGxvYyAoc3RydWN0IHNjc2lfZGV2aWNlICpzZGV2KQo+ID4gPiAg IHsKPiA+ID4gICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhzZGV2LT5ob3N0KTsK PiA+ID4gKwlpZiAoIXVzKQo+ID4gPiArCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMgPSBOVUxM XG4iLCBfX2Z1bmNfXyk7Cj4gPiAKPiA+IEl0IGlzIGEgZHJpdmVyLCB5b3Ugc2hvdWxkIG5ldmVy IHVzZSBwcl8qIGNhbGxzLCBidXQgcmF0aGVyIGRldl8qIGNhbGxzLgo+ID4gCj4gPiBBbHNvLCB5 b3UgZG9uJ3QgZXhpdCwgYXJlIHlvdSBzdXJlIHRoZSBjb2RlIGtlZXBzIHdvcmtpbmcgYWZ0ZXIg dGhpcwo+ID4gaGFwcGVucz8KPiA+IAo+ID4gQW5kIHdoYXQgaXMgYSB1c2VyIHN1cHBvc2VkIHRv IGRvIHdpdGggdGhpcyB3YXJuaW5nIG1lc3NhZ2U/Cj4gCj4gW0pETV0KCj8/PyAgWW91IG5lZWQg YSBiZXR0ZXIgZW1haWwgY2xpZW50LCBpbmxpbmUgY29tbWVudHMgYXJlIHRoZSBub3JtLgoKPiAt IFRoZSBtZXNzYWdlcyBhcmUgdGFyZ2V0ZWQgZm9yIGEgZGV2ZWxvcGVyIGFuZCBub3QgdGhlIGVu ZCB1c2VyLiBJIGNhbgo+IGNoYW5nZSBpdCB0byBkZXZfIGNhbGxzLgoKQnV0IGFuIGVuZCB1c2Vy IHNlZXMgIktFUk5fV0FSTklORyIgbWVzc2FnZXMsIHJpZ2h0PyAgSWYgdGhpcyBpcyBhCmRlYnVn Z2luZy1vbmx5IHRoaW5nLCB0aGVuIG1ha2UgaXQgYXMgc3VjaCwgYW5kIHByb3Blcmx5IHJlY292 ZXIgZnJvbSBpdAphcyBpdCBjb3VsZCBiZSBoaXQgZHVyaW5nIG5vcm1hbCBvcGVyYXRpb24uCgo+ ID4gPiArCj4gPiA+ICAgCS8qCj4gPiA+ICAgCSAqIFNldCB0aGUgSU5RVUlSWSB0cmFuc2ZlciBs ZW5ndGggdG8gMzYuICBXZSBkb24ndCB1c2UgYW55IG9mCj4gPiA+ICAgCSAqIHRoZSBleHRyYSBk YXRhIGFuZCBtYW55IGRldmljZXMgY2hva2UgaWYgYXNrZWQgZm9yIG1vcmUgb3IKPiA+ID4gQEAg LTEwMiw2ICsxMDUsMTEgQEAgc3RhdGljIGludCBzbGF2ZV9jb25maWd1cmUoc3RydWN0IHNjc2lf ZGV2aWNlICpzZGV2KQo+ID4gPiAgIHsKPiA+ID4gICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9z dF90b191cyhzZGV2LT5ob3N0KTsKPiA+ID4gKwlpZiAoIXVzKSB7Cj4gPiA+ICsJCXByX3dhcm4o IkVycm9yIGluICVzOiB1cyA9IE5VTExcbiIsIF9fZnVuY19fKTsKPiA+ID4gKwkJcmV0dXJuIDA7 Cj4gPiAKPiA+IFdoeSBhcmUgeW91IHJldHVybmluZyBhIHN1Y2Nlc3M/Cj4gW0pETV0KPiAtIFll cywgSSBuZWVkIHRvIHJldHVybiAtRU5YSU8gZm9yIHRoZSBzbGF2ZV9hbGxvYyByb3V0aW5lLgo+ IAo+ID4gCj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ICAgCS8qCj4gPiA+ICAgCSAqIE1hbnkgZGV2 aWNlcyBoYXZlIHRyb3VibGUgdHJhbnNmZXJyaW5nIG1vcmUgdGhhbiAzMktCIGF0IGEgdGltZSwK PiA+ID4gICAJICogd2hpbGUgb3RoZXJzIGhhdmUgdHJvdWJsZSB3aXRoIG1vcmUgdGhhbiA2NEsu IEF0IHRoaXMgdGltZSB3ZQo+ID4gPiBAQCAtMzMxLDYgKzMzOSwxMSBAQCBzdGF0aWMgaW50IHRh cmdldF9hbGxvYyhzdHJ1Y3Qgc2NzaV90YXJnZXQgKnN0YXJnZXQpCj4gPiA+ICAgewo+ID4gPiAg IAlzdHJ1Y3QgdXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKGRldl90b19zaG9zdChzdGFyZ2V0LT5k ZXYucGFyZW50KSk7Cj4gPiAKPiA+IENhbiBob3N0X3RvX3VzKCkgaGFuZGxlIE5VTEw/Cj4gPiAK PiA+IE5vcGUsIGp1c3QgbG9va2VkIGF0IGl0LCB0aGlzIHdpbGwgbmV2ZXIgY2F1c2UgdGhlIHJl dHVybiB2YWx1ZSB0byBiZQo+ID4gTlVMTCwgeW91ciBjaGVja2VyIG5lZWRzIHNvbWUgbW9yZSB3 b3JrIDooCj4gW0pETV0KPiBUaGlzIHdoYXQgdGhlIHN0YXRpYyBjb2RlIGNoZWNrZXIgaXMgY2F0 Y2hpbmcuICBob3N0X3RvX3VzIHdpbGwgcmV0dXJuIE5VTEwKPiBpZiB0aGUgZm9sbG93aW5nIG9j Y3Vycy4KPiAKPiAnZGV2X3RvX3Nob3N0KCknIGluIGluY2x1ZGUvc2NzaS9zY3NpX2hvc3QuaCBs aW5lIDc1Ny4KPiAKPiBUaGlzIGlzIGRvbmUgZXZlcnl0aW1lIGEgc2xhdmUgZGV2aWNlIGlzIGNy ZWF0ZWQgYXQgdGhlIGZvbGxvd2luZyBjb2RlCj4gJ3RhcmdldF9hbGxvYygpJyBpbiBkcml2ZXJz L3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMgIGxpbnVlIDM0MC4KPiAKPiBUaGlzIG1lYW5zIHRoYXQg YW55IGNhbGwgdG8gaG9zdF90b191cyBpbiB0aGUgc2NzaWdsdWUgbW9kdWxlIHdpbGwgaGF2ZSB0 aGUKPiBwb3NzaWJpbGl0eSBvZiBzZXR0aW5nIHRoZSByZXR1cm4gdmFsdWUgb2YgTlVMTC4gIElu IGZhY3QsIEkgd291bGQgbmVlZCB0bwo+IHNwbGl0IG91dCB0aGUgZm9sbG93aW5nIGVtYmVkZGVk IGNhbGwgaW4gJ3RhcmdldF9hbGxvYygpJyB0byBhdm9pZCBhCj4gcG9zc2libGUgTlVMTCBwb2lu dGVyIGRlcmVmZXJlbmNlLgo+IAo+IHN0cnVjdCB1c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoZGV2 X3RvX3Nob3N0KHN0YXJnZXQtPmRldi5wYXJlbnQpKTsKCkV4YWN0bHksIHlvdXIgY2hhbmdlIGRp ZCBub3RoaW5nLCBhbmQgdXMgaXMgcHJvYmFibHkgbm90IE5VTEwgaGVyZS4KCj4gVGhlIHF1ZXN0 aW9uIGJlY29tZXMsIENhbiBhIHNsYXZlIGRldmljZSBldmVyIGhhdmUgaXQncyBwYXJlbnQgZmll bGQgc2V0IHRvCj4gTlVMTCAoaWU6IGRldi0+cGFyZW50KS4KCkkgZG9uJ3QgdGhpbmsgaXQgY2Fu LCBkbyB5b3Ugc2VlIGhvdz8KCj4gQ2FuIGl0PyAgSWYgbm90LCB0aGlzIGJlY29tZXMgYSBmYWxz ZSBwb3NpdGl2ZSB0aGF0IG5lZWRzIHRvIGJlCj4gaWdub3JlZCBhbmQgdGhlIGVudGlyZSBwYXRj aCBpcyBub3QgbmVlZGVkLiAgSSB3b3VsZCB0ZW5kIHRvIGJlbGlldmUgYQo+IHNsYXZlIGRldmlj ZSB3aWxsIGFsd2F5cyBiZSBlbnVtZXJhdGVkIGJ5IHRoZSBwYXJlbnQgKGhvc3QpIGRldmljZS4K PiBDb3JyZWN0PwoKSG93IGVsc2UgY2FuIGl0IGJlIGNyZWF0ZWQ/Cgo+ID4gPiArCWlmICghdXMp IHsKPiA+ID4gKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxuIiwgX19mdW5jX18p Owo+ID4gPiArCQlyZXR1cm4gMDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gICAJLyoKPiA+ID4g ICAJICogU29tZSBVU0IgZHJpdmVzIGRvbid0IHN1cHBvcnQgUkVQT1JUIExVTlMsIGV2ZW4gdGhv dWdoIHRoZXkKPiA+ID4gICAJICogcmVwb3J0IGEgU0NTSSByZXZpc2lvbiBsZXZlbCBhYm92ZSAy LiAgVGVsbCB0aGUgU0NTSSBsYXllcgo+ID4gPiBAQCAtMzYxLDYgKzM3NCwxMSBAQCBzdGF0aWMg aW50IHF1ZXVlY29tbWFuZF9sY2soc3RydWN0IHNjc2lfY21uZCAqc3JiLAo+ID4gPiAgIHsKPiA+ ID4gICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhzcmItPmRldmljZS0+aG9zdCk7 Cj4gPiA+ICsJaWYgKCF1cykgewo+ID4gCj4gPiBIb3cgaXMgdGhhdCBwb3NzaWJsZT8gIFRoaXMg ZG9lc24ndCBoYXZlIGFueXRoaW5nIHRvIGRvIHdpdGggeW91cgo+ID4gc3ViamVjdCBsaW5lLCBy aWdodD8KPiA+IAo+ID4gPiArCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMgPSBOVUxMXG4iLCBf X2Z1bmNfXyk7Cj4gPiA+ICsJCXJldHVybiAwOwo+ID4gCj4gPiBzdWNjZXNzPwo+IAo+IFtKRE1d IEkgbmVlZCB0byByZXR1cm4gLUVOWElPIGhlcmUuCgotRU5PREVWPwoKQnV0IGFnYWluLCBob3cg Y2FuIHRoaXMgaGFwcGVuPwoKdGhhbmtzLAoKZ3JlZyBrLWgKLS0tClRvIHVuc3Vic2NyaWJlIGZy b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRo ZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFq b3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRt bAo=