Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem From: Greg Kroah-Hartman Message-Id: <20180227181439.GB19944@kroah.com> Date: Tue, 27 Feb 2018 19:14:39 +0100 To: Joe Moriarty Cc: linux-usb@vger.kernel.org List-ID: T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMDk6NTk6NDBBTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdy b3RlOgo+IE9uIDIvMjYvMjAxOCAyOjM1IFBNLCBHcmVnIEtIIHdyb3RlOgo+ID4gT24gTW9uLCBG ZWIgMjYsIDIwMTggYXQgMDI6MDg6MDhQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdyb3RlOgo+ID4g PiBPbiAyLzI2LzIwMTggMToxMiBQTSwgR3JlZyBLSCB3cm90ZToKPiA+ID4gPiBPbiBNb24sIEZl YiAyNiwgMjAxOCBhdCAxMjoxMDowMlBNIC0wNTAwLCBKb2UgTW9yaWFydHkgd3JvdGU6Cj4gPiA+ ID4gPiBUaGUgUGFyZmFpdCAodmVyc2lvbiAyLjEuMCkgc3RhdGljIGNvZGUgYW5hbHlzaXMgdG9v bCBmb3VuZCB0aGUKPiA+ID4gPiA+IGZvbGxvd2luZyBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2Ug cHJvYmxlbS4KPiA+ID4gPiAKPiA+ID4gPiBXaGF0IGlzIHRoZSAiQ1dFIDQ3NiIgdGhpbmcgaW4g dGhlIHN1YmplY3QgbGluZSBmb3I/Cj4gPiA+ID4gCj4gPiA+IFtKRE1dCj4gPiA+IChDV0UgNDc2 KSBzdGFuZHMgZm9yIENvbW1vbiBXZWFrbmVzcyBFbnVtZXJhdGlvbi4KPiA+ID4gaHR0cHM6Ly9z ZWN1cjF0eS5jb20vY3dlL0NXRS00NzYvCj4gPiA+IAo+ID4gPiBJdCBpcyB0aGUgdHlwZSBvZiBz ZWN1cml0eSBmbGF3IHJlbGF0ZWQgdG8gYSBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UKPiA+IAo+ ID4gT2ssIHdoeSBwdXQgdGhhdCBpbiB0aGUgc3ViamVjdCBsaW5lIGFuZCBub3QganVzdCB0aGUg Ym9keSBvZiB0aGUKPiA+IGNoYW5nZWxvZyBpZiB5b3UgcmVhbGx5IHdhbnQgdG8gY2FsbCBzb21l dGhpbmcgb3V0IGxpa2UgdGhpcz8KPiA+IAo+ID4gPiA+ID4gZGV2X3RvX3Nob3N0KCkgaW4gaW5j bHVkZS9zY3NpL3Njc2lfaG9zdC5oIGhhcyB0aGUgYWJpbGl0eSB0byByZXR1cm4KPiA+ID4gPiA+ IE5VTEwgaWYgdGhlIHNjc2kgaG9zdCBkZXZpY2UgZG9lcyBub3QgaGF2ZSB0aGUgU2NzaV9ob3N0 LT5wYXJlbnQKPiA+ID4gPiA+IGZpZWxkIHNldC4gIFdpdGggdGhlIHBvc3NpYmlsdHkgb2YgYSBO VUxMIHBvaW50ZXIgYmVpbmcgc2V0IGZvcgo+ID4gPiA+ID4gdGhlIFNjc2lfSG9zdC0+cGFyZW50 IGZpZWxkLCBjYWxscyB0byBob3N0X3RvX3VzKCkgaGF2ZSB0byBtYWtlCj4gPiA+ID4gPiBzdXJl IHRoZSByZXR1cm4gcG9pbnRlciBpcyBub3QgbnVsbC4gIENoYW5nZXMgd2VyZSBtYWRlIHRvIGNo ZWNrCj4gPiA+ID4gPiBmb3IgYSByZXR1cm4gdmFsdWUgb2YgTlVMTCBvbiBjYWxscyB0byBob3N0 X3RvX3VzKCkuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEpvZSBNb3JpYXJ0 eSA8am9lLm1vcmlhcnR5QG9yYWNsZS5jb20+Cj4gPiA+ID4gPiBSZXZpZXdlZC1ieTogU3RldmVu IFNpc3RhcmUgPHN0ZXZlbi5zaXN0YXJlQG9yYWNsZS5jb20+Cj4gPiA+ID4gPiBBY2tlZC1ieTog SGFrb24gQnVnZ2UgPGhha29uLmJ1Z2dlQG9yYWNsZS5jb20+Cj4gPiA+ID4gPiAtLS0KPiA+ID4g PiA+ICAgIGRyaXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYyB8IDUzICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ID4gPiA+ID4gICAgMSBmaWxlIGNoYW5nZWQs IDQ2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMgYi9kcml2ZXJzL3VzYi9z dG9yYWdlL3Njc2lnbHVlLmMKPiA+ID4gPiA+IGluZGV4IGMyNjdmMjgxMmEwNC4uOTRhZjYwOWQ0 OWJmIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1ZS5j Cj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMKPiA+ID4gPiA+ IEBAIC02Niw2ICs2Niw5IEBAIHN0YXRpYyBpbnQgc2xhdmVfYWxsb2MgKHN0cnVjdCBzY3NpX2Rl dmljZSAqc2RldikKPiA+ID4gPiA+ICAgIHsKPiA+ID4gPiA+ICAgIAlzdHJ1Y3QgdXNfZGF0YSAq dXMgPSBob3N0X3RvX3VzKHNkZXYtPmhvc3QpOwo+ID4gPiA+ID4gKwlpZiAoIXVzKQo+ID4gPiA+ ID4gKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxuIiwgX19mdW5jX18pOwo+ID4g PiA+IAo+ID4gPiA+IEl0IGlzIGEgZHJpdmVyLCB5b3Ugc2hvdWxkIG5ldmVyIHVzZSBwcl8qIGNh bGxzLCBidXQgcmF0aGVyIGRldl8qIGNhbGxzLgo+ID4gPiA+IAo+ID4gPiA+IEFsc28sIHlvdSBk b24ndCBleGl0LCBhcmUgeW91IHN1cmUgdGhlIGNvZGUga2VlcHMgd29ya2luZyBhZnRlciB0aGlz Cj4gPiA+ID4gaGFwcGVucz8KPiA+ID4gPiAKPiA+ID4gPiBBbmQgd2hhdCBpcyBhIHVzZXIgc3Vw cG9zZWQgdG8gZG8gd2l0aCB0aGlzIHdhcm5pbmcgbWVzc2FnZT8KPiA+ID4gCj4gPiA+IFtKRE1d Cj4gPiAKPiA+ID8/PyAgWW91IG5lZWQgYSBiZXR0ZXIgZW1haWwgY2xpZW50LCBpbmxpbmUgY29t bWVudHMgYXJlIHRoZSBub3JtLgo+ID4gCj4gPiA+IC0gVGhlIG1lc3NhZ2VzIGFyZSB0YXJnZXRl ZCBmb3IgYSBkZXZlbG9wZXIgYW5kIG5vdCB0aGUgZW5kIHVzZXIuIEkgY2FuCj4gPiA+IGNoYW5n ZSBpdCB0byBkZXZfIGNhbGxzLgo+ID4gCj4gPiBCdXQgYW4gZW5kIHVzZXIgc2VlcyAiS0VSTl9X QVJOSU5HIiBtZXNzYWdlcywgcmlnaHQ/ICBJZiB0aGlzIGlzIGEKPiA+IGRlYnVnZ2luZy1vbmx5 IHRoaW5nLCB0aGVuIG1ha2UgaXQgYXMgc3VjaCwgYW5kIHByb3Blcmx5IHJlY292ZXIgZnJvbSBp dAo+ID4gYXMgaXQgY291bGQgYmUgaGl0IGR1cmluZyBub3JtYWwgb3BlcmF0aW9uLgo+ID4gCj4g PiA+ID4gPiArCj4gPiA+ID4gPiAgICAJLyoKPiA+ID4gPiA+ICAgIAkgKiBTZXQgdGhlIElOUVVJ UlkgdHJhbnNmZXIgbGVuZ3RoIHRvIDM2LiAgV2UgZG9uJ3QgdXNlIGFueSBvZgo+ID4gPiA+ID4g ICAgCSAqIHRoZSBleHRyYSBkYXRhIGFuZCBtYW55IGRldmljZXMgY2hva2UgaWYgYXNrZWQgZm9y IG1vcmUgb3IKPiA+ID4gPiA+IEBAIC0xMDIsNiArMTA1LDExIEBAIHN0YXRpYyBpbnQgc2xhdmVf Y29uZmlndXJlKHN0cnVjdCBzY3NpX2RldmljZSAqc2RldikKPiA+ID4gPiA+ICAgIHsKPiA+ID4g PiA+ICAgIAlzdHJ1Y3QgdXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKHNkZXYtPmhvc3QpOwo+ID4g PiA+ID4gKwlpZiAoIXVzKSB7Cj4gPiA+ID4gPiArCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMg PSBOVUxMXG4iLCBfX2Z1bmNfXyk7Cj4gPiA+ID4gPiArCQlyZXR1cm4gMDsKPiA+ID4gPiAKPiA+ ID4gPiBXaHkgYXJlIHlvdSByZXR1cm5pbmcgYSBzdWNjZXNzPwo+ID4gPiBbSkRNXQo+ID4gPiAt IFllcywgSSBuZWVkIHRvIHJldHVybiAtRU5YSU8gZm9yIHRoZSBzbGF2ZV9hbGxvYyByb3V0aW5l Lgo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiA+ICsJfQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gICAg CS8qCj4gPiA+ID4gPiAgICAJICogTWFueSBkZXZpY2VzIGhhdmUgdHJvdWJsZSB0cmFuc2ZlcnJp bmcgbW9yZSB0aGFuIDMyS0IgYXQgYSB0aW1lLAo+ID4gPiA+ID4gICAgCSAqIHdoaWxlIG90aGVy cyBoYXZlIHRyb3VibGUgd2l0aCBtb3JlIHRoYW4gNjRLLiBBdCB0aGlzIHRpbWUgd2UKPiA+ID4g PiA+IEBAIC0zMzEsNiArMzM5LDExIEBAIHN0YXRpYyBpbnQgdGFyZ2V0X2FsbG9jKHN0cnVjdCBz Y3NpX3RhcmdldCAqc3RhcmdldCkKPiA+ID4gPiA+ICAgIHsKPiA+ID4gPiA+ICAgIAlzdHJ1Y3Qg dXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKGRldl90b19zaG9zdChzdGFyZ2V0LT5kZXYucGFyZW50 KSk7Cj4gPiA+ID4gCj4gPiA+ID4gQ2FuIGhvc3RfdG9fdXMoKSBoYW5kbGUgTlVMTD8KPiA+ID4g PiAKPiA+ID4gPiBOb3BlLCBqdXN0IGxvb2tlZCBhdCBpdCwgdGhpcyB3aWxsIG5ldmVyIGNhdXNl IHRoZSByZXR1cm4gdmFsdWUgdG8gYmUKPiA+ID4gPiBOVUxMLCB5b3VyIGNoZWNrZXIgbmVlZHMg c29tZSBtb3JlIHdvcmsgOigKPiA+ID4gW0pETV0KPiA+ID4gVGhpcyB3aGF0IHRoZSBzdGF0aWMg Y29kZSBjaGVja2VyIGlzIGNhdGNoaW5nLiAgaG9zdF90b191cyB3aWxsIHJldHVybiBOVUxMCj4g PiA+IGlmIHRoZSBmb2xsb3dpbmcgb2NjdXJzLgo+ID4gPiAKPiA+ID4gJ2Rldl90b19zaG9zdCgp JyBpbiBpbmNsdWRlL3Njc2kvc2NzaV9ob3N0LmggbGluZSA3NTcuCj4gPiA+IAo+ID4gPiBUaGlz IGlzIGRvbmUgZXZlcnl0aW1lIGEgc2xhdmUgZGV2aWNlIGlzIGNyZWF0ZWQgYXQgdGhlIGZvbGxv d2luZyBjb2RlCj4gPiA+ICd0YXJnZXRfYWxsb2MoKScgaW4gZHJpdmVycy91c2Ivc3RvcmFnZS9z Y3NpZ2x1ZS5jICBsaW51ZSAzNDAuCj4gPiA+IAo+ID4gPiBUaGlzIG1lYW5zIHRoYXQgYW55IGNh bGwgdG8gaG9zdF90b191cyBpbiB0aGUgc2NzaWdsdWUgbW9kdWxlIHdpbGwgaGF2ZSB0aGUKPiA+ ID4gcG9zc2liaWxpdHkgb2Ygc2V0dGluZyB0aGUgcmV0dXJuIHZhbHVlIG9mIE5VTEwuICBJbiBm YWN0LCBJIHdvdWxkIG5lZWQgdG8KPiA+ID4gc3BsaXQgb3V0IHRoZSBmb2xsb3dpbmcgZW1iZWRk ZWQgY2FsbCBpbiAndGFyZ2V0X2FsbG9jKCknIHRvIGF2b2lkIGEKPiA+ID4gcG9zc2libGUgTlVM TCBwb2ludGVyIGRlcmVmZXJlbmNlLgo+ID4gPiAKPiA+ID4gc3RydWN0IHVzX2RhdGEgKnVzID0g aG9zdF90b191cyhkZXZfdG9fc2hvc3Qoc3RhcmdldC0+ZGV2LnBhcmVudCkpOwo+ID4gCj4gPiBF eGFjdGx5LCB5b3VyIGNoYW5nZSBkaWQgbm90aGluZywgYW5kIHVzIGlzIHByb2JhYmx5IG5vdCBO VUxMIGhlcmUuCj4gPiAKPiA+ID4gVGhlIHF1ZXN0aW9uIGJlY29tZXMsIENhbiBhIHNsYXZlIGRl dmljZSBldmVyIGhhdmUgaXQncyBwYXJlbnQgZmllbGQgc2V0IHRvCj4gPiA+IE5VTEwgKGllOiBk ZXYtPnBhcmVudCkuCj4gPiAKPiA+IEkgZG9uJ3QgdGhpbmsgaXQgY2FuLCBkbyB5b3Ugc2VlIGhv dz8KPiA+IAo+IE9rLCAgSSBiZWxpZXZlIHdlIHdlbnQgb2ZmIHRoZSBvcmlnaW5hbCBwcm9ibGVt IHRoaXMgcGF0Y2ggc29sdmVzLiBTaW5jZSB5b3UKPiBhbmQgSSBib3RoIGFncmVlIHRoYXQgYSBz bGF2ZSBkZXZpY2UgY2FuIG5ldmVyIGhhdmUgaXQncyBwYXJlbnQgZmllbGQgc2V0IHRvCj4gTlVM TCAoaWU6ICBkZXYtPnBhcmVudCkgdGhlbiB0aGlzIHBhdGNoIGJvaWxzIGRvd24gdG8gdGhlIGZv bGxvd2luZyBvbmUKPiBjaGFuZ2UuCj4gCj4gaW5jbHVkZS9zY3NpL3Njc2lfaG9zdC5oCj4gc3Rh dGljIGlubGluZSBzdHJ1Y3QgU2NzaV9Ib3N0ICpkZXZfdG9fc2hvc3Qoc3RydWN0IGRldmljZSAq ZGV2KQo+IHsKPiAJd2hpbGUgKCFzY3NpX2lzX2hvc3RfZGV2aWNlKGRldikpIHsKPiAJCWlmICgh ZGV2LT5wYXJlbnQpCj4gLQkJCXJldHVybiBOVUxMOwo+ICsJCQlCVUcoKTsKCk5vLCBuZXZlciBj cmFzaCB0aGUga2VybmVsLgoKV2h5IG5vdCBhc2sgdGhlIHNjc2kgZGV2ZWxvcGVycyBhYm91dCB0 aGlzPyAgVGhleSBwdXQgdGhhdCBsaW5lIHRoZXJlCmZvciBhIGdvb2QgcmVhc29uLCByaWdodD8K CkFuZCBpZiBOVUxMIGlzIHZhbGlkIHRvIHJldHVybiwgdGhlbiB5b3VyIHBhdGNoIHN0aWxsIGRv ZXMgbm90IGZpeCB0aGUKaXNzdWUgYXQgYWxsLCB3aGljaCB3YXMgbXkgbWFpbiBwb2ludC4KClNv IGdvIGFzayB0aGUgbGludXgtc2NzaSBsaXN0IGFib3V0IHRoaXMgZWl0aGVyIHdheS4KCnRoYW5r cywKCmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUg bGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8g bWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8v dmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK