Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem From: Greg Kroah-Hartman Message-Id: <20180227190542.GB12367@kroah.com> Date: Tue, 27 Feb 2018 20:05:42 +0100 To: Joe Moriarty Cc: linux-usb@vger.kernel.org List-ID: T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMDE6MjI6MjRQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdy b3RlOgo+IE9uIDIvMjcvMjAxOCAxOjE0IFBNLCBHcmVnIEtIIHdyb3RlOgo+ID4gT24gVHVlLCBG ZWIgMjcsIDIwMTggYXQgMDk6NTk6NDBBTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdyb3RlOgo+ID4g PiBPbiAyLzI2LzIwMTggMjozNSBQTSwgR3JlZyBLSCB3cm90ZToKPiA+ID4gPiBPbiBNb24sIEZl YiAyNiwgMjAxOCBhdCAwMjowODowOFBNIC0wNTAwLCBKb2UgTW9yaWFydHkgd3JvdGU6Cj4gPiA+ ID4gPiBPbiAyLzI2LzIwMTggMToxMiBQTSwgR3JlZyBLSCB3cm90ZToKPiA+ID4gPiA+ID4gT24g TW9uLCBGZWIgMjYsIDIwMTggYXQgMTI6MTA6MDJQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdyb3Rl Ogo+ID4gPiA+ID4gPiA+IFRoZSBQYXJmYWl0ICh2ZXJzaW9uIDIuMS4wKSBzdGF0aWMgY29kZSBh bmFseXNpcyB0b29sIGZvdW5kIHRoZQo+ID4gPiA+ID4gPiA+IGZvbGxvd2luZyBOVUxMIHBvaW50 ZXIgZGVyZWZlcmVuY2UgcHJvYmxlbS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFdoYXQgaXMg dGhlICJDV0UgNDc2IiB0aGluZyBpbiB0aGUgc3ViamVjdCBsaW5lIGZvcj8KPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiBbSkRNXQo+ID4gPiA+ID4gKENXRSA0NzYpIHN0YW5kcyBmb3IgQ29tbW9uIFdl YWtuZXNzIEVudW1lcmF0aW9uLgo+ID4gPiA+ID4gaHR0cHM6Ly9zZWN1cjF0eS5jb20vY3dlL0NX RS00NzYvCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEl0IGlzIHRoZSB0eXBlIG9mIHNlY3VyaXR5IGZs YXcgcmVsYXRlZCB0byBhIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZQo+ID4gPiA+IAo+ID4gPiA+ IE9rLCB3aHkgcHV0IHRoYXQgaW4gdGhlIHN1YmplY3QgbGluZSBhbmQgbm90IGp1c3QgdGhlIGJv ZHkgb2YgdGhlCj4gPiA+ID4gY2hhbmdlbG9nIGlmIHlvdSByZWFsbHkgd2FudCB0byBjYWxsIHNv bWV0aGluZyBvdXQgbGlrZSB0aGlzPwo+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IGRldl90b19zaG9z dCgpIGluIGluY2x1ZGUvc2NzaS9zY3NpX2hvc3QuaCBoYXMgdGhlIGFiaWxpdHkgdG8gcmV0dXJu Cj4gPiA+ID4gPiA+ID4gTlVMTCBpZiB0aGUgc2NzaSBob3N0IGRldmljZSBkb2VzIG5vdCBoYXZl IHRoZSBTY3NpX2hvc3QtPnBhcmVudAo+ID4gPiA+ID4gPiA+IGZpZWxkIHNldC4gIFdpdGggdGhl IHBvc3NpYmlsdHkgb2YgYSBOVUxMIHBvaW50ZXIgYmVpbmcgc2V0IGZvcgo+ID4gPiA+ID4gPiA+ IHRoZSBTY3NpX0hvc3QtPnBhcmVudCBmaWVsZCwgY2FsbHMgdG8gaG9zdF90b191cygpIGhhdmUg dG8gbWFrZQo+ID4gPiA+ID4gPiA+IHN1cmUgdGhlIHJldHVybiBwb2ludGVyIGlzIG5vdCBudWxs LiAgQ2hhbmdlcyB3ZXJlIG1hZGUgdG8gY2hlY2sKPiA+ID4gPiA+ID4gPiBmb3IgYSByZXR1cm4g dmFsdWUgb2YgTlVMTCBvbiBjYWxscyB0byBob3N0X3RvX3VzKCkuCj4gPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSm9lIE1vcmlhcnR5IDxqb2UubW9yaWFydHlAb3Jh Y2xlLmNvbT4KPiA+ID4gPiA+ID4gPiBSZXZpZXdlZC1ieTogU3RldmVuIFNpc3RhcmUgPHN0ZXZl bi5zaXN0YXJlQG9yYWNsZS5jb20+Cj4gPiA+ID4gPiA+ID4gQWNrZWQtYnk6IEhha29uIEJ1Z2dl IDxoYWtvbi5idWdnZUBvcmFjbGUuY29tPgo+ID4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ ICAgICBkcml2ZXJzL3VzYi9zdG9yYWdlL3Njc2lnbHVlLmMgfCA1MyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0KPiA+ID4gPiA+ID4gPiAgICAgMSBmaWxlIGNoYW5n ZWQsIDQ2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYyBiL2Ry aXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYwo+ID4gPiA+ID4gPiA+IGluZGV4IGMyNjdmMjgx MmEwNC4uOTRhZjYwOWQ0OWJmIDEwMDY0NAo+ID4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdXNi L3N0b3JhZ2Uvc2NzaWdsdWUuYwo+ID4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdXNiL3N0b3Jh Z2Uvc2NzaWdsdWUuYwo+ID4gPiA+ID4gPiA+IEBAIC02Niw2ICs2Niw5IEBAIHN0YXRpYyBpbnQg c2xhdmVfYWxsb2MgKHN0cnVjdCBzY3NpX2RldmljZSAqc2RldikKPiA+ID4gPiA+ID4gPiAgICAg ewo+ID4gPiA+ID4gPiA+ICAgICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhzZGV2 LT5ob3N0KTsKPiA+ID4gPiA+ID4gPiArCWlmICghdXMpCj4gPiA+ID4gPiA+ID4gKwkJcHJfd2Fy bigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxuIiwgX19mdW5jX18pOwo+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gSXQgaXMgYSBkcml2ZXIsIHlvdSBzaG91bGQgbmV2ZXIgdXNlIHByXyogY2FsbHMs IGJ1dCByYXRoZXIgZGV2XyogY2FsbHMuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBBbHNvLCB5 b3UgZG9uJ3QgZXhpdCwgYXJlIHlvdSBzdXJlIHRoZSBjb2RlIGtlZXBzIHdvcmtpbmcgYWZ0ZXIg dGhpcwo+ID4gPiA+ID4gPiBoYXBwZW5zPwo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gQW5kIHdo YXQgaXMgYSB1c2VyIHN1cHBvc2VkIHRvIGRvIHdpdGggdGhpcyB3YXJuaW5nIG1lc3NhZ2U/Cj4g PiA+ID4gPiAKPiA+ID4gPiA+IFtKRE1dCj4gPiA+ID4gCj4gPiA+ID4gPz8/ICBZb3UgbmVlZCBh IGJldHRlciBlbWFpbCBjbGllbnQsIGlubGluZSBjb21tZW50cyBhcmUgdGhlIG5vcm0uCj4gPiA+ ID4gCj4gPiA+ID4gPiAtIFRoZSBtZXNzYWdlcyBhcmUgdGFyZ2V0ZWQgZm9yIGEgZGV2ZWxvcGVy IGFuZCBub3QgdGhlIGVuZCB1c2VyLiBJIGNhbgo+ID4gPiA+ID4gY2hhbmdlIGl0IHRvIGRldl8g Y2FsbHMuCj4gPiA+ID4gCj4gPiA+ID4gQnV0IGFuIGVuZCB1c2VyIHNlZXMgIktFUk5fV0FSTklO RyIgbWVzc2FnZXMsIHJpZ2h0PyAgSWYgdGhpcyBpcyBhCj4gPiA+ID4gZGVidWdnaW5nLW9ubHkg dGhpbmcsIHRoZW4gbWFrZSBpdCBhcyBzdWNoLCBhbmQgcHJvcGVybHkgcmVjb3ZlciBmcm9tIGl0 Cj4gPiA+ID4gYXMgaXQgY291bGQgYmUgaGl0IGR1cmluZyBub3JtYWwgb3BlcmF0aW9uLgo+ID4g PiA+IAo+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiAgICAgCS8qCj4gPiA+ID4gPiA+ID4g ICAgIAkgKiBTZXQgdGhlIElOUVVJUlkgdHJhbnNmZXIgbGVuZ3RoIHRvIDM2LiAgV2UgZG9uJ3Qg dXNlIGFueSBvZgo+ID4gPiA+ID4gPiA+ICAgICAJICogdGhlIGV4dHJhIGRhdGEgYW5kIG1hbnkg ZGV2aWNlcyBjaG9rZSBpZiBhc2tlZCBmb3IgbW9yZSBvcgo+ID4gPiA+ID4gPiA+IEBAIC0xMDIs NiArMTA1LDExIEBAIHN0YXRpYyBpbnQgc2xhdmVfY29uZmlndXJlKHN0cnVjdCBzY3NpX2Rldmlj ZSAqc2RldikKPiA+ID4gPiA+ID4gPiAgICAgewo+ID4gPiA+ID4gPiA+ICAgICAJc3RydWN0IHVz X2RhdGEgKnVzID0gaG9zdF90b191cyhzZGV2LT5ob3N0KTsKPiA+ID4gPiA+ID4gPiArCWlmICgh dXMpIHsKPiA+ID4gPiA+ID4gPiArCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMgPSBOVUxMXG4i LCBfX2Z1bmNfXyk7Cj4gPiA+ID4gPiA+ID4gKwkJcmV0dXJuIDA7Cj4gPiA+ID4gPiA+IAo+ID4g PiA+ID4gPiBXaHkgYXJlIHlvdSByZXR1cm5pbmcgYSBzdWNjZXNzPwo+ID4gPiA+ID4gW0pETV0K PiA+ID4gPiA+IC0gWWVzLCBJIG5lZWQgdG8gcmV0dXJuIC1FTlhJTyBmb3IgdGhlIHNsYXZlX2Fs bG9jIHJvdXRpbmUuCj4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gKwl9Cj4g PiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ICAgICAJLyoKPiA+ID4gPiA+ID4gPiAgICAgCSAq IE1hbnkgZGV2aWNlcyBoYXZlIHRyb3VibGUgdHJhbnNmZXJyaW5nIG1vcmUgdGhhbiAzMktCIGF0 IGEgdGltZSwKPiA+ID4gPiA+ID4gPiAgICAgCSAqIHdoaWxlIG90aGVycyBoYXZlIHRyb3VibGUg d2l0aCBtb3JlIHRoYW4gNjRLLiBBdCB0aGlzIHRpbWUgd2UKPiA+ID4gPiA+ID4gPiBAQCAtMzMx LDYgKzMzOSwxMSBAQCBzdGF0aWMgaW50IHRhcmdldF9hbGxvYyhzdHJ1Y3Qgc2NzaV90YXJnZXQg KnN0YXJnZXQpCj4gPiA+ID4gPiA+ID4gICAgIHsKPiA+ID4gPiA+ID4gPiAgICAgCXN0cnVjdCB1 c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoZGV2X3RvX3Nob3N0KHN0YXJnZXQtPmRldi5wYXJlbnQp KTsKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IENhbiBob3N0X3RvX3VzKCkgaGFuZGxlIE5VTEw/ Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBOb3BlLCBqdXN0IGxvb2tlZCBhdCBpdCwgdGhpcyB3 aWxsIG5ldmVyIGNhdXNlIHRoZSByZXR1cm4gdmFsdWUgdG8gYmUKPiA+ID4gPiA+ID4gTlVMTCwg eW91ciBjaGVja2VyIG5lZWRzIHNvbWUgbW9yZSB3b3JrIDooCj4gPiA+ID4gPiBbSkRNXQo+ID4g PiA+ID4gVGhpcyB3aGF0IHRoZSBzdGF0aWMgY29kZSBjaGVja2VyIGlzIGNhdGNoaW5nLiAgaG9z dF90b191cyB3aWxsIHJldHVybiBOVUxMCj4gPiA+ID4gPiBpZiB0aGUgZm9sbG93aW5nIG9jY3Vy cy4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gJ2Rldl90b19zaG9zdCgpJyBpbiBpbmNsdWRlL3Njc2kv c2NzaV9ob3N0LmggbGluZSA3NTcuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgaXMgZG9uZSBl dmVyeXRpbWUgYSBzbGF2ZSBkZXZpY2UgaXMgY3JlYXRlZCBhdCB0aGUgZm9sbG93aW5nIGNvZGUK PiA+ID4gPiA+ICd0YXJnZXRfYWxsb2MoKScgaW4gZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1 ZS5jICBsaW51ZSAzNDAuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgbWVhbnMgdGhhdCBhbnkg Y2FsbCB0byBob3N0X3RvX3VzIGluIHRoZSBzY3NpZ2x1ZSBtb2R1bGUgd2lsbCBoYXZlIHRoZQo+ ID4gPiA+ID4gcG9zc2liaWxpdHkgb2Ygc2V0dGluZyB0aGUgcmV0dXJuIHZhbHVlIG9mIE5VTEwu ICBJbiBmYWN0LCBJIHdvdWxkIG5lZWQgdG8KPiA+ID4gPiA+IHNwbGl0IG91dCB0aGUgZm9sbG93 aW5nIGVtYmVkZGVkIGNhbGwgaW4gJ3RhcmdldF9hbGxvYygpJyB0byBhdm9pZCBhCj4gPiA+ID4g PiBwb3NzaWJsZSBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UuCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IHN0cnVjdCB1c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoZGV2X3RvX3Nob3N0KHN0YXJnZXQtPmRl di5wYXJlbnQpKTsKPiA+ID4gPiAKPiA+ID4gPiBFeGFjdGx5LCB5b3VyIGNoYW5nZSBkaWQgbm90 aGluZywgYW5kIHVzIGlzIHByb2JhYmx5IG5vdCBOVUxMIGhlcmUuCj4gPiA+ID4gCj4gPiA+ID4g PiBUaGUgcXVlc3Rpb24gYmVjb21lcywgQ2FuIGEgc2xhdmUgZGV2aWNlIGV2ZXIgaGF2ZSBpdCdz IHBhcmVudCBmaWVsZCBzZXQgdG8KPiA+ID4gPiA+IE5VTEwgKGllOiBkZXYtPnBhcmVudCkuCj4g PiA+ID4gCj4gPiA+ID4gSSBkb24ndCB0aGluayBpdCBjYW4sIGRvIHlvdSBzZWUgaG93Pwo+ID4g PiA+IAo+ID4gPiBPaywgIEkgYmVsaWV2ZSB3ZSB3ZW50IG9mZiB0aGUgb3JpZ2luYWwgcHJvYmxl bSB0aGlzIHBhdGNoIHNvbHZlcy4gU2luY2UgeW91Cj4gPiA+IGFuZCBJIGJvdGggYWdyZWUgdGhh dCBhIHNsYXZlIGRldmljZSBjYW4gbmV2ZXIgaGF2ZSBpdCdzIHBhcmVudCBmaWVsZCBzZXQgdG8K PiA+ID4gTlVMTCAoaWU6ICBkZXYtPnBhcmVudCkgdGhlbiB0aGlzIHBhdGNoIGJvaWxzIGRvd24g dG8gdGhlIGZvbGxvd2luZyBvbmUKPiA+ID4gY2hhbmdlLgo+ID4gPiAKPiA+ID4gaW5jbHVkZS9z Y3NpL3Njc2lfaG9zdC5oCj4gPiA+IHN0YXRpYyBpbmxpbmUgc3RydWN0IFNjc2lfSG9zdCAqZGV2 X3RvX3Nob3N0KHN0cnVjdCBkZXZpY2UgKmRldikKPiA+ID4gewo+ID4gPiAJd2hpbGUgKCFzY3Np X2lzX2hvc3RfZGV2aWNlKGRldikpIHsKPiA+ID4gCQlpZiAoIWRldi0+cGFyZW50KQo+ID4gPiAt CQkJcmV0dXJuIE5VTEw7Cj4gPiA+ICsJCQlCVUcoKTsKPiA+IAo+ID4gTm8sIG5ldmVyIGNyYXNo IHRoZSBrZXJuZWwuCj4gVGhlcmUgaXMgQnVnKCkgdGhyb3VnaG91dCB0aGUga2VybmVsLiAgU28g dGhhdCBpcyBpbnZhbGlkLgoKTm9wZSwgd2UgYXJlIHRyeWluZyB0byBnZXQgcmlkIG9mIHRoZW0u ICBJZiB5b3Ugc2VlIG5ldyBvbmVzIGJlaW5nCmFkZGVkLCBwbGVhc2UgcG9pbnQgaXQgb3V0LgoK PiBLZXJuZWwgRGV2ZWxvcGVycyB3aWxsIHB1dCBpbiBCdWcoKSBzdGF0ZW1lbnRzIGFueXdoZXJl IHRoZSBjb2RlIGlzCj4gbm90IHN1cHBvc2UgdG8gZ28uICBJdCBpcyBlYXNpZXIgdG8gZGVidWcg YW5kIHRoZW4gdHJ5aW5nIHRvIGJhY2t0cmFjZQo+IGZyb20gYSBzaWRlIGVmZmVjdCBpc3N1ZS4K Ck5vdCBhdCBhbGwsIGl0IGNhdXNlcyB0aGUgbWFjaGluZSB0byBjcmFzaCBhbmQgbWFrZSBpdCBo YXJkZXIgdG8gZGVidWcuCk9yIGl0IGNhdXNlcyBhIHJlYm9vdC4gIEV2ZW4gV0FSTl9PTigpIHNo b3VsZCBub3QgYmUgdXNlZCBmb3IgZGVidWdnaW5nCmFzIHdlIGFyZSBzZWVpbmcgdG9vbHMgaGl0 IHRob3NlIGFuZCByZWJvb3QgYW5kIGNvbXBsYWluIChzZWUgdGhlCnN5emthbGxlciB0aHJlYWRz IGFib3V0IHRoaXMuKQoKSWYgeW91IHdhbnQgYSBkZWJ1Z2dpbmcgbWVzc2FnZSwgbWFrZSBpdCBh IGRlYnVnZ2luZyBtZXNzYWdlIHVzaW5nCmRldl9kYmcoKS4gIFRoYXQncyBhbGwgdGhhdCBpcyBu ZWVkZWQuCgo+ID4gV2h5IG5vdCBhc2sgdGhlIHNjc2kgZGV2ZWxvcGVycyBhYm91dCB0aGlzPyAg VGhleSBwdXQgdGhhdCBsaW5lIHRoZXJlCj4gPiBmb3IgYSBnb29kIHJlYXNvbiwgcmlnaHQ/Cj4g SSBzdWJtaXR0ZWQgdGhlIG9yaWdpbmFsIHBhdGNoIGhlcmUgYmVjYXVzZSB0aGUgb3JpZ2luYWwg cGF0Y2ggd2FzIGluIHRoZQo+IGRyaXZlcnMvdXNiL3N0b3JhZ2UgZGlyZWN0b3J5IG9mIHdoaWNo IHlvdSBhcmUgdGhlIG1haW50YWluZXIuCgpCdXQgdGhpcyBpcyBhIHNjc2kgY29yZSBhcGkgY2Fs bCwgSSBrbm93IG5vdGhpbmcgYWJvdXQgdGhhdCA6KQoKPiA+IEFuZCBpZiBOVUxMIGlzIHZhbGlk IHRvIHJldHVybiwgdGhlbiB5b3VyIHBhdGNoIHN0aWxsIGRvZXMgbm90IGZpeCB0aGUKPiA+IGlz c3VlIGF0IGFsbCwgd2hpY2ggd2FzIG15IG1haW4gcG9pbnQuCj4gWWVzIGl0IGRvZXMuICBBIE5V TEwgcmV0dXJuIGZyb20gZGV2X3RvX3Nob3N0IHdpbGwga2VybmVsIHBhbmljIHRoZSBtYWNoaW5l Cj4gaW4gbXVsdGlwbGUgcGxhY2VzIGluIHRoZSBTQ1NJIGtlcm5lbCBtb2R1bGVzLiAgU3dhcHBp bmcgb3V0IHRoZSBOVUxMIHdpdGggYQo+IEJVRygpIHdpbGwgZG8gdGhhdC4KCk5laXRoZXIgaXMg Z29vZCB0byBoYXZlLCB0aGV5IHNob3VsZCBhbGwgYmUgZml4ZWQuCgp0aGFua3MsCgpncmVnIGst aAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2 Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==