From: Christoph Hellwig Date: Wed, 28 Feb 2018 10:07:50 -0800 Subject: [Cluster-devel] [PATCH] gfs2: Dirty source inode during rename In-Reply-To: <20180227115011.9878-1-agruenba@redhat.com> References: <20180227115011.9878-1-agruenba@redhat.com> Message-ID: <20180228180750.GA23511@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Feb 27, 2018 at 12:50:11PM +0100, Andreas Gruenbacher wrote: > Mark the source inode dirty during a rename instead of just updating the > underlying buffer head. Otherwise, fsync may find the inode clean and > will then skip flushing the journal. A subsequent power failure will > cause the rename to be lost. This happens in command sequences like: Looks good, Reviewed-by: Christoph Hellwig