Date: Fri, 2 Mar 2018 11:56:52 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20180302035652.GW27381@xz-mi>
References: <20180301084438.13594-1-peterx@redhat.com>
	<20180301084438.13594-5-peterx@redhat.com>
	<20180301160344.GU14643@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180301160344.GU14643@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 04/15] migration: let incoming side use
 thread context
To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Juan Quintela <quintela@redhat.com>, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Laurent Vivier <lvivier@redhat.com>

On Thu, Mar 01, 2018 at 04:03:44PM +0000, Daniel P. Berrang=C3=A9 wrote:
> On Thu, Mar 01, 2018 at 04:44:27PM +0800, Peter Xu wrote:
> > The old incoming migration is running in main thread and default
> > gcontext.  With the new qio_channel_add_watch_full() we can now let i=
t
> > run in the thread's own gcontext (if there is one).
> >=20
> > Currently this patch does nothing alone.  But when any of the incomin=
g
> > migration is run in another iothread (e.g., the upcoming migrate-reco=
ver
> > command), this patch will bind the incoming logic to the iothread
> > instead of the main thread (which may already get page faulted and
> > hanged).
> >=20
> > RDMA is not considered for now since it's not even using the QIO watc=
h
> > framework at all.
> >=20
> > CC: Juan Quintela <quintela@redhat.com>
> > CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > CC: Laurent Vivier <lvivier@redhat.com>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  migration/exec.c   |  9 ++++-----
> >  migration/fd.c     |  9 ++++-----
> >  migration/socket.c | 10 +++++-----
> >  3 files changed, 13 insertions(+), 15 deletions(-)
>=20
> This should probably just be in a separate series, since it does nothin=
g
> on its own, and nothing following in this series touches migration at a=
ll.

It was trying to solve all problems related to QIO+context, and
migration is just one user of it.  But sure I can postpone this patch
to the postcopy recovery series.

Thanks,

--=20
Peter Xu