Return-Path: Date: Fri, 9 Mar 2018 09:34:18 +0200 From: Heikki Krogerus Subject: Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery Message-ID: <20180309073418.GF21904@kuha.fi.intel.com> References: <1519645759-12701-1-git-send-email-jun.li@nxp.com> <1519645759-12701-11-git-send-email-jun.li@nxp.com> <20522804-65ab-5d48-716a-c199e4c095fc@samsung.com> <133b5194-26ff-071a-d3d1-2bfca1375cae@samsung.com> <20180306120202.GA4951@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Jun Li Cc: Andrzej Hajda , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "linux@roeck-us.net" , "mark.rutland@arm.com" , "yueyao@google.com" , Peter Chen , "garsilva@embeddedor.com" , "o_leveque@orange.fr" , "shufan_lee@richtek.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx List-ID: On Thu, Mar 08, 2018 at 01:41:23AM +0000, Jun Li wrote: > > If you are asking my opinion, the data role must be handled as separate > > capability of the port, i.e. you probable want to have separate properties for > > the power role and data role, even if we did not support that yet in the class > > code. Don't use "port-type" name, just call them "power-role" and > > "data-role" from now on. > > > > OK, I will introduce power-role and data-role, meanwhile, I think the class code > should be changed accordingly(looks like your attached patch is doing that). True. I'll send the patch out now. Thanks, -- heikki