Return-Path: <netdev-owner@vger.kernel.org>
Received: from zimbra.alphalink.fr ([217.15.80.77]:41673 "EHLO
        zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932342AbeCLRLD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 12 Mar 2018 13:11:03 -0400
Date: Mon, 12 Mar 2018 18:11:00 +0100
From: Guillaume Nault <g.nault@alphalink.fr>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        James Chapman <jchapman@katalix.com>,
        Wei Wang <weiwan@google.com>, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6
 addresses
Message-ID: <20180312171100.GG1351@alphalink.fr>
References: <cover.1520587816.git.pabeni@redhat.com>
 <976644da07bf409c9b4463cf74f1a1981daa0b49.1520587816.git.pabeni@redhat.com>
 <20180309164326.GD1351@alphalink.fr>
 <1520615043.2802.39.camel@redhat.com>
 <20180309174750.GE1351@alphalink.fr>
 <1520618280.2802.50.camel@redhat.com>
 <20180309182634.GF1351@alphalink.fr>
 <1520844798.2585.13.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1520844798.2585.13.camel@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Mar 12, 2018 at 09:53:18AM +0100, Paolo Abeni wrote:
> On Fri, 2018-03-09 at 19:26 +0100, Guillaume Nault wrote:
> > On Fri, Mar 09, 2018 at 06:58:00PM +0100, Paolo Abeni wrote:
> > > The single threaded reproducer does not trigger anymore after 1/2,
> > > _but_ if ask syzbot to test 1/2 that will trigger another splat,
> > > because syzbot will do also multi threaded tests and we will hit the
> > > race between connect(tunnel->fd) and l2tp_tunnel_create(),
> > > 
> > 
> > Ok, and this case is handled by the sk_state test in l2tp_xmit_skb(),
> > right?
> 
> We need both such test and checking for v4mapped address in
> l2tp_xmit_skb()
> 
> > I just want to be sure that I didn't miss anything and that patch 1/2
> > combined with the socket state check in l2tp_xmit_skb() are enough to
> > fix the bug. And that overriding ->inet_*addr can be removed entirely
> > (and safely!).
> 
> I tested the above in vs the repro and in some real use case, but any
> additinal pair of eyes are welcome!
> 
It looks good to me too. I think everything is cleared up now.
Nice work!