From: Ville Syrjala Subject: [PATCH 3/3] drm/i915: Eliminate the horrendous format check code Date: Mon, 12 Mar 2018 22:40:35 +0200 Message-ID: <20180312204035.31387-3-ville.syrjala@linux.intel.com> References: <20180312204035.31387-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180312204035.31387-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCk5v dyB0aGF0IHRoZSBjb3JlIG1ha2VzIHN1cmUgdGhhdCB0aGUgcGl4ZWwgZm9ybWF0IGlzIHN1cHBv cnRlZApieSBhdCBsZWFzdCBvbmUgcGxhbmUsIHdlIGNhbiBlbGltaW5hdGUgdGhlIGhhbmQgcm9s bGVkIGNvZGUgZm9yIHRoZQpzYW1lIHRoaW5nIGluIGk5MTUuIFRoZSB3YXkgd2Ugd2VyZSBkb2lu ZyB3YXMgZXh0cmVtZWx5IGluY29udmVuaWVudApiZWNhdXNlIG5vdCBvbmx5IGRpZCB5b3UgaGF2 ZSB0byBhZGQgdGhlIGZvcm1hdCB0byB0aGUgcGxhbmUncyBmb3JtYXQKbGlzdCwgYnV0IHlvdSBh bHNvIGhhZCB0byBjb21lIHVwIHdpdGggdGhlIGNvcnJlY3QgcGxhdGZvcm0gY2hlY2tzCmZvciB0 aGlzIGNvZGUuCgp2MjogTnVrZSB0aGUgbW9kaWZpZXIgY2hlY2tzIGFzIHdlbGwgc2luY2UgdGhl IGNvcmUgZG9lcyB0aGF0IHRvbyBub3cKdjM6IENhbGwgZHJtX2FueV9wbGFuZV9oYXNfZm9ybWF0 KCkgZnJvbSB0aGUgZHJpdmVyIGNvZGUKdjQ6IEdvIGJhY2sgdG8gbGV0dGluZyB0aGUgY29yZSBk byBldmVyeXRoaW5nCgpTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDg2IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDg2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwpp bmRleCA1MWQ4ZDBjNDA2NzQuLjAyOGE3OTE4ODljNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwpAQCAtMTM5ODksNyArMTM5ODksNiBAQCBzdGF0aWMgaW50IGludGVsX2ZyYW1l YnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKIHsKIAlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KG9iai0+YmFzZS5kZXYpOwog CXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gJmludGVsX2ZiLT5iYXNlOwotCXN0cnVjdCBk cm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwogCXUzMiBwaXRjaF9saW1pdDsKIAl1bnNp Z25lZCBpbnQgdGlsaW5nLCBzdHJpZGU7CiAJaW50IHJldCA9IC1FSU5WQUw7CkBAIC0xNDAxNCwz NyArMTQwMTMsNiBAQCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGlu dGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKIAkJZ290byBlcnI7CiAJfQogCi0JLyogUGFzc2Vk IGluIG1vZGlmaWVyIHNhbml0eSBjaGVja2luZy4gKi8KLQlzd2l0Y2ggKG1vZGVfY21kLT5tb2Rp ZmllclswXSkgewotCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTOgotCWNhc2UgSTkx NV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUzoKLQkJc3dpdGNoIChtb2RlX2NtZC0+cGl4ZWxfZm9y bWF0KSB7Ci0JCWNhc2UgRFJNX0ZPUk1BVF9YQkdSODg4ODoKLQkJY2FzZSBEUk1fRk9STUFUX0FC R1I4ODg4OgotCQljYXNlIERSTV9GT1JNQVRfWFJHQjg4ODg6Ci0JCWNhc2UgRFJNX0ZPUk1BVF9B UkdCODg4ODoKLQkJCWJyZWFrOwotCQlkZWZhdWx0OgotCQkJRFJNX0RFQlVHX0tNUygiUkMgc3Vw cG9ydGVkIG9ubHkgd2l0aCBSR0I4ODg4IGZvcm1hdHNcbiIpOwotCQkJZ290byBlcnI7Ci0JCX0K LQkJLyogZmFsbCB0aHJvdWdoICovCi0JY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRDoKLQlj YXNlIEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRDoKLQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg PCA5KSB7Ci0JCQlEUk1fREVCVUdfS01TKCJVbnN1cHBvcnRlZCB0aWxpbmcgMHglbGx4IVxuIiwK LQkJCQkgICAgICBtb2RlX2NtZC0+bW9kaWZpZXJbMF0pOwotCQkJZ290byBlcnI7Ci0JCX0KLQlj YXNlIERSTV9GT1JNQVRfTU9EX0xJTkVBUjoKLQljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVE OgotCQlicmVhazsKLQlkZWZhdWx0OgotCQlEUk1fREVCVUdfS01TKCJVbnN1cHBvcnRlZCBmYiBt b2RpZmllciAweCVsbHghXG4iLAotCQkJICAgICAgbW9kZV9jbWQtPm1vZGlmaWVyWzBdKTsKLQkJ Z290byBlcnI7Ci0JfQotCiAJLyoKIAkgKiBnZW4yLzMgZGlzcGxheSBlbmdpbmUgdXNlcyB0aGUg ZmVuY2UgaWYgcHJlc2VudCwKIAkgKiBzbyB0aGUgdGlsaW5nIG1vZGUgbXVzdCBtYXRjaCB0aGUg ZmIgbW9kaWZpZXIgZXhhY3RseS4KQEAgLTE0MDc1LDYwICsxNDA0Myw2IEBAIHN0YXRpYyBpbnQg aW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2Zi LAogCQlnb3RvIGVycjsKIAl9CiAKLQkvKiBSZWplY3QgZm9ybWF0cyBub3Qgc3VwcG9ydGVkIGJ5 IGFueSBwbGFuZSBlYXJseS4gKi8KLQlzd2l0Y2ggKG1vZGVfY21kLT5waXhlbF9mb3JtYXQpIHsK LQljYXNlIERSTV9GT1JNQVRfQzg6Ci0JY2FzZSBEUk1fRk9STUFUX1JHQjU2NToKLQljYXNlIERS TV9GT1JNQVRfWFJHQjg4ODg6Ci0JY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4OgotCQlicmVhazsK LQljYXNlIERSTV9GT1JNQVRfWFJHQjE1NTU6Ci0JCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID4g MykgewotCQkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwK LQkJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQsICZm b3JtYXRfbmFtZSkpOwotCQkJZ290byBlcnI7Ci0JCX0KLQkJYnJlYWs7Ci0JY2FzZSBEUk1fRk9S TUFUX0FCR1I4ODg4OgotCQlpZiAoIUlTX1ZBTExFWVZJRVcoZGV2X3ByaXYpICYmICFJU19DSEVS UllWSUVXKGRldl9wcml2KSAmJgotCQkgICAgSU5URUxfR0VOKGRldl9wcml2KSA8IDkpIHsKLQkJ CURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCi0JCQkJICAg ICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25h bWUpKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCWJyZWFrOwotCWNhc2UgRFJNX0ZPUk1BVF9YQkdS ODg4ODoKLQljYXNlIERSTV9GT1JNQVRfWFJHQjIxMDEwMTA6Ci0JY2FzZSBEUk1fRk9STUFUX1hC R1IyMTAxMDEwOgotCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDQpIHsKLQkJCURSTV9ERUJV R19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCi0JCQkJICAgICAgZHJtX2dl dF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsKLQkJ CWdvdG8gZXJyOwotCQl9Ci0JCWJyZWFrOwotCWNhc2UgRFJNX0ZPUk1BVF9BQkdSMjEwMTAxMDoK LQkJaWYgKCFJU19WQUxMRVlWSUVXKGRldl9wcml2KSAmJiAhSVNfQ0hFUlJZVklFVyhkZXZfcHJp dikpIHsKLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIs Ci0JCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAm Zm9ybWF0X25hbWUpKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCWJyZWFrOwotCWNhc2UgRFJNX0ZP Uk1BVF9ZVVlWOgotCWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgotCWNhc2UgRFJNX0ZPUk1BVF9ZVllV OgotCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgotCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDUg JiYgIUlTX0c0WChkZXZfcHJpdikpIHsKLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBp eGVsIGZvcm1hdDogJXNcbiIsCi0JCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2Nt ZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsKLQkJCWdvdG8gZXJyOwotCQl9Ci0JCWJy ZWFrOwotCWRlZmF1bHQ6Ci0JCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1h dDogJXNcbiIsCi0JCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9m b3JtYXQsICZmb3JtYXRfbmFtZSkpOwotCQlnb3RvIGVycjsKLQl9Ci0KIAkvKiBGSVhNRSBuZWVk IHRvIGFkanVzdCBMSU5PRkYvVElMRU9GRiBhY2NvcmRpbmdseS4gKi8KIAlpZiAobW9kZV9jbWQt Pm9mZnNldHNbMF0gIT0gMCkKIAkJZ290byBlcnI7Ci0tIAoyLjE2LjEKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=