Return-Path: Received: from verein.lst.de ([213.95.11.211]:56629 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007AbeCMIWd (ORCPT ); Tue, 13 Mar 2018 04:22:33 -0400 Date: Tue, 13 Mar 2018 09:22:32 +0100 From: Christoph Hellwig To: Bob Peterson Cc: Andreas Gruenbacher , Dave Chinner , linux-fsdevel@vger.kernel.org Subject: gfs2 IOMAP_ZERO confusion Message-ID: <20180313082232.GA666@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Bob, In "GFS2: Implement iomap for block_map" you seem to have misunderstood the intention of the IOMAP_ZERO flag. It it set if iomap_begin is called for a zeroing operation, so that we don't allocate new blocks for holes or unwritten extents. It is not supposed to actually zero the blocks. Can you use some other way to communicate you internal zeroing request?