From: Daniel Vetter Subject: Re: [PATCH 1/6] Revert "drm/atomic-helper: Fix leak in disable_all" Date: Wed, 21 Mar 2018 09:25:06 +0100 Message-ID: <20180321082506.GY14155@phenom.ffwll.local> References: <20180320191757.23869-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180320191757.23869-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMjAsIDIwMTggYXQgMDk6MTc6NTJQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEN1cnJlbnRseSB3ZSdyZSBsZWFraW5nIGZicyBvbiBsb2FkIGRldGVjdCBvbiBh Y2NvdW50IG9mIG5vdGhpbmcgc2V0dGluZwo+IHVwIHBsYW5lLT5vbGRfZmIgZm9yIHRoZSBkcm1f YXRvbWljX2NsZWFuX29sZF9mYigpIGNhbGwgaW4KPiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRf ZHVwbGljYXRlZF9zdGF0ZSgpLiBSZW1vdmluZyB0aGUKPiBkcm1fYXRvbWljX2NsZWFuX29sZF9m YigpIGNhbGwgc2VlbXMgbGlrZSB0aGUgcmlnaHQgY2FsbCB0byBtZSBoZXJlLgo+IFRoaXMgZG9l cyBtZWFuIHdlIGVuZCB1cCBsZWFraW5nIHNvbWV0aGluZyB2aWEKPiBkcm1fYXRvbWljX2hlbHBl cl9zaHV0ZG93bigpIHRob3VnaCwgYnV0IHdlJ2xsIGZpeCB0aGF0IHVwIGluIGEKPiBkaWZmZXJl bnQgd2F5Lgo+IAo+IFRoaXMgcmV2ZXJ0cyBjb21taXQgNDlkNzBhZWFlY2E4ZjYyYjcyYjc3MTJl Y2QxZTI5NjE5YTQ0NTg2Ni4KClNvIHRoZSByZWFzb24gSSB3ZW50IHRoaXMgd2F5IGFuZCBub3Qg d2hhdCB5b3UncmUgc3VnZ2VzdGluZyBpbiB0aGlzIHBhdGNoCnNlcmllcyBpcyB0aGF0IGk5MTUg aXMgdGhlIG9uZSBhbmQgb25seSBkcml2ZXIgbm9vZGxpbmcgYXJvdW5kIHdpdGggbG9hZApkZXRl Y3QgYW5kIGdwdSByZXNldCB0aGF0IG5lZWRzIHRoaXMuCgpJbW8gaXQnZCBiZSBiZXR0ZXIgdG8g Zml4IHVwIG91ciBsb2FkIGRldGVjdCBjb2RlIHRvIGFsc28gc2V0IHRoZSBvbGRfZmIKc3R1ZmYg dXAgY29ycmVjdGx5LCBhbmQgYWRkIGF0IGxlYXN0IGEgbG9uZy10ZXJtIHRhc2sgdG8gdG9kby5y c3QgdG8gZ2V0CnJpZCBvZiBhbGwgdGhpcy4gSW5mbGljdGluZyBhIG5ldyBwYXJhbWV0ZXIgb24g YWxsIHRoZSBvdGhlciBkcml2ZXMgKGxpa2UKeW91IGRvIGluIHBhdGNoIDIpIGlzIGltbyB0aGUg d3Jvbmcgd2F5IHJvdW5kIC0gd2UgaGF2ZSAzMSBvdGhlciBhdG9taWMKZHJpdmVycyB0aGFuIGk5 MTUua28uCi1EYW5pZWwKCj4gCj4gQ2M6IG1hcnRpbi5wZXJlc0BmcmVlLmZyCj4gQ2M6IGNocmlz QGNocmlzLXdpbHNvbi5jby51awo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEBnbWFpbC5jb20+ ICh2MSkKPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCAxOCAr Ky0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMTYg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj X2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCBj MzU2NTQ1OTFjMTIuLmM0OGYxODdkMDhkZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jCj4gQEAgLTI5MTQsNyArMjkxNCw2IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNh YmxlX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxh bmU7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJt X2NydGMgKmNydGM7Cj4gLQl1bnNpZ25lZCBwbGFuZV9tYXNrID0gMDsKPiAgCWludCByZXQsIGk7 Cj4gIAo+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gQEAgLTI5NTcs MTQgKzI5NTYsMTAgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4gIAkJCWdvdG8gZnJlZTsKPiAgCj4gIAkJZHJtX2F0b21pY19zZXRf ZmJfZm9yX3BsYW5lKHBsYW5lX3N0YXRlLCBOVUxMKTsKPiAtCQlwbGFuZV9tYXNrIHw9IEJJVChk cm1fcGxhbmVfaW5kZXgocGxhbmUpKTsKPiAtCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+ ICAJfQo+ICAKPiAgCXJldCA9IGRybV9hdG9taWNfY29tbWl0KHN0YXRlKTsKPiAgZnJlZToKPiAt CWlmIChwbGFuZV9tYXNrKQo+IC0JCWRybV9hdG9taWNfY2xlYW5fb2xkX2ZiKGRldiwgcGxhbmVf bWFzaywgcmV0KTsKPiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiAgCXJldHVybiBy ZXQ7Cj4gIH0KPiBAQCAtMzA5NSwxNiArMzA5MCwxMSBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJf Y29tbWl0X2R1cGxpY2F0ZWRfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKm5ld19jb25uX3N0YXRlOwo+ICAJc3RydWN0 IGRybV9jcnRjICpjcnRjOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0 ZTsKPiAtCXVuc2lnbmVkIHBsYW5lX21hc2sgPSAwOwo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IHN0YXRlLT5kZXY7Cj4gLQlpbnQgcmV0Owo+ICAKPiAgCXN0YXRlLT5hY3F1aXJlX2N0eCA9 IGN0eDsKPiAgCj4gLQlmb3JfZWFjaF9uZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBu ZXdfcGxhbmVfc3RhdGUsIGkpIHsKPiAtCQlwbGFuZV9tYXNrIHw9IEJJVChkcm1fcGxhbmVfaW5k ZXgocGxhbmUpKTsKPiArCWZvcl9lYWNoX25ld19wbGFuZV9pbl9zdGF0ZShzdGF0ZSwgcGxhbmUs IG5ld19wbGFuZV9zdGF0ZSwgaSkKPiAgCQlzdGF0ZS0+cGxhbmVzW2ldLm9sZF9zdGF0ZSA9IHBs YW5lLT5zdGF0ZTsKPiAtCX0KPiAgCj4gIAlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShzdGF0 ZSwgY3J0YywgbmV3X2NydGNfc3RhdGUsIGkpCj4gIAkJc3RhdGUtPmNydGNzW2ldLm9sZF9zdGF0 ZSA9IGNydGMtPnN0YXRlOwo+IEBAIC0zMTEyLDExICszMTAyLDcgQEAgaW50IGRybV9hdG9taWNf aGVscGVyX2NvbW1pdF9kdXBsaWNhdGVkX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZSwKPiAgCWZvcl9lYWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm5lY3Rv ciwgbmV3X2Nvbm5fc3RhdGUsIGkpCj4gIAkJc3RhdGUtPmNvbm5lY3RvcnNbaV0ub2xkX3N0YXRl ID0gY29ubmVjdG9yLT5zdGF0ZTsKPiAgCj4gLQlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0 ZSk7Cj4gLQlpZiAocGxhbmVfbWFzaykKPiAtCQlkcm1fYXRvbWljX2NsZWFuX29sZF9mYihkZXYs IHBsYW5lX21hc2ssIHJldCk7Cj4gLQo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiBkcm1fYXRv bWljX2NvbW1pdChzdGF0ZSk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBl cl9jb21taXRfZHVwbGljYXRlZF9zdGF0ZSk7Cj4gIAo+IC0tIAo+IDIuMTYuMQo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=