From: =?UTF-8?q?Piotr=20Pi=C3=B3rkowski?= Subject: [PATCH v2] drm/i915/guc: Fix null pointer dereference when GuC FW is not available Date: Thu, 22 Mar 2018 18:05:51 +0100 Message-ID: <20180322170551.26342-1-piotr.piorkowski@intel.com> References: <20180322161855.23333-1-piotr.piorkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F184F6E01D for ; Thu, 22 Mar 2018 17:05:59 +0000 (UTC) In-Reply-To: <20180322161855.23333-1-piotr.piorkowski@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SWYgR3VDIGZpcm13YXJlIGlzIG5vdCBhdmFpbGFibGUgb24gdGhlIHN5c3RlbSBhbmQgd2UgbG9h ZCBpOTE1IHdpdGggZW5hYmxlCkd1QywgdGhlbiB3ZSBoaXQgdGhpcyBudWxsIHBvaW50ZXIgZGVy ZWZlcmVuY2UgaXNzdWU6CgpbICAgNzEuMDk4ODczXSBCVUc6IHVuYWJsZSB0byBoYW5kbGUga2Vy bmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAwMDAwMDAwMDAwMDAwMDA4ClsgICA3MS4w OTg5MzhdIElQOiBpbnRlbF91Y19md191cGxvYWQrMHgxZi8weDM2MCBbaTkxNV0KWyAgIDcxLjA5 ODk0N10gUEdEIDAgUDREIDAKWyAgIDcxLjA5ODk1Nl0gT29wczogMDAwMCBbIzFdIFBSRUVNUFQg U01QIFBUSQpbICAgNzEuMDk4OTY1XSBNb2R1bGVzIGxpbmtlZCBpbjogaTkxNShPKykgbmV0Y29u c29sZSB4ODZfcGtnX3RlbXBfdGhlcm1hbCBpbnRlbF9wb3dlcmNsYW1wIGNvcmV0ZW1wIGNyY3Qx MGRpZl9wY2xtdWwgY3JjMzJfcGNsbXVsIGdoYXNoX2NsbXVsbmlfaW50ZWwgbWVpX21lIGkyY19p ODAxIHByaW1lX251bWJlcnMgbWVpIFtsYXN0IHVubG9hZGVkOiBpOTE1XQpbICAgNzEuMDk5MDA1 XSBDUFU6IDIgUElEOiAxMTY3IENvbW06IGluc21vZCBUYWludGVkOiBHICAgICBVICBXICBPICAg ICA0LjE2LjAtcmMxKyAjMzM3ClsgICA3MS4wOTkwMThdIEhhcmR3YXJlIG5hbWU6IC9OVUM2aTVT WUIsIEJJT1MgU1lTS0xpMzUuODZBLjAwNjUuMjAxOC4wMTAzLjEwMDAgMDEvMDMvMjAxOApbICAg NzEuMDk5MDc3XSBSSVA6IDAwMTA6aW50ZWxfdWNfZndfdXBsb2FkKzB4MWYvMHgzNjAgW2k5MTVd ClsgICA3MS4wOTkwODddIFJTUDogMDAxODpmZmZmYzkwMDAwNDE3YWEwIEVGTEFHUzogMDAwMTAy ODIKWyAgIDcxLjA5OTA5N10gUkFYOiAwMDAwMDAwMDAwMDAwMDAwIFJCWDogZmZmZjg4MDg0Y2Fk MTJmOCBSQ1g6IGZmZmZmZmZmYTAzZTkzNTcKWyAgIDcxLjA5OTEwOF0gUkRYOiAwMDAwMDAwMDAw MDAwMDAyIFJTSTogZmZmZmZmZmZhMDM0ZGJhMCBSREk6IGZmZmY4ODA4NGNhZDEyZjgKWyAgIDcx LjA5OTExOF0gUkJQOiAwMDAwMDAwMDAwMDAwMDAyIFIwODogZmZmZjg4MDg1MzQ0Y2E5MCBSMDk6 IDAwMDAwMDAwMDAwMDAwMDEKWyAgIDcxLjA5OTEyOF0gUjEwOiAwMDAwMDAwMDAwMDAwMDAwIFIx MTogMDAwMDAwMDAwMDAwMDAwMCBSMTI6IGZmZmY4ODA4NGNhZDAwMDAKWyAgIDcxLjA5OTEzOV0g UjEzOiBmZmZmZmZmZmEwMzRkYmEwIFIxNDogMDAwMDAwMDBmZmZmZmZmNSBSMTU6IGZmZmY4ODA4 NGNhZDEyYjAKWyAgIDcxLjA5OTE1MV0gRlM6ICAwMDAwN2Y3ZjI0YWUyNzQwKDAwMDApIEdTOmZm ZmY4ODA4NWUyMDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMApbICAgNzEuMDk5MTYy XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMzClsgICA3 MS4wOTkxNzFdIENSMjogMDAwMDAwMDAwMDAwMDAwOCBDUjM6IDAwMDAwMDA4NTVmNDgwMDEgQ1I0 OiAwMDAwMDAwMDAwMzYwNmUwClsgICA3MS4wOTkxODJdIENhbGwgVHJhY2U6ClsgICA3MS4wOTky NDZdICBpbnRlbF91Y19pbml0X2h3KzB4YzgvMHg1MjAgW2k5MTVdClsgICA3MS4wOTkzMDNdICBp OTE1X2dlbV9pbml0X2h3KzB4MTFmLzB4MmQwIFtpOTE1XQpbICAgNzEuMDk5MzY0XSAgaTkxNV9n ZW1faW5pdCsweDJiOS8weDY0MCBbaTkxNV0KWyAgIDcxLjA5OTQxM10gIGk5MTVfZHJpdmVyX2xv YWQrMHhiNzQvMHgxMTEwIFtpOTE1XQpbICAgNzEuMDk5NDYyXSAgaTkxNV9wY2lfcHJvYmUrMHgy ZS8weDkwIFtpOTE1XQpbICAgNzEuMDk5NDc2XSAgcGNpX2RldmljZV9wcm9iZSsweGExLzB4MTMw ClsgICA3MS4wOTk0ODhdICBkcml2ZXJfcHJvYmVfZGV2aWNlKzB4MzAyLzB4NDcwClsgICA3MS4w OTk1MDJdICBfX2RyaXZlcl9hdHRhY2grMHhiOS8weGUwClsgICA3MS4wOTk1MTNdICA/IGRyaXZl cl9wcm9iZV9kZXZpY2UrMHg0NzAvMHg0NzAKWyAgIDcxLjA5OTUyNV0gID8gZHJpdmVyX3Byb2Jl X2RldmljZSsweDQ3MC8weDQ3MApbICAgNzEuMDk5NTM4XSAgYnVzX2Zvcl9lYWNoX2RldisweDY0 LzB4OTAKWyAgIDcxLjA5OTU1MF0gIGJ1c19hZGRfZHJpdmVyKzB4MTY0LzB4MjYwClsgICA3MS4w OTk1NjFdICA/IDB4ZmZmZmZmZmZhMDRkNjAwMApbICAgNzEuMDk5NTcyXSAgZHJpdmVyX3JlZ2lz dGVyKzB4NTcvMHhjMApbICAgNzEuMDk5NTgyXSAgPyAweGZmZmZmZmZmYTA0ZDYwMDAKWyAgIDcx LjA5OTU5M10gIGRvX29uZV9pbml0Y2FsbCsweDNiLzB4MTYwClsgICA3MS4wOTk2MDZdICA/IGtt ZW1fY2FjaGVfYWxsb2NfdHJhY2UrMHgxYzMvMHgyYTAKWyAgIDcxLjA5OTYyMV0gIGRvX2luaXRf bW9kdWxlKzB4NWIvMHgxZjkKWyAgIDcxLjA5OTYzNV0gIGxvYWRfbW9kdWxlKzB4MjQ2Ny8weDJh NzAKWyAgIDcxLjA5OTY1NF0gID8gU3lTX2Zpbml0X21vZHVsZSsweGJkLzB4ZTAKWyAgIDcxLjA5 OTY2OF0gIFN5U19maW5pdF9tb2R1bGUrMHhiZC8weGUwClsgICA3MS4wOTk2ODJdICBkb19zeXNj YWxsXzY0KzB4NzMvMHgxYzAKWyAgIDcxLjA5OTY5NF0gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJf aHdmcmFtZSsweDI2LzB4OWIKWyAgIDcxLjA5OTcwNl0gUklQOiAwMDMzOjB4N2Y3ZjIzZmI0MGQ5 ClsgICA3MS4wOTk3MTddIFJTUDogMDAyYjowMDAwN2ZmZGE3ZDY3ZWQ4IEVGTEFHUzogMDAwMDAy NDYgT1JJR19SQVg6IDAwMDAwMDAwMDAwMDAxMzkKWyAgIDcxLjA5OTczNF0gUkFYOiBmZmZmZmZm ZmZmZmZmZmRhIFJCWDogMDAwMDU1Zjk2ZTJhODg3MCBSQ1g6IDAwMDA3ZjdmMjNmYjQwZDkKWyAg IDcxLjA5OTc0OF0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogMDAwMDU1Zjk2ZTJhODI2MCBS REk6IDAwMDAwMDAwMDAwMDAwMDMKWyAgIDcxLjA5OTc2M10gUkJQOiAwMDAwNTVmOTZlMmE4MjYw IFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6IDAwMDA3ZmZkYTdkNjgwODgKWyAgIDcxLjA5OTc3 N10gUjEwOiAwMDAwMDAwMDAwMDAwMDAzIFIxMTogMDAwMDAwMDAwMDAwMDI0NiBSMTI6IDAwMDAw MDAwMDAwMDAwMDAKWyAgIDcxLjA5OTc5MV0gUjEzOiAwMDAwNTVmOTZlMmE4ODMwIFIxNDogMDAw MDAwMDAwMDAwMDAwMCBSMTU6IDAwMDA1NWY5NmUyYTgyNjAKWyAgIDcxLjA5OTgxMF0gQ29kZTog MDAgMDAgNjYgMmUgMGYgMWYgODQgMDAgMDAgMDAgMDAgMDAgMGYgMWYgNDQgMDAgMDAgNDEgNTUg NDEgNTQgNDkgODkgZjUgNTUgNTMgNDggYzcgYzEgNTcgOTMgM2UgYTAgNDggOGIgNDcgMTAgNDgg ODkgZmIgNGMgOGIgMDcgPDQ4PiA4YiA2OCAwOCA4YiA0NyAyOCA4NSBjMCA3NCAxNSA4MyBmOCAw MSA0OCBjNyBjMSA1YiA5MyAzZSBhMApbICAgNzEuMTAwMDA0XSBSSVA6IGludGVsX3VjX2Z3X3Vw bG9hZCsweDFmLzB4MzYwIFtpOTE1XSBSU1A6IGZmZmZjOTAwMDA0MTdhYTAKWyAgIDcxLjEwMDAy MF0gQ1IyOiAwMDAwMDAwMDAwMDAwMDA4ClsgICA3MS4xMDAwMzFdIC0tLVsgZW5kIHRyYWNlIGQ4 YWM5M2MzMGNlZmY1YjIgXS0tCgpGaXhlczogNmIwNDc4ZmI3MjJhICgiZHJtL2k5MTU6IEltcGxl bWVudCBkeW5hbWljIEd1QyBXT1BDTSBvZmZzZXQgYW5kIHNpemUgY2FsY3VsYXRpb24iKQoKdjI6 IGRvbid0IGFzc3VtZSBpdCBpcyBhbHdheXMgR3VDIEZXIChNaWNoYWwpCgpTaWduZWQtb2ZmLWJ5 OiBQaW90ciBQacOzcmtvd3NraSA8cGlvdHIucGlvcmtvd3NraUBpbnRlbC5jb20+ClJlcG9ydGVk LWJ5OiBSYWRvc2xhdyBTendpY2h0ZW5iZXJnIDxyYWRvc2xhdy5zendpY2h0ZW5iZXJnQGludGVs LmNvbT4KQ2M6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4K Q2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgpDYzogU2Fn YXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KQ2M6IEpvb25hcyBMYWh0 aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KQ2M6IEphY2tpZSBMaSA8eWFv ZG9uZy5saUBpbnRlbC5jb20+CkNjOiBSYWRvc2xhdyBTendpY2h0ZW5iZXJnIDxyYWRvc2xhdy5z endpY2h0ZW5iZXJnQGludGVsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 Y19mdy5jIHwgMyArLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYwppbmRleCAzMGM3MzI0M2Y1NGQuLmMw NjYzODU3Y2Q0MyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jCkBAIC0xOTksNyArMTk5 LDYgQEAgaW50IGludGVsX3VjX2Z3X3VwbG9hZChzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3LAog CQkgICAgICAgaW50ICgqeGZlcikoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywKIAkJCQkgICBz dHJ1Y3QgaTkxNV92bWEgKnZtYSkpCiB7Ci0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUg PSB0b19pOTE1KHVjX2Z3LT5vYmotPmJhc2UuZGV2KTsKIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsK IAlpbnQgZXJyOwogCkBAIC0yMjQsNyArMjIzLDcgQEAgaW50IGludGVsX3VjX2Z3X3VwbG9hZChz dHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3LAogCiAJdm1hID0gaTkxNV9nZW1fb2JqZWN0X2dndHRf cGluKHVjX2Z3LT5vYmosIE5VTEwsIDAsIDAsCiAJCQkJICAgICAgIFBJTl9PRkZTRVRfQklBUyB8 Ci0JCQkJICAgICAgIGk5MTUtPmd1Yy5nZ3R0X3Bpbl9iaWFzKTsKKwkJCQkgICAgICAgdG9faTkx NSh1Y19mdy0+b2JqLT5iYXNlLmRldiktPmd1Yy5nZ3R0X3Bpbl9iaWFzKTsKIAlpZiAoSVNfRVJS KHZtYSkpIHsKIAkJZXJyID0gUFRSX0VSUih2bWEpOwogCQlEUk1fREVCVUdfRFJJVkVSKCIlcyBm dyBnZ3R0LXBpbiBlcnI9JWRcbiIsCi0tIAoyLjE0LjMKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=