From: Sean Paul Subject: Re: [PATCH v3 2/4] drm/i915: Read Vprime thrice incase of mismatch Date: Mon, 2 Apr 2018 09:50:17 -0400 Message-ID: <20180402135017.GL41885@art_vandelay> References: <1522663834-24482-1-git-send-email-ramalingam.c@intel.com> <1522663834-24482-3-git-send-email-ramalingam.c@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1522663834-24482-3-git-send-email-ramalingam.c@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ramalingam C Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBcHIgMDIsIDIwMTggYXQgMDM6NDA6MzJQTSArMDUzMCwgUmFtYWxpbmdhbSBDIHdy b3RlOgo+IEluIGNhc2Ugb2YgViBwcmltZSBtaXNtYXRjaCwgRFAgSERDUCBzcGVjIG1hbmRhdGVz IHRoZSByZS1yZWFkIG9mCj4gVnByaW1lIGF0bGVhc3QgdHdpY2UuCj4gCj4gVGhpcyBwYXRjaCBu ZWVkZWQgZm9yIERQIEhEQ1AxLjQgQ1RTIFRlc3Q6IDFCLTA1Lgo+IAo+IHYyOgo+ICAgTW92ZWQg dGhlIFYnIHZhbGlkYXRpb24gaW50byBhIGZ1bmN0aW9uIGZvciByZXRyeS4gW1NlYW4gUGF1bF0K PiB2MzoKPiAgIFJlbW92ZWQgSW5saW5lIGtleXdvcmQgYW5kIERSTV9ERUJVR19LTVMgYXJlIHVz ZWQgW1NlYW4gUGF1bF0KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYW1hbGluZ2FtIEMgPHJhbWFsaW5n YW0uY0BpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1 bS5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMgfCAxMTIg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDcwIGluc2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9oZGNwLmMKPiBpbmRleCA4MzhjOGNkMGY1NDMuLmUwYmMwM2VlZTk0MSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9oZGNwLmMKPiBAQCAtMTQyLDUzICsxNDIsMTcgQEAgYm9vbCBpbnRlbF9o ZGNwX2lzX2tzdl92YWxpZCh1OCAqa3N2KQo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiAgCj4gLS8q IEltcGxlbWVudHMgUGFydCAyIG9mIHRoZSBIRENQIGF1dGhvcml6YXRpb24gcHJvY2VkdXJlICov Cj4gIHN0YXRpYwo+IC1pbnQgaW50ZWxfaGRjcF9hdXRoX2Rvd25zdHJlYW0oc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gLQkJCSAgICAgICBjb25zdCBzdHJ1Y3Qg aW50ZWxfaGRjcF9zaGltICpzaGltKQo+ICtpbnQgaW50ZWxfaGRjcF92YWxpZGF0ZV92X3ByaW1l KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICsJCQkJY29uc3Qg c3RydWN0IGludGVsX2hkY3Bfc2hpbSAqc2hpbSwKPiArCQkJCXU4ICprc3ZfZmlmbywgdTggbnVt X2Rvd25zdHJlYW0sIHU4ICpic3RhdHVzKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXY7Cj4gIAl1MzIgdnByaW1lLCBzaGFfdGV4dCwgc2hhX2xlZnRvdmVycywgcmVw X2N0bDsKPiAtCXU4IGJzdGF0dXNbMl0sIG51bV9kb3duc3RyZWFtLCAqa3N2X2ZpZm87Cj4gIAlp bnQgcmV0LCBpLCBqLCBzaGFfaWR4Owo+ICAKPiAgCWRldl9wcml2ID0gaW50ZWxfZGlnX3BvcnQt PmJhc2UuYmFzZS5kZXYtPmRldl9wcml2YXRlOwo+ICAKPiAtCXJldCA9IGludGVsX2hkY3BfcG9s bF9rc3ZfZmlmbyhpbnRlbF9kaWdfcG9ydCwgc2hpbSk7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJRFJN X0VSUk9SKCJLU1YgbGlzdCBmYWlsZWQgdG8gYmVjb21lIHJlYWR5ICglZClcbiIsIHJldCk7Cj4g LQkJcmV0dXJuIHJldDsKPiAtCX0KPiAtCj4gLQlyZXQgPSBzaGltLT5yZWFkX2JzdGF0dXMoaW50 ZWxfZGlnX3BvcnQsIGJzdGF0dXMpOwo+IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0K PiAtCWlmIChEUk1fSERDUF9NQVhfREVWSUNFX0VYQ0VFREVEKGJzdGF0dXNbMF0pIHx8Cj4gLQkg ICAgRFJNX0hEQ1BfTUFYX0NBU0NBREVfRVhDRUVERUQoYnN0YXR1c1sxXSkpIHsKPiAtCQlEUk1f RVJST1IoIk1heCBUb3BvbG9neSBMaW1pdCBFeGNlZWRlZFxuIik7Cj4gLQkJcmV0dXJuIC1FUEVS TTsKPiAtCX0KPiAtCj4gLQkvKgo+IC0JICogV2hlbiByZXBlYXRlciByZXBvcnRzIDAgZGV2aWNl IGNvdW50LCBIRENQMS40IHNwZWMgYWxsb3dzIGRpc2FibGluZwo+IC0JICogdGhlIEhEQ1AgZW5j cnlwdGlvbi4gVGhhdCBpbXBsaWVzIHRoYXQgcmVwZWF0ZXIgY2FuJ3QgaGF2ZSBpdHMgb3duCj4g LQkgKiBkaXNwbGF5LiBBcyB0aGVyZSBpcyBubyBjb25zdW1wdGlvbiBvZiBlbmNyeXB0ZWQgY29u dGVudCBpbiB0aGUKPiAtCSAqIHJlcGVhdGVyIHdpdGggMCBkb3duc3RyZWFtIGRldmljZXMsIHdl IGFyZSBmYWlsaW5nIHRoZQo+IC0JICogYXV0aGVudGljYXRpb24uCj4gLQkgKi8KPiAtCW51bV9k b3duc3RyZWFtID0gRFJNX0hEQ1BfTlVNX0RPV05TVFJFQU0oYnN0YXR1c1swXSk7Cj4gLQlpZiAo bnVtX2Rvd25zdHJlYW0gPT0gMCkKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiAtCj4gLQlrc3ZfZmlm byA9IGt6YWxsb2MobnVtX2Rvd25zdHJlYW0gKiBEUk1fSERDUF9LU1ZfTEVOLCBHRlBfS0VSTkVM KTsKPiAtCWlmICgha3N2X2ZpZm8pCj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4gLQo+IC0JcmV0ID0g c2hpbS0+cmVhZF9rc3ZfZmlmbyhpbnRlbF9kaWdfcG9ydCwgbnVtX2Rvd25zdHJlYW0sIGtzdl9m aWZvKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4gIAkvKiBQcm9jZXNzIFYn IHZhbHVlcyBmcm9tIHRoZSByZWNlaXZlciAqLwo+ICAJZm9yIChpID0gMDsgaSA8IERSTV9IRENQ X1ZfUFJJTUVfTlVNX1BBUlRTOyBpKyspIHsKPiAgCQlyZXQgPSBzaGltLT5yZWFkX3ZfcHJpbWVf cGFydChpbnRlbF9kaWdfcG9ydCwgaSwgJnZwcmltZSk7Cj4gQEAgLTM1Myw3ICszMTcsOCBAQCBp bnQgaW50ZWxfaGRjcF9hdXRoX2Rvd25zdHJlYW0oc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAq aW50ZWxfZGlnX3BvcnQsCj4gIAkJCXJldHVybiByZXQ7Cj4gIAkJc2hhX2lkeCArPSBzaXplb2Yo c2hhX3RleHQpOwo+ICAJfSBlbHNlIHsKPiAtCQlEUk1fRVJST1IoIkludmFsaWQgbnVtYmVyIG9m IGxlZnRvdmVycyAlZFxuIiwgc2hhX2xlZnRvdmVycyk7Cj4gKwkJRFJNX0RFQlVHX0tNUygiSW52 YWxpZCBudW1iZXIgb2YgbGVmdG92ZXJzICVkXG4iLAo+ICsJCQkgICAgICBzaGFfbGVmdG92ZXJz KTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gQEAgLTM4MSwxNCArMzQ2LDc3IEBA IGludCBpbnRlbF9oZGNwX2F1dGhfZG93bnN0cmVhbShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0 ICppbnRlbF9kaWdfcG9ydCwKPiAgCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJp diwgSERDUF9SRVBfQ1RMLAo+ICAJCQkJICAgIEhEQ1BfU0hBMV9DT01QTEVURSwKPiAgCQkJCSAg ICBIRENQX1NIQTFfQ09NUExFVEUsIDEpKSB7Cj4gLQkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2Fp dGluZyBmb3IgU0hBMSBjb21wbGV0ZVxuIik7Cj4gKwkJRFJNX0RFQlVHX0tNUygiVGltZWQgb3V0 IHdhaXRpbmcgZm9yIFNIQTEgY29tcGxldGVcbiIpOwo+ICAJCXJldHVybiAtRVRJTUVET1VUOwo+ ICAJfQo+ICAJaWYgKCEoSTkxNV9SRUFEKEhEQ1BfUkVQX0NUTCkgJiBIRENQX1NIQTFfVl9NQVRD SCkpIHsKPiAtCQlEUk1fRVJST1IoIlNIQS0xIG1pc21hdGNoLCBIRENQIGZhaWxlZFxuIik7Cj4g KwkJRFJNX0RFQlVHX0tNUygiU0hBLTEgbWlzbWF0Y2gsIEhEQ1AgZmFpbGVkXG4iKTsKPiAgCQly ZXR1cm4gLUVOWElPOwo+ICAJfQo+ICAKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICsvKiBJbXBs ZW1lbnRzIFBhcnQgMiBvZiB0aGUgSERDUCBhdXRob3JpemF0aW9uIHByb2NlZHVyZSAqLwo+ICtz dGF0aWMKPiAraW50IGludGVsX2hkY3BfYXV0aF9kb3duc3RyZWFtKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVs X2hkY3Bfc2hpbSAqc2hpbSkKPiArewo+ICsJdTggYnN0YXR1c1syXSwgbnVtX2Rvd25zdHJlYW0s ICprc3ZfZmlmbzsKPiArCWludCByZXQsIGksIHRyaWVzID0gMzsKPiArCj4gKwlyZXQgPSBpbnRl bF9oZGNwX3BvbGxfa3N2X2ZpZm8oaW50ZWxfZGlnX3BvcnQsIHNoaW0pOwo+ICsJaWYgKHJldCkg ewo+ICsJCURSTV9FUlJPUigiS1NWIGxpc3QgZmFpbGVkIHRvIGJlY29tZSByZWFkeSAoJWQpXG4i LCByZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJcmV0ID0gc2hpbS0+cmVhZF9i c3RhdHVzKGludGVsX2RpZ19wb3J0LCBic3RhdHVzKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJu IHJldDsKPiArCj4gKwlpZiAoRFJNX0hEQ1BfTUFYX0RFVklDRV9FWENFRURFRChic3RhdHVzWzBd KSB8fAo+ICsJICAgIERSTV9IRENQX01BWF9DQVNDQURFX0VYQ0VFREVEKGJzdGF0dXNbMV0pKSB7 Cj4gKwkJRFJNX0VSUk9SKCJNYXggVG9wb2xvZ3kgTGltaXQgRXhjZWVkZWRcbiIpOwo+ICsJCXJl dHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJLyoKPiArCSAqIFdoZW4gcmVwZWF0ZXIgcmVwb3J0 cyAwIGRldmljZSBjb3VudCwgSERDUDEuNCBzcGVjIGFsbG93cyBkaXNhYmxpbmcKPiArCSAqIHRo ZSBIRENQIGVuY3J5cHRpb24uIFRoYXQgaW1wbGllcyB0aGF0IHJlcGVhdGVyIGNhbid0IGhhdmUg aXRzIG93bgo+ICsJICogZGlzcGxheS4gQXMgdGhlcmUgaXMgbm8gY29uc3VtcHRpb24gb2YgZW5j cnlwdGVkIGNvbnRlbnQgaW4gdGhlCj4gKwkgKiByZXBlYXRlciB3aXRoIDAgZG93bnN0cmVhbSBk ZXZpY2VzLCB3ZSBhcmUgZmFpbGluZyB0aGUKPiArCSAqIGF1dGhlbnRpY2F0aW9uLgo+ICsJICov Cj4gKwludW1fZG93bnN0cmVhbSA9IERSTV9IRENQX05VTV9ET1dOU1RSRUFNKGJzdGF0dXNbMF0p Owo+ICsJaWYgKG51bV9kb3duc3RyZWFtID09IDApCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ ICsJa3N2X2ZpZm8gPSBremFsbG9jKG51bV9kb3duc3RyZWFtICogRFJNX0hEQ1BfS1NWX0xFTiwg R0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWtzdl9maWZvKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsK PiArCXJldCA9IHNoaW0tPnJlYWRfa3N2X2ZpZm8oaW50ZWxfZGlnX3BvcnQsIG51bV9kb3duc3Ry ZWFtLCBrc3ZfZmlmbyk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJLyoK PiArCSAqIFdoZW4gViBwcmltZSBtaXNtYXRjaGVzLCBEUCBTcGVjIG1hbmRhdGVzIHJlLXJlYWQg b2YKPiArCSAqIFYgcHJpbWUgYXRsZWFzdCB0d2ljZS4KPiArCSAqLwo+ICsJZm9yIChpID0gMDsg aSA8IHRyaWVzOyBpKyspIHsKPiArCQlyZXQgPSBpbnRlbF9oZGNwX3ZhbGlkYXRlX3ZfcHJpbWUo aW50ZWxfZGlnX3BvcnQsIHNoaW0sCj4gKwkJCQkJCSAga3N2X2ZpZm8sIG51bV9kb3duc3RyZWFt LAo+ICsJCQkJCQkgIGJzdGF0dXMpOwo+ICsJCWlmICghcmV0KQo+ICsJCQlicmVhazsKPiArCX0K PiArCj4gKwlpZiAoaSA9PSB0cmllcykgewo+ICsJCURSTV9FUlJPUigiViBQcmltZSB2YWxpZGF0 aW9uIGZhaWxlZC4oJWQpXG4iLCByZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAJ RFJNX0RFQlVHX0tNUygiSERDUCBpcyBlbmFibGVkICglZCBkb3duc3RyZWFtIGRldmljZXMpXG4i LAo+ICAJCSAgICAgIG51bV9kb3duc3RyZWFtKTsKPiAgCXJldHVybiAwOwo+IC0tIAo+IDIuNy40 Cj4gCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0g T1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==