From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers Date: Thu, 5 Apr 2018 09:14:34 +0200 Message-ID: <20180405071434.GN3881@phenom.ffwll.local> References: <20180330122715.18209-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180330122715.18209-1-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede Cc: intel-gfx , Hans de Goede , dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMzAsIDIwMTggYXQgMDI6Mjc6MTVQTSArMDIwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBCZWZvcmUgdGhpcyBjb21taXQgdGhlIFdhU2tpcFN0b2xlbk1lbW9yeUZpcnN0UGFn ZSB3b3JrYXJvdW5kIGNvZGUgd2FzCj4gc2tpcHBpbmcgdGhlIGZpcnN0IDRrIGJ5IHBhc3Npbmcg NDA5NiBhcyBzdGFydCBvZiB0aGUgYWRkcmVzcyByYW5nZSBwYXNzZWQKPiB0byBkcm1fbW1faW5p dCgpLiBUaGlzIG1lYW5zIHRoYXQgY2FsbGluZyBkcm1fbW1fcmVzZXJ2ZV9ub2RlKCkgdG8gdHJ5 IGFuZAo+IHJlc2VydmUgdGhlIGZpcm13YXJlIGZyYW1lYnVmZmVyIHNvIHRoYXQgd2UgY2FuIGlu aGVyaXQgaXQgd291bGQgYWx3YXlzCj4gZmFpbCwgYXMgdGhlIGZpcm13YXJlIGZyYW1lYnVmZmVy IHN0YXJ0cyBhdCBhZGRyZXNzIDAuCj4gCj4gQ29tbWl0IGQ0MzUzNzYxMDQ3MCAoImRybS9pOTE1 OiBza2lwIHRoZSBmaXJzdCA0ayBvZiBzdG9sZW4gbWVtb3J5IG9uCj4gZXZlcnl0aGluZyA+PSBn ZW44Iikgc2F5cyBpbiBpdHMgY29tbWl0IG1lc3NhZ2U6ICJUaGlzIGlzIGNvbmZpcm1lZCB0byBm aXgKPiBTa3lsYWtlIHNjcmVlbiBmbGlja2VyaW5nIGlzc3VlcyAocHJvYmFibHkgY2F1c2VkIGJ5 IHRoZSBmYWN0IHRoYXQgd2UKPiBpbml0aWFsaXplZCBhIHJpbmcgaW4gdGhlIGZpcnN0IHBhZ2Ug b2Ygc3RvbGVuLCBidXQgSSBkaWRuJ3QgMTAwJSBjb25maXJtCj4gdGhpcyB0aGVvcnkpLiIKPiAK PiBXaGljaCBzdWdnZXN0cyB0aGF0IGl0IGlzIHNhZmUgdG8gdXNlIHRoZSBmaXJzdCBwYWdlIGZv ciBhIGxpbmVhcgo+IGZyYW1lYnVmZmVyIGFzIHRoZSBmaXJtd2FyZSBpcyBkb2luZy4KPiAKPiBU aGlzIGNvbW1pdCBhbHdheXMgcGFzc2VzIDAgYXMgc3RhcnQgdG8gZHJtX21tX2luaXQoKSBhbmQg d29ya3MgYXJvdW5kCj4gV2FTa2lwU3RvbGVuTWVtb3J5Rmlyc3RQYWdlIGluIGk5MTVfZ2VtX3N0 b2xlbl9pbnNlcnRfbm9kZV9pbl9yYW5nZSgpCj4gYnkgaW5zdXJpbmcgdGhlIHN0YXJ0IGFkZHJl c3MgcGFzc2VkIGJ5IHRvIGRybV9tbV9pbnNlcnRfbm9kZV9pbl9yYW5nZSgpCj4gaXMgYWx3YXlz IDRrIG9yIG1vcmUuIEFsbCBlbnRyeSBwb2ludHMgdG8gaTkxNV9nZW1fc3RvbGVuLmMgZ28gdGhy b3VnaAo+IGk5MTVfZ2VtX3N0b2xlbl9pbnNlcnRfbm9kZV9pbl9yYW5nZSgpLCBzbyB0aGF0IGFu eSBuZXdseSBhbGxvY2F0ZWQKPiBvYmplY3RzIHN1Y2ggYXMgcmluZy1idWZmZXJzIHdpbGwgbm90 IGJlIGFsbG9jYXRlZCBpbiB0aGUgZmlyc3QgNGsuCj4gCj4gVGhlIG9uZSBleGNlcHRpb24gaXMg aTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW5fZm9yX3ByZWFsbG9jYXRlZCgpCj4gd2hpY2gg ZGlyZWN0bHkgY2FsbHMgZHJtX21tX3Jlc2VydmVfbm9kZSgpIHdoaWNoIG5vdyB3aWxsIGJlIGFi bGUgdG8KPiB1c2UgdGhlIGZpcnN0IDRrLgo+IAo+IFRoaXMgZml4ZXMgdGhlIGk5MTUgZHJpdmVy IG5vIGxvbmdlciBiZWluZyBhYmxlIHRvIGluaGVyaXQgdGhlIGZpcm13YXJlCj4gZnJhbWVidWZm ZXIgb24gZ2VuOCssIHdoaWNoIGZpeGVzIHRoZSB2aWRlbyBvdXRwdXQgY2hhbmdpbmcgZnJvbSB0 aGUKPiB2ZW5kb3IgbG9nbyB0byBhIGJsYWNrIHNjcmVlbiBhcyBzb29uIGFzIHRoZSBpOTE1IGRy aXZlciBpcyBsb2FkZWQKPiAob24gc3lzdGVtcyB3aXRob3V0IGZiY29uKS4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgoKSSB0aGluayB0aGlz IGlzIHdvcnRoIGEgc2hvdC4gVGhlIG9ubHkgZXhwbGFuYXRpb24gSSBjYW4gdGhpbmsgb2Ygd2h5 IHRoZQpHT1AgY291bGQgZ2V0IGF3YXkgd2l0aCB0aGlzIGFuZCBzdGlsbCBmb2xsb3cgdGhlIHcv YSBpcyBpZiBpdCBkb2Vzbid0CmhhdmUgYSAxOjEgbWFwcGluZyBiZXR3ZWVuIEdHVFQgYW5kIHN0 b2xlbi4gQXRtIHdlIGhhcmRjb2RlIHRoYXQKYXNzdW1wdGlvbiBpbiBpbnRlbF9hbGxvY19pbml0 aWFsX3BsYW5lX29iaiBieSBwYXNzaW5nIHRoZSBiYXNlX2FsaWduZWQgYXMKYm90aCB0aGUgc3Rv bGVuX29mZnNldCBhbmQgdGhlIGd0dF9vZmZzZXQgKGJ1dCBpdCdzIG9ubHkgdGhlIGd0dF9vZmZz ZXQKcmVhbGx5KS4gQW5kIHNpbmNlIHdlJ3JlIG5vdCByZS13cml0aW5nIHRoZSBwdGVzIGl0J3Mg bm90IG5vdGljZWFibGUuCgpJIHRoaW5rIHRvIGRlY2lkZSB3aGV0aGVyIHRoaXMgaXMgdGhlIHJp Z2h0IGFwcHJvYWNoIHdlIHNob3VsZApkb3VibGUtY2hlY2sgd2hldGhlciB0aGF0IDE6MSBhc3N1 bXB0aW9uIHJlYWxseSBob2xkcyB0cnVlOiBFaXRoZXIgcmVhZApiYWNrIHRoZSBnZ3R0IHB0ZXMg YW5kIGNoZWNrIHRoZWlyIGFkZHJlc3NlcyAoYnV0IGlpcmMgb24gc29tZSBwbGF0Zm9ybXMKdGhl aXIgd3JpdGUtb25seSwgcmVhZGJhY2sgZG9lc24ndCB3b3JrKSwgb3Igd2UgYWxzbyByZXdyaXRl IHRoZSBwdGVzCmFnYWluIGZvciBwcmVhbGxvY2F0ZWQgc3R1ZmYsIGxpa2Ugd2hlbiBiaW5kaW5n IGEgbm9ybWFsIG9iamVjdCBpbnRvIHRoZQpndHQuIElmIGVpdGhlciBvZiB0aGVzZSBhcHByb2Fj aGVzIGNvbmZpcm1zIHRoYXQgdGhvc2UgYWZmZWN0ZWQgZ2VuOCsKbWFjaGluZXMgc3RpbGwgdXNl IHRoZSAxOjEgbWFwcGluZywgdGhlbiBJJ20gaGFwcHkgdG8gcHV0IG15IHItYiBvbiB0aGlzCnBh dGNoLiBJZiBub3QsIHdlbGwgdGhlbiB3ZSBhdCBsZWFzdCBrbm93IHdoYXQgdG8gZml4OiBXZSBu ZWVkIHRvIHJlYWQgb3V0CnRoZSByZWFsIHN0b2xlbl9vZmZzZXQsIGluc3RlYWQgb2YgbWFraW5n IGFzc3VtcHRpb25zLgoKQ2hlZXJzLCBEYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fc3RvbGVuLmMgfCAxNSArKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9zdG9sZW4uYwo+IGluZGV4IGFmOTE1ZDA0MTI4MS4uYWQ5NDljYzMwOTI4IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0b2xlbi5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMKPiBAQCAtNTEsNiArNTEs MTAgQEAgaW50IGk5MTVfZ2VtX3N0b2xlbl9pbnNlcnRfbm9kZV9pbl9yYW5nZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlpZiAoIWRybV9tbV9pbml0aWFsaXplZCgmZGV2 X3ByaXYtPm1tLnN0b2xlbikpCj4gIAkJcmV0dXJuIC1FTk9ERVY7Cj4gIAo+ICsJLyogV2FTa2lw U3RvbGVuTWVtb3J5Rmlyc3RQYWdlOmJkdysgKi8KPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYp ID49IDggJiYgc3RhcnQgPCA0MDk2KQo+ICsJCXN0YXJ0ID0gNDA5NjsKPiArCj4gIAltdXRleF9s b2NrKCZkZXZfcHJpdi0+bW0uc3RvbGVuX2xvY2spOwo+ICAJcmV0ID0gZHJtX21tX2luc2VydF9u b2RlX2luX3JhbmdlKCZkZXZfcHJpdi0+bW0uc3RvbGVuLCBub2RlLAo+ICAJCQkJCSAgc2l6ZSwg YWxpZ25tZW50LCAwLAo+IEBAIC0zNDMsNyArMzQ3LDYgQEAgaW50IGk5MTVfZ2VtX2luaXRfc3Rv bGVuKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJcmVzb3VyY2Vf c2l6ZV90IHJlc2VydmVkX2Jhc2UsIHN0b2xlbl90b3A7Cj4gIAlyZXNvdXJjZV9zaXplX3QgcmVz ZXJ2ZWRfdG90YWwsIHJlc2VydmVkX3NpemU7Cj4gLQlyZXNvdXJjZV9zaXplX3Qgc3RvbGVuX3Vz YWJsZV9zdGFydDsKPiAgCj4gIAltdXRleF9pbml0KCZkZXZfcHJpdi0+bW0uc3RvbGVuX2xvY2sp Owo+ICAKPiBAQCAtNDM1LDE3ICs0MzgsMTEgQEAgaW50IGk5MTVfZ2VtX2luaXRfc3RvbGVuKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQkJICh1NjQpcmVzb3VyY2Vfc2l6 ZSgmZGV2X3ByaXYtPmRzbSkgPj4gMTAsCj4gIAkJCSAoKHU2NClyZXNvdXJjZV9zaXplKCZkZXZf cHJpdi0+ZHNtKSAtIHJlc2VydmVkX3RvdGFsKSA+PiAxMCk7Cj4gIAo+IC0Jc3RvbGVuX3VzYWJs ZV9zdGFydCA9IDA7Cj4gLQkvKiBXYVNraXBTdG9sZW5NZW1vcnlGaXJzdFBhZ2U6YmR3KyAqLwo+ IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOCkKPiAtCQlzdG9sZW5fdXNhYmxlX3N0YXJ0 ID0gNDA5NjsKPiAtCj4gIAlkZXZfcHJpdi0+c3RvbGVuX3VzYWJsZV9zaXplID0KPiAtCQlyZXNv dXJjZV9zaXplKCZkZXZfcHJpdi0+ZHNtKSAtIHJlc2VydmVkX3RvdGFsIC0gc3RvbGVuX3VzYWJs ZV9zdGFydDsKPiArCQlyZXNvdXJjZV9zaXplKCZkZXZfcHJpdi0+ZHNtKSAtIHJlc2VydmVkX3Rv dGFsOwo+ICAKPiAgCS8qIEJhc2ljIG1lbXJhbmdlIGFsbG9jYXRvciBmb3Igc3RvbGVuIHNwYWNl LiAqLwo+IC0JZHJtX21tX2luaXQoJmRldl9wcml2LT5tbS5zdG9sZW4sIHN0b2xlbl91c2FibGVf c3RhcnQsCj4gLQkJICAgIGRldl9wcml2LT5zdG9sZW5fdXNhYmxlX3NpemUpOwo+ICsJZHJtX21t X2luaXQoJmRldl9wcml2LT5tbS5zdG9sZW4sIDAsIGRldl9wcml2LT5zdG9sZW5fdXNhYmxlX3Np emUpOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4gLS0gCj4gMi4xNy4wLnJjMgo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=