From: Daniel Vetter Subject: Re: [PATCH 7/7] drm/vmwgfx: Stop messing about with plane->fb/old_fb/crtc Date: Thu, 5 Apr 2018 22:39:52 +0200 Message-ID: <20180405203952.GO3881@phenom.ffwll.local> References: <20180405195035.24722-1-ville.syrjala@linux.intel.com> <20180405195035.24722-7-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180405195035.24722-7-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: Thomas Hellstrom , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, VMware Graphics List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDUsIDIwMTggYXQgMTA6NTA6MzVQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IHBsYW5lLT5mYi9vbGRfZmIvY3J0YyBzaG91bGQgbm8gbG9uZ2VyIGJlIHVzZWQg YnkgYXRvbWljCj4gZHJpdmVycy4gU3RvcCBtZXNzaW5nIGFib3V0IHdpdGggdGhlbS4KPiAKPiBU T0RPOiBTcXVhc2ggd2l0aCB0aGUgY29yZS9oZWxwZXIgcGF0Y2g/CgpOb3QgcG9zc2libGUsIGJl Y2F1c2UgdGhlIGNvcmUgc2V0Y29uZmlnIG9uZSBkb2VzIG5vIGxvbmdlciB3b3JrIHdpdGgKYXRv bWljIGRyaXZlcnMgZXZlciBzaW5jZSBJJ3ZlIHRocm93biBhd2F5IHRoZSBtYWdpYyBiYWNrb2Zm LiBTaW5jZSB0aGVuCndlIGhhdmUgdGhlIHJ1bGUgdGhhdCBmb3IgYW55IGF0b21pYyBkcml2ZXIs IHlvdSBuZWVkIGEgcmVhbCBhdG9taWMgY29tbWl0CihpbmNsdWRpbmcgcGFzc2luZyB0aGUgYWNx dWlyZV9jdHggZG93biB0byB0aGF0IHZlcnkgY2FsbCB0bwpkcm1fYXRvbWljX2NvbW1pdCkuCgpT ZWUgdGhlIHBhdGNoIHRoYXQgaW50cm9kdWNlZCB0aGlzIGNvcHlwYXN0YSBmb3IgZnVsbCBkZXRh aWxzIHBsdXMgaG93IHRvCmZpeCBpdCB1cCBwcm9wZXJseToKCmNvbW1pdCAzYmFjZjQzNjFjZDA3 Zjk4OGExM2RlNzhkNjcyOTI4NjA2ZGYyNGFkCkF1dGhvcjogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KRGF0ZTogICBUaHUgQXByIDYgMjI6MDI6NTYgMjAxNyArMDIwMAoK ICAgIGRybS92bXdnZng6IEZpeCBmYmRldiBlbXVsYXRpb24gdXNpbmcgbGVnYWN5IGZ1bmN0aW9u cwogICAgCiAgICBJJ3ZlIGJyb2tlbiB0aGlzIGJ5IHJlbW92aW5nIHRoZSBiYWNrb2ZmIGhhbmRs aW5nIGZyb20gdGhlCiAgICBzZXRfY29uZmlnMmF0b21pYyBoZWxwZXIgaW4KICAgIAogICAgY29t bWl0IDM4YjY0NDFlNGU3NWMwYjMxOWNmZTRkOTM2NGMxMDU5ZmMxZTNjMmIKICAgIEF1dGhvcjog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KICAgIERhdGU6ICAgV2VkIE1h ciAyMiAyMjo1MDo1OCAyMDE3ICswMTAwCiAgICAKICAgICAgICBkcm0vYXRvbWljLWhlbHBlcjog UmVtb3ZlIHRoZSBiYWNrb2ZmIGhhY2sgZnJvbSBzZXRfY29uZmlnCiAgICAKICAgIEZpeGluZyB0 aGlzIHByb3Blcmx5IHdvdWxkIG1lYW4gd2UgZ2V0IHRvIHdpcmUgdGhlIGFjcXVpcmVfY3R4IGFs bCB0aGUKICAgIHdheSB0aHJvdWdoIHZtd2dmeCBmYmRldiBjb2RlLCBhbmQgZG9pbmcgdGhlIHNh bWUgd2FzIHRyaWNreSBmb3IgdGhlCiAgICBzaGFyZWQgZmJkZXYgbGF5ZXIuIFByb2JhYmx5IG11 Y2ggYmV0dGVyIHRvIGxvb2sgaW50byByZWZhY3RvcmluZyB0aGUKICAgIGVudGlyZSBjb2RlIHRv IHVzZSB0aGUgaGVscGVycywgYnV0IHNpbmNlIHRoYXQncyBub3QgYSB2aWFibGUKICAgIGxvbmct dGVybSBzb2x1dGlvbiBmaXggdGhlIGlzc3VlIGJ5IG9wZW4tY29kaW5nIGEgdm13Z2Z4IHZlcnNp b24gb2YKICAgIHNldF9jb25maWcsIHRoYXQgZG9lcyB0aGUgbGVnYWN5IGJhY2tvZmYgZGFuY2Ug aW50ZXJuYWxseS4KICAgIAogICAgTm90ZTogSnVzdCBjb21waWxlLXRlc3RlZC4gVGhlIGlkZWEg aXMgdG8gdGFrZQogICAgZHJtX21vZGVfc2V0X2NvbmZpZ19pbnRlcm5hbCgpLCByZW1vdmUgdGhl ICJpcyB0aGlzIGEgbGVnYWN5IGRyaXZlciIKICAgIGNoZWNrLCBhbmQgd2hhY2sgdGhlIGRybV9h dG9taWNfbGVnYWN5X2JhY2tvZmYgdHJpY2tlcnkgYXQgdGhlIGVuZC4KICAgIFNpbmNlIGRybV9h dG9taWNfbGVnYWN5X2JhY2tvZmYgaXMgZm9yIGF0b21pYyBjb21taXRzIG9ubHkgd2UgbmVlZCB0 bwogICAgb3Blbi1jb2RlIGl0LgogICAgCiAgICBDYzogVGhvbWFzIEhlbGxzdHJvbSA8dGhlbGxz dHJvbUB2bXdhcmUuY29tPgogICAgU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBpbnRlbC5jb20+CiAgICBSZXZpZXdlZC1ieTogVGhvbWFzIEhlbGxzdHJvbSA8dGhl bGxzdHJvbUB2bXdhcmUuY29tPgogICAgU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1 bEBjaHJvbWl1bS5vcmc+CiAgICBMaW5rOiBodHRwOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9y Zy9wYXRjaC9tc2dpZC8yMDE3MDQwNjIwMDI1Ni4yNjA0MC0xLWRhbmllbC52ZXR0ZXJAZmZ3bGwu Y2gKCkkgc2Nyb2xsZWQgdGhyb3VnaCB5b3VyIHZtd2dmeCBwYXRjaGVzLCBhbmQgd2lsbCB0cnkg dG8gbG9vayBhdCB0aGVtIG1heWJlCm5leHQgd2Vlay4gVG9vIGNvbXBsaWNhdGVkIGZvciB0aGlz IGxhdGUsIGFuZCB0b21vcnJvdyBJJ20gb29vLgotRGFuaWVsCgo+IAo+IENjOiBUaG9tYXMgSGVs bHN0cm9tIDx0aGVsbHN0cm9tQHZtd2FyZS5jb20+Cj4gQ2M6IFNpbmNsYWlyIFllaCA8c3llaEB2 bXdhcmUuY29tPgo+IENjOiBWTXdhcmUgR3JhcGhpY3MgPGxpbnV4LWdyYXBoaWNzLW1haW50YWlu ZXJAdm13YXJlLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9mYi5jIHwg MjQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZmIu YyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ZiLmMKPiBpbmRleCAyNTgyZmZkMzZi YjUuLjNjNTkzNWYzZDQ5ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Zt d2dmeF9mYi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZmIuYwo+IEBA IC00MzksOCArNDM5LDYgQEAgc3RhdGljIGludCB2bXdfZmJfY29tcHV0ZV9kZXB0aChzdHJ1Y3Qg ZmJfdmFyX3NjcmVlbmluZm8gKnZhciwKPiAgc3RhdGljIGludCB2bXdnZnhfc2V0X2NvbmZpZ19p bnRlcm5hbChzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpCj4gIHsKPiAgCXN0cnVjdCBkcm1fY3J0 YyAqY3J0YyA9IHNldC0+Y3J0YzsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+IC0J c3RydWN0IGRybV9jcnRjICp0bXA7Cj4gIAlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHgg KmN0eDsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBzZXQtPmNydGMtPmRldjsKPiAgCWlu dCByZXQ7Cj4gQEAgLTQ0OCwyOSArNDQ2LDcgQEAgc3RhdGljIGludCB2bXdnZnhfc2V0X2NvbmZp Z19pbnRlcm5hbChzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpCj4gIAljdHggPSBkZXYtPm1vZGVf Y29uZmlnLmFjcXVpcmVfY3R4Owo+ICAKPiAgcmVzdGFydDoKPiAtCS8qCj4gLQkgKiBOT1RFOiAt PnNldF9jb25maWcgY2FuIGFsc28gZGlzYWJsZSBvdGhlciBjcnRjcyAoaWYgd2Ugc3RlYWwgYWxs Cj4gLQkgKiBjb25uZWN0b3JzIGZyb20gaXQpLCBoZW5jZSB3ZSBuZWVkIHRvIHJlZmNvdW50IHRo ZSBmYnMgYWNyb3NzIGFsbAo+IC0JICogY3J0Y3MuIEF0b21pYyBtb2Rlc2V0IHdpbGwgaGF2ZSBz YW5lciBzZW1hbnRpY3MgLi4uCj4gLQkgKi8KPiAtCWRybV9mb3JfZWFjaF9jcnRjKHRtcCwgZGV2 KQo+IC0JCXRtcC0+cHJpbWFyeS0+b2xkX2ZiID0gdG1wLT5wcmltYXJ5LT5mYjsKPiAtCj4gLQlm YiA9IHNldC0+ZmI7Cj4gLQo+ICAJcmV0ID0gY3J0Yy0+ZnVuY3MtPnNldF9jb25maWcoc2V0LCBj dHgpOwo+IC0JaWYgKHJldCA9PSAwKSB7Cj4gLQkJY3J0Yy0+cHJpbWFyeS0+Y3J0YyA9IGNydGM7 Cj4gLQkJY3J0Yy0+cHJpbWFyeS0+ZmIgPSBmYjsKPiAtCX0KPiAtCj4gLQlkcm1fZm9yX2VhY2hf Y3J0Yyh0bXAsIGRldikgewo+IC0JCWlmICh0bXAtPnByaW1hcnktPmZiKQo+IC0JCQlkcm1fZnJh bWVidWZmZXJfZ2V0KHRtcC0+cHJpbWFyeS0+ZmIpOwo+IC0JCWlmICh0bXAtPnByaW1hcnktPm9s ZF9mYikKPiAtCQkJZHJtX2ZyYW1lYnVmZmVyX3B1dCh0bXAtPnByaW1hcnktPm9sZF9mYik7Cj4g LQkJdG1wLT5wcmltYXJ5LT5vbGRfZmIgPSBOVUxMOwo+IC0JfQo+ICAKPiAgCWlmIChyZXQgPT0g LUVERUFETEspIHsKPiAgCQlkZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4ID0gTlVMTDsKPiAt LSAKPiAyLjE2LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK