From: Guillaume Nault Subject: Re: [PATCH] slip: Check if rstate is initialized before uncompressing Date: Tue, 10 Apr 2018 11:48:11 +0200 Message-ID: <20180410094811.GA1433@alphalink.fr> References: <20180409085345.GA5972@tejaswit-linux.qualcomm.com> <20180409.110438.458180702294361660.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org To: tejaswit@codeaurora.org Return-path: Received: from zimbra.alphalink.fr ([217.15.80.77]:51958 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbeDJJsU (ORCPT ); Tue, 10 Apr 2018 05:48:20 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Apr 10, 2018 at 11:28:10AM +0530, tejaswit@codeaurora.org wrote: > On 2018-04-09 20:34, David Miller wrote: > > From: Tejaswi Tanikella > > Date: Mon, 9 Apr 2018 14:23:49 +0530 > > > > > @@ -673,6 +677,7 @@ struct slcompress * > > > if (cs->cs_tcp.doff > 5) > > > memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr), > > > (cs->cs_tcp.doff - 5) * 4); > > > cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2; > > > + cs->initialized = 1; > > > /* Put headers back on packet > > ... > > > struct cstate { > > > byte_t cs_this; /* connection id number (xmit) */ > > > + byte_t initialized; /* non-zero if initialized */ > > > > Please use 'bool' and true/false for 'initialized'. > > Made the changes. Hi Tejaswi, Please send the new version of your patch as fresh new submission, with proper subject prefix. In this case, it should be [PATCH net v2]. 'net' because this is a bugfix and it should therefore target the 'net' tree. 'v2' because that's the second version of this series. Also it'd be good if you could add a proper 'Fixes' tag in order to help with stable backports. If the bug has always been there, just say so. I have no expertise on slhc, but overall, the patch content looks fine. Guillaume