From: Gary Bisson <gary.bisson@boundarydevices.com>
Date: Thu, 12 Apr 2018 14:58:51 +0200
Subject: [U-Boot] [PATCH V3 1/3] imx6: Define 'soc' env var for imx6 SoC
In-Reply-To: <f78f6c03-15e8-c4bc-f66e-e9fbbe58f9c8@free.fr>
References: <20180409063941.7754-1-guillaume.gardet@free.fr>
 <20180411103850.13539-1-guillaume.gardet@free.fr>
 <20180411103850.13539-2-guillaume.gardet@free.fr>
 <20180411154624.GA22735@t450s.lan>
 <30c0c899-07fe-0c5e-6512-1ccd761b0329@free.fr>
 <CAOMZO5CsQhUCfnrEytzngW9DfzqhAqP6+-+jJ7h6QudOWfSQUQ@mail.gmail.com>
 <80e36562-073a-2198-26af-a4e51a96dc15@free.fr>
 <CAOMZO5BeYjz1068o7oe=japNFJBGOg9mOGGyXjQW=1OdreWB-Q@mail.gmail.com>
 <20180412123628.GA20887@t450s.lan>
 <f78f6c03-15e8-c4bc-f66e-e9fbbe58f9c8@free.fr>
Message-ID: <20180412125851.GA26047@t450s.lan>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Hi Guillaume,

On Thu, Apr 12, 2018 at 02:48:07PM +0200, Guillaume Gardet wrote:
> 
> 
> Le 12/04/2018 à 14:36, Gary Bisson a écrit :
> > Hi Fabio, Guillaume
> > 
> > On Thu, Apr 12, 2018 at 08:14:51AM -0300, Fabio Estevam wrote:
> > > On Thu, Apr 12, 2018 at 5:13 AM, Guillaume Gardet
> > > <guillaume.gardet@free.fr> wrote:
> > > script that picks the correct dtb.
> > > > Ok. So, how would you like to proceed?
> > > > Remove the generic mx6 'soc' definition and use a board sepcific 'board_rev'
> > > > (or maybe a static definition if one configuration match a single dtb) to
> > > > define the right dtb?
> > > I prefer to keep the same solution as done in other boards sucn as
> > > mx6sabresd, wandboard and cuboxi.
> > Ok. My suggestion was to have something generic so that it matches the
> > fdt name set in config_distro_bootcmd.h
> > (${soc}-${board}${boardver}.dtb).
> > 
> > I especially like the naming in that standard, don't think board_rev
> > should be the SOC name.
> > 
> > This would also avoid redundancy in each board_late_init functions since
> > only the board name would need to be setup (and boardver in some cases
> > like wandboard).
> > 
> > Guillaume, please forget that point for now and just set your fdtfile
> > name in the config file. I'll update the board file later on.
> 
> Ok.
> 
> Could you just confirm which DTB should work with the various nitrogen6x boards config, please?
> Are the following ok?
> * imx6q-nitrogen6x.dts     =>     nitrogen6q2g_defconfig nitrogen6q_defconfig
> * imx6dl-nitrogen6x.dts     =>     nitrogen6dl2g_defconfig nitrogen6dl_defconfig
> * imx6sx-nitrogen6sx.dts     =>     nitrogen6s1g_defconfig nitrogen6s_defconfig

No, imx6sx is different than imx6s. Solo is the same as imx6dl as far as
the kernl is concerned.

Maybe just leave fdt_file blank for nitrogen6x for now, it's only necessary
for PXE which isn't enabled in nitrogen6*defconfig.

Regards,
Gary