From: Sebastian Andrzej Siewior Subject: Re: [PATCH] iommu: amd: hide unused iommu_table_lock Date: Fri, 13 Apr 2018 17:03:10 +0200 Message-ID: <20180413150310.4gbpuavvimnfj57a@linutronix.de> References: <20180404105713.633983-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180404105713.633983-1-arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Arnd Bergmann , Joerg Roedel Cc: Tom Lendacky , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner List-Id: iommu@lists.linux-foundation.org On 2018-04-04 12:56:59 [+0200], Arnd Bergmann wrote: > The newly introduced lock is only used when CONFIG_IRQ_REMAP is enabled: > > drivers/iommu/amd_iommu.c:86:24: error: 'iommu_table_lock' defined but not used [-Werror=unused-variable] > static DEFINE_SPINLOCK(iommu_table_lock); > > This moves the definition next to the user, within the #ifdef protected > section of the file. > > Fixes: ea6166f4b83e ("iommu/amd: Split irq_lookup_table out of the amd_iommu_devtable_lock") > Signed-off-by: Arnd Bergmann Acked-by: Sebastian Andrzej Siewior Thank you Arnd. Sebastian