Received: from eggs.gnu.org ([2001:4830:134:3::10]:56774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8mcx-0006i5-FS for qemu-devel@nongnu.org; Wed, 18 Apr 2018 08:56:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8mct-00017I-LR for qemu-devel@nongnu.org; Wed, 18 Apr 2018 08:55:59 -0400 Date: Wed, 18 Apr 2018 13:55:45 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180418125545.GN27579@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180418123838.3511-1-olaf@aepfle.de> <20180418144538.4aa2f492.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180418144538.4aa2f492.cohuck@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1] configure: require glib-2.24 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Olaf Hering , Peter Maydell , Fam Zheng , qemu-trivial@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "open list:All patches CC here" , Gerd Hoffmann , Paolo Bonzini On Wed, Apr 18, 2018 at 02:45:38PM +0200, Cornelia Huck wrote: > On Wed, 18 Apr 2018 14:38:37 +0200 > Olaf Hering wrote: > > > Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore. > > Fixes commit 418026ca43 ("util: Introduce vfio helpers") > > > > Signed-off-by: Olaf Hering > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6e9b994f21..81760ef45a 100755 > > --- a/configure > > +++ b/configure > > @@ -3369,7 +3369,7 @@ fi > > if test "$mingw32" = yes; then > > glib_req_ver=2.30 > > else > > - glib_req_ver=2.22 > > + glib_req_ver=2.24 > > fi > > glib_modules=gthread-2.0 > > if test "$modules" = yes; then > > > > Are we ready to give up support for whatever distro is still on 2.22? > (If yes, can we bump to an even newer glib version?) Or should we > rather solve this by adding a g_realloc_n implementation for that case? Version 2.22 was released in Sep 2009, so coming up for 9 years old now. At some point we should to declare that platforms shipping >= NNN year old versions of software are not a desirable target for QEMU. What is our desired NNN value - 9 years feels awfully long to me. For libvirt we recently decided to become more aggressive[1] in culling old distros as supportable targets, declaring we'll only support non-EOL distros (for short life distros), or for long life distros (RHEL, LTS, etc) the most recent version, and the recent minus-1 for 2 years overlap. Should we formalize similar guidelines for QEMU to give developers a guide for when it is reasonable to increase the min required version of any 3rd party library ? glib is a mandatory dep, but we've countless other optional libraries we might wish to increase min versions for too, and no guide on when it is reasonable todo so. Regards, Daniel [1] https://libvirt.org/platforms.html -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|