From: Hans de Goede Subject: [PATCH] drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2 Date: Fri, 20 Apr 2018 11:59:33 +0200 Message-ID: <20180420095933.16442-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Daniel Vetter Cc: Hans de Goede , intel-gfx , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QmVmb3JlIHRoaXMgY29tbWl0IHRoZSBXYVNraXBTdG9sZW5NZW1vcnlGaXJzdFBhZ2Ugd29ya2Fy b3VuZCBjb2RlIHdhcwpza2lwcGluZyB0aGUgZmlyc3QgNGsgYnkgcGFzc2luZyA0MDk2IGFzIHN0 YXJ0IG9mIHRoZSBhZGRyZXNzIHJhbmdlIHBhc3NlZAp0byBkcm1fbW1faW5pdCgpLiBUaGlzIG1l YW5zIHRoYXQgY2FsbGluZyBkcm1fbW1fcmVzZXJ2ZV9ub2RlKCkgdG8gdHJ5IGFuZApyZXNlcnZl IHRoZSBmaXJtd2FyZSBmcmFtZWJ1ZmZlciBzbyB0aGF0IHdlIGNhbiBpbmhlcml0IGl0IHdvdWxk IGFsd2F5cwpmYWlsLCBhcyB0aGUgZmlybXdhcmUgZnJhbWVidWZmZXIgc3RhcnRzIGF0IGFkZHJl c3MgMC4KCkNvbW1pdCBkNDM1Mzc2MTA0NzAgKCJkcm0vaTkxNTogc2tpcCB0aGUgZmlyc3QgNGsg b2Ygc3RvbGVuIG1lbW9yeSBvbgpldmVyeXRoaW5nID49IGdlbjgiKSBzYXlzIGluIGl0cyBjb21t aXQgbWVzc2FnZTogIlRoaXMgaXMgY29uZmlybWVkIHRvIGZpeApTa3lsYWtlIHNjcmVlbiBmbGlj a2VyaW5nIGlzc3VlcyAocHJvYmFibHkgY2F1c2VkIGJ5IHRoZSBmYWN0IHRoYXQgd2UKaW5pdGlh bGl6ZWQgYSByaW5nIGluIHRoZSBmaXJzdCBwYWdlIG9mIHN0b2xlbiwgYnV0IEkgZGlkbid0IDEw MCUgY29uZmlybQp0aGlzIHRoZW9yeSkuIgoKV2hpY2ggc3VnZ2VzdHMgdGhhdCBpdCBpcyBzYWZl IHRvIHVzZSB0aGUgZmlyc3QgcGFnZSBmb3IgYSBsaW5lYXIKZnJhbWVidWZmZXIgYXMgdGhlIGZp cm13YXJlIGlzIGRvaW5nIChzZWUgbm90ZSBiZWxvdykuCgpUaGlzIGNvbW1pdCBhbHdheXMgcGFz c2VzIDAgYXMgc3RhcnQgdG8gZHJtX21tX2luaXQoKSBhbmQgd29ya3MgYXJvdW5kCldhU2tpcFN0 b2xlbk1lbW9yeUZpcnN0UGFnZSBpbiBpOTE1X2dlbV9zdG9sZW5faW5zZXJ0X25vZGVfaW5fcmFu Z2UoKQpieSBpbnN1cmluZyB0aGUgc3RhcnQgYWRkcmVzcyBwYXNzZWQgYnkgdG8gZHJtX21tX2lu c2VydF9ub2RlX2luX3JhbmdlKCkKaXMgYWx3YXlzIDRrIG9yIG1vcmUuIEFsbCBlbnRyeSBwb2lu dHMgdG8gaTkxNV9nZW1fc3RvbGVuLmMgZ28gdGhyb3VnaAppOTE1X2dlbV9zdG9sZW5faW5zZXJ0 X25vZGVfaW5fcmFuZ2UoKSwgc28gdGhhdCBhbnkgbmV3bHkgYWxsb2NhdGVkCm9iamVjdHMgc3Vj aCBhcyByaW5nLWJ1ZmZlcnMgd2lsbCBub3QgYmUgYWxsb2NhdGVkIGluIHRoZSBmaXJzdCA0ay4K ClRoZSBvbmUgZXhjZXB0aW9uIGlzIGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfc3RvbGVuX2Zvcl9w cmVhbGxvY2F0ZWQoKQp3aGljaCBkaXJlY3RseSBjYWxscyBkcm1fbW1fcmVzZXJ2ZV9ub2RlKCkg d2hpY2ggbm93IHdpbGwgYmUgYWJsZSB0bwp1c2UgdGhlIGZpcnN0IDRrLgoKVGhpcyBmaXhlcyB0 aGUgaTkxNSBkcml2ZXIgbm8gbG9uZ2VyIGJlaW5nIGFibGUgdG8gaW5oZXJpdCB0aGUgZmlybXdh cmUKZnJhbWVidWZmZXIgb24gZ2VuOCssIHdoaWNoIGZpeGVzIHRoZSB2aWRlbyBvdXRwdXQgY2hh bmdpbmcgZnJvbSB0aGUKdmVuZG9yIGxvZ28gdG8gYSBibGFjayBzY3JlZW4gYXMgc29vbiBhcyB0 aGUgaTkxNSBkcml2ZXIgaXMgbG9hZGVkCihvbiBzeXN0ZW1zIHdpdGhvdXQgZmJjb24pLgoKU29t ZSBub3RlcyBhYm91dCB0aGUgbWFwcGluZyBvZiB0aGUgQklPUyBmcmFtZWJ1ZmZlcjoKCnYxIGxl ZCB0byBzb21lIGRpc2N1c3Npb24gaWYgdGhlIGFzc3VtcHRpb24gb2YgdGhlIGludGVsX2Rpc3Bs YXkuYyBjb2RlCnRoYXQgdGhlIGZpcm13YXJlIGZyYW1lYnVmZmVyIGlzIGEgbGluZWFyIG1hcHBp bmcgb2YgdGhlIHN0b2xlbiBtZW1vcnkKc3RhcnRpbmcgYXQgb2Zmc2V0IDAgaXMgc3RpbGwgY29y cmVjdCwgYmVjYXVzZSB0aGF0IHdvdWxkIG1lYW4gdGhhdCB0aGUKR09QIGRvZXMgbm90IGltcGxl bWVudCB0aGUgV2FTa2lwU3RvbGVuTWVtb3J5Rmlyc3RQYWdlIHdvcmthcm91bmQuCgpUbyB2ZXJp ZnkgdGhpcyB0aGUgZm9sbG93aW5nIGNvZGUgd2FzIGFkZGVkIGF0IHRoZSBlbmQgb2YKaTkxNV9n ZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW5fZm9yX3ByZWFsbG9jYXRlZCgpIDoKCnByX2VycigiZmly c3QgZ2d0dCBlbnRyeSBiZWZvcmUgYmluZDogMHglMDE2bGx4XG4iLAogICAgICAgcmVhZHEoZGV2 X3ByaXYtPmdndHQuZ3NtKSk7CnJldCA9IGk5MTVfdm1hX2JpbmQodm1hLAogICAgICAgICAgICBI QVNfTExDKGRldl9wcml2KSA/IEk5MTVfQ0FDSEVfTExDIDogSTkxNV9DQUNIRV9OT05FLAogICAg ICAgICAgICBQSU5fVVBEQVRFKTsKcHJfZXJyKCJpOTE1X3ZtYV9iaW5kIHJldCAlZFxuIiwgcmV0 KTsKcHJfZXJyKCJmaXJzdCBnZ3R0IGVudHJ5IGFmdGVyIGJpbmQ6IDB4JTAxNmxseFxuIiwKICAg ICAgIHJlYWRxKGRldl9wcml2LT5nZ3R0LmdzbSkpOwoKV2hpY2ggcHJpbnRzIHRoZSBtYXBwaW5n IG9mIHRoZSBmaXJzdCBwYWdlLCB0aGVuIGRvZXMgYSB2bWFfYmluZCgpIHRvCmZvcmNlIHVwZGF0 ZSB0aGUgbWFwcGluZyB3aXRoIG91ciBsaW5lYXIgdmlldyBvZiB0aGUgZnJhbWVidWZmZXIgYW5k CnRoZW4gcHJpbnRzIHRoZSBtYXBwaW5nIG9mIHRoZSBmaXJzdCBwYWdlIGFnYWluLgoKT24gYW4g QXNyb2NrIEIxNTBNIFBybzRTL0QzIG1haW5ib2FyZCB3aXRoIGk1LTY1MDAgQ1BVIHRoaXMgcHJp bnRzOgoKWyAgICAxLjY1MTE0MV0gZmlyc3QgZ2d0dCBlbnRyeSBiZWZvcmUgYmluZDogMHgwMDAw MDAwMDc4YzAwMDAxClsgICAgMS42NTExNTFdIGk5MTVfdm1hX2JpbmQgcmV0IDAKWyAgICAxLjY1 MTE1Ml0gZmlyc3QgZ2d0dCBlbnRyeSBhZnRlciBiaW5kOiAweDAwMDAwMDAwNzhjMDAwODMKCkFu ZCAic3VkbyBjYXQgL3Byb2MvaW9tZW0gfCBncmVwIFN0b2xlbiIgZ2l2ZXM6CiAgNzhjMDAwMDAt ODhiZmZmZmYgOiBHcmFwaGljcyBTdG9sZW4gTWVtb3J5CgpUaGVyZSBhcmUgbm8gdmlzdWFsIGNo YW5nZXMgd2l0aCB0aGlzIHBhdGNoIChCSU9TIHZlbmRvciBsb2dvIHN0aWxsCnN0YXlzIGluIHBs YWNlIHdoZW4gd2UgaW5oZXJpdCB0aGUgQklPUyBmcmFtZWJ1ZmZlciksIHNvIHRoZSB2bWFfYmlu ZCgpCmRvZXMgbm90IGltcGFjdCB3aGljaCBtZW1vcnkgaXMgYmVpbmcgc2Nhbm5lZCBvdXQuCgpU aGUgYWRkcmVzcyBvZiB0aGUgZmlyc3QgZ2d0dCBlbnRyeSBtYXRjaGVzIHdpdGggdGhlIHN0YXJ0 IG9mIHN0b2xlbgphbmQgdGhlIGk5MTVfdm1hX2JpbmQgY2FsbCBvbmx5IGNoYW5nZXMgdGhlIGZp cnN0IGd0dCBlbnRyeSdzIGZsYWdzLApvci1pbmcgaW4gX1BBR0VfUlcgKEJJVCgxKSkgYW5kIFBQ QVRfQ0FDSEVEIChCSVQoNykpLCB3aGljaCBwZXJmZWN0bHkKbWF0Y2hlcyB3aGF0IHdlIHdvdWxk IGV4cGVjdCBiYXNlZCBvbiBnZW44X3B0ZV9lbmNvZGUoKSdzIGJlaGF2aW9yLgoKU28gaXQgc2Vl bXMgdGhhdCB0aGUgR09QIGluZGVlZCBkb2VzIE5PVCBpbXBsZW1lbnQgdGhlIHdhIGFuZCB0aGUg aTkxNSdzCmNvZGUgYXNzdW1pbmcgYSBsaW5lYXIgbWFwcGluZyBhdCB0aGUgc3RhcnQgb2Ygc3Rv bGVuIGZvciB0aGUgQklPUyBmYgpzdGlsbCBob2xkcyB0cnVlIGZvciBnZW44Ky4KCkkndmUgYWxz byB0ZXN0ZWQgdGhpcyBvbiBhIENoZXJyeSBUcmFpbCBiYXNlZCBkZXZpY2UgKGEgR1BEIFdpbikK d2l0aCBpZGVudGljYWwgcmVzdWx0cyAodGhlIGZsYWdzIGFyZSAweDFiIGFmdGVyIHRoZSB2bWFf YmluZApvbiBDSFQsIHdoaWNoIG1hdGNoZXMgd2l0aCBJOTE1X0NBQ0hFX05PTkUpLgoKQ2hhbmdl ZCBpbiB2MjogTm8gY29kZSBjaGFuZ2VzLCBleHRlbmRlZCB0aGUgY29tbWl0IG1lc3NhZ2Ugd2l0 aCB0aGUKdmVyaWZpY2F0aW9uIHRoYXQgdGhlIGludGVsX2Rpc3BsYXkuYyBCSU9TIGZyYW1lYnVm ZmVyIG1hcHBpbmcgaXMgc3RpbGwKY29ycmVjdC4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgpTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxo ZGVnb2VkZUByZWRoYXQuY29tPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3N0 b2xlbi5jIHwgMTUgKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX3N0b2xlbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc3RvbGVuLmMK aW5kZXggYWY5MTVkMDQxMjgxLi5hZDk0OWNjMzA5MjggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX3N0b2xlbi5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX3N0b2xlbi5jCkBAIC01MSw2ICs1MSwxMCBAQCBpbnQgaTkxNV9nZW1fc3RvbGVuX2lu c2VydF9ub2RlX2luX3JhbmdlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKIAlp ZiAoIWRybV9tbV9pbml0aWFsaXplZCgmZGV2X3ByaXYtPm1tLnN0b2xlbikpCiAJCXJldHVybiAt RU5PREVWOwogCisJLyogV2FTa2lwU3RvbGVuTWVtb3J5Rmlyc3RQYWdlOmJkdysgKi8KKwlpZiAo SU5URUxfR0VOKGRldl9wcml2KSA+PSA4ICYmIHN0YXJ0IDwgNDA5NikKKwkJc3RhcnQgPSA0MDk2 OworCiAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPm1tLnN0b2xlbl9sb2NrKTsKIAlyZXQgPSBkcm1f bW1faW5zZXJ0X25vZGVfaW5fcmFuZ2UoJmRldl9wcml2LT5tbS5zdG9sZW4sIG5vZGUsCiAJCQkJ CSAgc2l6ZSwgYWxpZ25tZW50LCAwLApAQCAtMzQzLDcgKzM0Nyw2IEBAIGludCBpOTE1X2dlbV9p bml0X3N0b2xlbihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCiB7CiAJcmVzb3Vy Y2Vfc2l6ZV90IHJlc2VydmVkX2Jhc2UsIHN0b2xlbl90b3A7CiAJcmVzb3VyY2Vfc2l6ZV90IHJl c2VydmVkX3RvdGFsLCByZXNlcnZlZF9zaXplOwotCXJlc291cmNlX3NpemVfdCBzdG9sZW5fdXNh YmxlX3N0YXJ0OwogCiAJbXV0ZXhfaW5pdCgmZGV2X3ByaXYtPm1tLnN0b2xlbl9sb2NrKTsKIApA QCAtNDM1LDE3ICs0MzgsMTEgQEAgaW50IGk5MTVfZ2VtX2luaXRfc3RvbGVuKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKIAkJCSAodTY0KXJlc291cmNlX3NpemUoJmRldl9wcml2 LT5kc20pID4+IDEwLAogCQkJICgodTY0KXJlc291cmNlX3NpemUoJmRldl9wcml2LT5kc20pIC0g cmVzZXJ2ZWRfdG90YWwpID4+IDEwKTsKIAotCXN0b2xlbl91c2FibGVfc3RhcnQgPSAwOwotCS8q IFdhU2tpcFN0b2xlbk1lbW9yeUZpcnN0UGFnZTpiZHcrICovCi0JaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPj0gOCkKLQkJc3RvbGVuX3VzYWJsZV9zdGFydCA9IDQwOTY7Ci0KIAlkZXZfcHJpdi0+ c3RvbGVuX3VzYWJsZV9zaXplID0KLQkJcmVzb3VyY2Vfc2l6ZSgmZGV2X3ByaXYtPmRzbSkgLSBy ZXNlcnZlZF90b3RhbCAtIHN0b2xlbl91c2FibGVfc3RhcnQ7CisJCXJlc291cmNlX3NpemUoJmRl dl9wcml2LT5kc20pIC0gcmVzZXJ2ZWRfdG90YWw7CiAKIAkvKiBCYXNpYyBtZW1yYW5nZSBhbGxv Y2F0b3IgZm9yIHN0b2xlbiBzcGFjZS4gKi8KLQlkcm1fbW1faW5pdCgmZGV2X3ByaXYtPm1tLnN0 b2xlbiwgc3RvbGVuX3VzYWJsZV9zdGFydCwKLQkJICAgIGRldl9wcml2LT5zdG9sZW5fdXNhYmxl X3NpemUpOworCWRybV9tbV9pbml0KCZkZXZfcHJpdi0+bW0uc3RvbGVuLCAwLCBkZXZfcHJpdi0+ c3RvbGVuX3VzYWJsZV9zaXplKTsKIAogCXJldHVybiAwOwogfQotLSAKMi4xNy4wCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK