From: Tarun Vyas Subject: Re: [RFC] drm/i915: Rework "Potential atomic update error" to handle PSR exit Date: Thu, 26 Apr 2018 20:09:56 -0700 Message-ID: <20180427030956.GA195018@otc-chromeosbuild-5> References: <20180426021009.178880-1-tarun.vyas@intel.com> <20180426134157.GL23723@intel.com> <1524764860.28916.3.camel@dk-H97M-D3H> <20180426213904.GA50779@otc-chromeosbuild-5> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id C87CF6E7CD for ; Fri, 27 Apr 2018 03:09:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180426213904.GA50779@otc-chromeosbuild-5> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMDI6Mzk6MDRQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBPbiBUaHUsIEFwciAyNiwgMjAxOCBhdCAxMDo0Nzo0MEFNIC0wNzAwLCBEaGluYWthcmFu IFBhbmRpeWFuIHdyb3RlOgo+ID4gCj4gPiAKPiA+IAo+ID4gT24gVGh1LCAyMDE4LTA0LTI2IGF0 IDE2OjQxICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgQXByIDI1 LCAyMDE4IGF0IDA3OjEwOjA5UE0gLTA3MDAsIHRhcnVuLnZ5YXNAaW50ZWwuY29tIHdyb3RlOgo+ ID4gPiA+IEZyb206IFRhcnVuIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ID4gPiAKPiA+ID4g PiBUaGUgRGlzcGxheSBzY2FubGluZSBjb3VudGVyIGZyZWV6ZXMgb24gUFNSIGVudHJ5LiBJbnNp ZGUKPiA+ID4gPiBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCwgb25jZSBWYmxhbmsgaW50ZXJydXB0 cyBhcmUgZW5hYmxlZCwgd2Ugc3RhcnQKPiA+ID4gPiBleGl0aW5nIFBTUiwgYnV0IGJ5IHRoZSB0 aW1lIHRoZSBzY2FubGluZSBjb3VudGVyIGlzIHJlYWQsIHdlIG1heSBub3QKPiA+ID4gPiBoYXZl IGNvbXBsZXRlbHkgZXhpdGVkIFBTUiB3aGljaCBsZWFkcyB1cyB0byBzY2hlZHVsZSBvdXQgYW5k IGNoZWNrIGJhY2sKPiA+ID4gPiBsYXRlci4KPiA+ID4gPiBPbiBDaHJvbWVPUy00LjQga2VybmVs LCB3aGljaCBpcyBmYWlybHkgdXAtdG8tZGF0ZSB3LnIudCBkcm0vaTkxNSBidXQKPiA+ID4gPiBs YWdzIHcuci50IGNvcmUga2VybmVsIGNvZGUsIGhvdCBwbHVnZ2luZyBhbiBleHRlcm5hbCBkaXNw bGF5IHRyaWdnZXJzCj4gPiA+ID4gdG9ucyBvZiAicG90ZW50aWFsIGF0b21pYyB1cGRhdGUgZXJy b3JzIiBpbiB0aGUgZG1lc2csIG9uICpwaXBlIEEqLiBBCj4gPiA+ID4gY2xvc2VyIGFuYWx5c2lz IHJldmVhbHMgdGhhdCB3ZSB0cnkgdG8gcmVhZCB0aGUgc2NhbmxpbmUgMyB0aW1lcyBhbmQKPiA+ ID4gPiBldmVudHVhbGx5IHRpbWVvdXQsIGIvYyBQU1IgaGFzbid0IGV4aXRlZCBmdWxseSBsZWFk aW5nIHRvIGEgUElQRURTTCBzdHVjayBACj4gPiA+ID4gMTU5OS4KPiA+ID4gPiBUaGlzIGlzc3Vl IGlzIG5vdCBzZWVuIG9uIHVwc3RyZWFtIGtlcm5lbHMsIGIvYyBmb3IgKnNvbWUqIHJlYXNvbiB3 ZQo+ID4gPiA+IGxvb3AgaW5zaWRlIGludGVsX3BpcGVfdXBkYXRlIHN0YXJ0IGZvciB+MisgbXNl YyB3aGljaCBpbiB0aGlzIGNhc2UgaXMKPiA+ID4gPiBtb3JlIHRoYW4gZW5vdWdoIHRvIGV4aXQg UFNSIGZ1bGx5LCBoZW5jZSBhbiAqdW5zdHVjayogUElQRURTTCBjb3VudGVyLAo+ID4gPiA+IGhl bmNlIG5vIGVycm9yLiBPbiB0aGUgb3RoZXIgaGFuZCwgdGhlIENocm9tZU9TIGtlcm5lbCBzcGVu ZHMgfjEuMSBtc2VjCj4gPiA+ID4gbG9vcGluZyBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGVfc3Rh cnQgYW5kIGhlbmNlIGVycm9ycyBvdXQgYi9jIHRoZQo+ID4gPiA+IHNvdXJjZSBpcyBzdGlsbCBp biBQU1IuCj4gPiA+ID4gCj4gPiA+ID4gSWYgUFNSIGlzIGVuYWJsZWQsIHRoZW4gd2Ugc2hvdWxk ICp3YWl0KiBmb3IgIHRoZSBQU1IKPiA+ID4gPiBzdGF0ZSB0byBtb3ZlIHRvIElETEUgYmVmb3Jl IHJlLXJlYWRpbmcgdGhlIFBJUEVEU0wgc28gYXMgdG8gYXZvaWQgYm9ndXMKPiA+ID4gPiBhbmQg YW5ub3lpbmcgInBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGVycm9yIiBtZXNzYWdlcy4KPiA+ID4g PiAKPiA+ID4gPiBQLlM6IFRoaXMgc2NlbmFyaW8gYXBwbGllcyB0byBhIGNvbmZpZ3VyYXRpb24g d2l0aCBhbiBhZGRpdGlvbmFsIHBpcGUsCj4gPiA+ID4gYXMgb2Ygbm93Lgo+ID4gPiA+IAo+ID4g Cj4gPiBWaWxsZSwgCj4gPiAKPiA+IEFueSBpZGVhIHdoYXQgY291bGQgYmUgdGhlIHJlYXNvbiB0 aGUgd2FybmluZ3Mgc3RhcnQgYXBwZWFyaW5nIHdoZW4gYW4KPiA+IGV4dGVybmFsIGRpc3BsYXkg aXMgY29ubmVjdGVkPyBXZSBjb3VsZG4ndCBjb21lIHVwIHdpdGggYW4gZXhwbGFuYXRpb24uCj4g PiAKPiBBbm90aGVyIHNvdXJjZSBvZiBjb25mdXNpb24gZm9yIG1lIGlzIHRoYXQgb24gdGhlIHVw c3RyZWFtIGtlcm5lbHMsIGl0ICphcHBlYXJzKiB0byB0YWtlIG1vcmUgdGltZSBmb3IgdXMgdG8g Z2V0ICpyZS1zY2hlZHVsZWQqIGFmdGVyIHdlIGNhbGwgc2NoZWR1bGVfdGltZW91dCgpLiBTbyB3 aXRoIH4yK21zZWMgc3BlbnQgaW4gdGhlIGxvb3AsIGl0IHNlZW1zIHRvIGJlIG5vdCB3b3JraW5n IGFzIGludGVuZGVkIGIvYyB3ZSBlbmQgdXAgc3BlbmRpbmcgYSBsb3QgbW9yZSB0aW1lIGluIHRo ZSBsb29wLCB3aGljaCBpbiB0dXJuIGNvbnRyaWJ1dGVzIHRvIHRoaXMgaXNzdWUgbm90IGJlaW5n IHNlZW4gb24gdXBzdHJlYW0ga2VybmVscy4KPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFRh cnVuIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAxOSArKysrKysrKysrKysrKystLS0tCj4gPiA+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4g PiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJp dGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+ID4gaW5kZXgg YWExZGZhYTY5MmI5Li43N2RkM2I5MzYxMzEgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gPiA+IEBAIC05MiwxMSArOTIsMTMgQEAgdm9pZCBpbnRl bF9waXBlX3VwZGF0ZV9zdGFydChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2Ny dGNfc3RhdGUpCj4gPiA+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0 b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPiA+ID4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICphZGp1c3RlZF9tb2RlID0gJm5ld19jcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21v ZGU7Cj4gPiA+ID4gIAlsb25nIHRpbWVvdXQgPSBtc2Vjc190b19qaWZmaWVzX3RpbWVvdXQoMSk7 Cj4gPiA+ID4gLQlpbnQgc2NhbmxpbmUsIG1pbiwgbWF4LCB2Ymxhbmtfc3RhcnQ7Cj4gPiA+ID4g KwlpbnQgc2NhbmxpbmUsIG1pbiwgbWF4LCB2Ymxhbmtfc3RhcnQsIG9sZF9zY2FubGluZSwgbmV3 X3NjYW5saW5lOwo+ID4gPiA+ICsJYm9vbCByZXRyaWVkID0gZmFsc2U7Cj4gPiA+ID4gIAl3YWl0 X3F1ZXVlX2hlYWRfdCAqd3EgPSBkcm1fY3J0Y192Ymxhbmtfd2FpdHF1ZXVlKCZjcnRjLT5iYXNl KTsKPiA+ID4gPiAgCWJvb2wgbmVlZF92bHZfZHNpX3dhID0gKElTX1ZBTExFWVZJRVcoZGV2X3By aXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSAmJgo+ID4gPiA+ICAJCWludGVsX2NydGNf aGFzX3R5cGUobmV3X2NydGNfc3RhdGUsIElOVEVMX09VVFBVVF9EU0kpOwo+ID4gPiA+ICAJREVG SU5FX1dBSVQod2FpdCk7Cj4gPiA+ID4gKwlvbGRfc2NhbmxpbmUgPSBuZXdfc2NhbmxpbmUgPSAt MTsKPiA+ID4gPiAgCj4gPiA+ID4gIAl2Ymxhbmtfc3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5jcnRj X3ZibGFua19zdGFydDsKPiA+ID4gPiAgCWlmIChhZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9N T0RFX0ZMQUdfSU5URVJMQUNFKQo+ID4gPiA+IEBAIC0xMjYsMTUgKzEyOCwyNCBAQCB2b2lkIGlu dGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdf Y3J0Y19zdGF0ZSkKPiA+ID4gPiAgCQkgKiByZWFkIHRoZSBzY2FubGluZS4KPiA+ID4gPiAgCQkg Ki8KPiA+ID4gPiAgCQlwcmVwYXJlX3RvX3dhaXQod3EsICZ3YWl0LCBUQVNLX1VOSU5URVJSVVBU SUJMRSk7Cj4gPiA+ID4gLQo+ID4gPiA+ICtyZXRyeToKPiA+ID4gPiAgCQlzY2FubGluZSA9IGlu dGVsX2dldF9jcnRjX3NjYW5saW5lKGNydGMpOwo+ID4gPiA+ICsJCW9sZF9zY2FubGluZSA9IG5l d19zY2FubGluZSwgbmV3X3NjYW5saW5lID0gc2NhbmxpbmU7Cj4gPiA+ID4gKwo+ID4gPiA+ICAJ CWlmIChzY2FubGluZSA8IG1pbiB8fCBzY2FubGluZSA+IG1heCkKPiA+ID4gPiAgCQkJYnJlYWs7 Cj4gPiA+ID4gIAo+ID4gPiA+ICAJCWlmICh0aW1lb3V0IDw9IDApIHsKPiA+ID4gPiAtCQkJRFJN X0VSUk9SKCJQb3RlbnRpYWwgYXRvbWljIHVwZGF0ZSBmYWlsdXJlIG9uIHBpcGUgJWNcbiIsCj4g PiA+ID4gKwkJCWlmKCFpOTE1LmVuYWJsZV9wc3IgfHwgcmV0cmllZCkgewo+ID4gCj4gPiBZb3Ug Y291bGQgdXNlIHRoZSBDQU5fUFNSKCkgbWFjcm8gdGhhdCBjaGVja3MgZm9yIHNvdXJjZSBhbmQg c2luawo+ID4gc3VwcG9ydC4KPiA+IAo+IFdpbGwgZG8uCj4gPiA+ID4gKwkJCQlEUk1fRVJST1Io IlBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwKPiA+ID4gPiAg CQkJCSAgcGlwZV9uYW1lKGNydGMtPnBpcGUpKTsKPiA+ID4gPiAtCQkJYnJlYWs7Cj4gPiA+ID4g KwkJCQlicmVhazsKPiA+ID4gPiArCQkJfQo+ID4gPiA+ICsJCQllbHNlIGlmKG9sZF9zY2FubGlu ZSA9PSBuZXdfc2NhbmxpbmUgJiYgIXJldHJpZWQpIHsKPiA+ID4gPiArCQkJCXJldHJpZWQgPSB0 cnVlOwo+ID4gPiA+ICsJCQkJaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIEVEUF9Q U1JfU1RBVFVTX0NUTCwgRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSywgRURQX1BTUl9TVEFUVVNf U1RBVEVfSURMRSwgMTApOwo+ID4gPiAKPiA+ID4gV2hhdCdzIHRoZSBwb2ludCBvZiBvYmZ1c2Nh dGluZyB0aGUgbG9vcCB3aXRoIHRoaXMgc3R1ZmY/Cj4gPiA+IEp1c3Qgd2FpdCBmb3IgdGhlIFBT UiBleGl0IGJlZm9yZSB3ZSBldmVuIGVudGVyIHRoZSBsb29wPwo+ID4gPgo+IEFncmVlZC4KT24g YSBzZWNvbmQgdGhvdWdodCwgSSB3YXMgZG9pbmcgaXQgd3JvbmcgaW4gdGhlIGluaXRpYWwgUkZD LiBDYW4ndCBkbyBhIHdhaXRfZm9yX3JlZ2lzdGVyIHdpdGggaXJxcyBkaXNhYmxlZCBieSBsb2Nh bF9pcnFfZGlzYWJsZSgpLiBTbywgd2lsbCBoYXZlIHRvICpwb2xsKiB0aGUgUFNSX1NUQVRFLCBi dXQgd2lsbCB0aGF0IGJlIGRlc2lyYWJsZSA/Cj4gPiA+ID4gKwkJCQlnb3RvIHJldHJ5Owo+ID4g PiA+ICsJCQl9Cj4gPiA+ID4gIAkJfQo+ID4gPiA+ICAKPiA+ID4gPiAgCQlsb2NhbF9pcnFfZW5h YmxlKCk7Cj4gPiA+ID4gLS0gCj4gPiA+ID4gMi4xMy41Cj4gPiA+ID4gCj4gPiA+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cj4gPiA+IAo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=