From: Yanglong Wu Subject: [PATCH v2] net/i40e: fix checking offloading fail for Tx Date: Fri, 27 Apr 2018 16:14:07 +0800 Message-ID: <20180427081407.41322-1-yanglong.wu@intel.com> References: <20180419063924.29802-1-yanglong.wu@intel.com> Cc: helin.zhang@intel.com, qi.z.zhang@intel.com, wei.dai@intel.com, Yanglong Wu To: dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 58335726F for ; Fri, 27 Apr 2018 10:19:13 +0200 (CEST) In-Reply-To: <20180419063924.29802-1-yanglong.wu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index bc660596b..2ce930827 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev, " or supported offloads 0x%" PRIx64, (void *)dev, tx_conf->offloads, dev->data->dev_conf.txmode.offloads, - dev_info.tx_offload_capa); } + dev_info.tx_offload_capa); + return -ENOTSUP; + } if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) { vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); -- 2.11.0