From: Tarun Vyas Subject: Re: [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update Date: Wed, 2 May 2018 11:19:14 -0700 Message-ID: <20180502181913.GA14677@otc-chromeosbuild-5> References: <20180430040018.79272-1-tarun.vyas@intel.com> <20180430171933.GI3617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF5AC6E58E for ; Wed, 2 May 2018 18:19:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180430171933.GI3617@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Deak@otc-chromeosbuild-5, Pandiyan@otc-chromeosbuild-5, Dhinakaran , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBcHIgMzAsIDIwMTggYXQgMTA6MTk6MzNBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFN1biwgQXByIDI5LCAyMDE4IGF0IDA5OjAwOjE4UE0gLTA3MDAsIFRhcnVuIFZ5 YXMgd3JvdGU6Cj4gPiBGcm9tOiBUYXJ1biA8dGFydW4udnlhc0BpbnRlbC5jb20+Cj4gPiAKPiA+ IFRoZSBQSVBFRFNMIGZyZWV6ZXMgb24gUFNSIGVudHJ5IGFuZCBpZiBQU1IgaGFzbid0IGZ1bGx5 IGV4aXRlZCwgdGhlbgo+ID4gdGhlIHBpcGVfdXBkYXRlX3N0YXJ0IGNhbGwgc2NoZWR1bGVzIGl0 c2VsZiBvdXQgdG8gY2hlY2sgYmFjayBsYXRlci4KPiA+IAo+ID4gT24gQ2hyb21lT1MtNC40IGtl cm5lbCwgd2hpY2ggaXMgZmFpcmx5IHVwLXRvLWRhdGUgdy5yLnQgZHJtL2k5MTUgYnV0Cj4gPiBs YWdzIHcuci50IGNvcmUga2VybmVsIGNvZGUsIGhvdCBwbHVnZ2luZyBhbiBleHRlcm5hbCBkaXNw bGF5IHRyaWdnZXJzCj4gPiB0b25zIG9mICJwb3RlbnRpYWwgYXRvbWljIHVwZGF0ZSBlcnJvcnMi IGluIHRoZSBkbWVzZywgb24gKnBpcGUgQSouIEEKPiA+IGNsb3NlciBhbmFseXNpcyByZXZlYWxz IHRoYXQgd2UgdHJ5IHRvIHJlYWQgdGhlIHNjYW5saW5lIDMgdGltZXMgYW5kCj4gPiBldmVudHVh bGx5IHRpbWVvdXQsIGIvYyBQU1IgaGFzbid0IGV4aXRlZCBmdWxseSBsZWFkaW5nIHRvIGEgUElQ RURTTAo+ID4gc3R1Y2sgQCAxNTk5LiBUaGlzIGlzc3VlIGlzIG5vdCBzZWVuIG9uIHVwc3RyZWFt IGtlcm5lbHMsIGIvYyBmb3IgKnNvbWUqCj4gPiByZWFzb24gd2UgbG9vcCBpbnNpZGUgaW50ZWxf cGlwZV91cGRhdGUgc3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGluIHRoaXMKPiA+IGNhc2UgaXMg bW9yZSB0aGFuIGVub3VnaCB0byBleGl0IFBTUiBmdWxseSwgaGVuY2UgYW4gKnVuc3R1Y2sqIFBJ UEVEU0wKPiA+IGNvdW50ZXIsIGhlbmNlIG5vIGVycm9yLiBPbiB0aGUgb3RoZXIgaGFuZCwgdGhl IENocm9tZU9TIGtlcm5lbCBzcGVuZHMKPiA+IH4xLjEgbXNlYyBsb29waW5nIGluc2lkZSBpbnRl bF9waXBlX3VwZGF0ZV9zdGFydCBhbmQgaGVuY2UgZXJyb3JzIG91dAo+ID4gYi9jIHRoZSBzb3Vy Y2UgaXMgc3RpbGwgaW4gUFNSLgo+ID4gCj4gPiBSZWdhcmRsZXNzLCB3ZSBzaG91bGQgd2FpdCBm b3IgUFNSIGV4aXQgKGlmIFBTUiBpcyBzdXBwb3J0ZWQgYW5kIGFjdGl2ZQo+ID4gb24gdGhlIGN1 cnJlbnQgcGlwZSkgYmVmb3JlIHJlYWRpbmcgdGhlIFBJUEVEU0wsIGIvYyBpZiB3ZSBoYXZlbid0 Cj4gPiBmdWxseSBleGl0ZWQgUFNSLCB0aGVuIGNoZWNraW5nIGZvciB2YmxhbmsgZXZhc2lvbiBp c24ndCBhY3R1YWxseQo+ID4gYXBwbGljYWJsZS4KPiA+IAo+ID4gVGhpcyBzY2VuYXJpbyBhcHBs aWVzIHRvIGEgY29uZmlndXJhdGlvbiB3aXRoIGFuIGFkZGl0aW9uYWwgcGlwZSwKPiA+IGFzIG9m IG5vdy4KPiAKPiBJIGhvbmVzdGx5IGJlbGlldmUgeW91IHBpY2tpbmcgdGhlIHdyb25nIGN1bHBy aXQgaGVyZS4gQnkgImNvaW5jaWRlbmNlIi4KPiBQU1Igd2lsbCBhbGxvdyBEQyBzdGF0ZSB3aXRo IHNjcmVlbiBvbiBhbmQgREMgc3RhdGUgd2lsbCBtZXNzIHVwIHdpdGggYWxsCj4gcmVnaXN0ZXJz IHJlYWRzLi4uLgo+IAo+IHByb2JhYmx5IHdoYXQgeW91IGFyZSBtaXNzaW5nIHlvdSB5b3VyIGtl cm5lbCBpcyBzb21lIHBvd2VyIGRvbWFpbgo+IGdyYWIgdGhhdCB3b3VsZCBrZWVwIERDX09GRiBh bmQgY29uc2VxdWVudGx5IGEgc2FuZSByZWFkIG9mIHRoZXNlCj4gcmVnaXN0ZXJzLgo+IAo+IE1h eWJlIEltcmUgaGFzIGEgcXVpY2sgaWRlYSBvZiB3aGF0IHlvdSBjb3VsZCBiZSBtaXNzaW5nIG9u IHlvdXIga2VybmVsCj4gdGhhdCB3ZSBhbHJlYWR5IGhhdmUgb24gdXBzdHJlYW0gb25lLgo+IAo+ IFRoYW5rcywKPiBSb2RyaWdvLgo+ClRoYW5rcyBmb3IgdGhlIHF1aWNrIHJlc3BvbnNlIFJvZHJp Z28gIQpTb21lIGtleSBvYnNlcnZhdGlvbnMgYmFzZWQgb24gbXkgZXhwZXJpbWVudHMgc28gZmFy OgogICAgICAgZm9yICg7OykgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAvKiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAg ICAgICAgICAgICAgICAqIHByZXBhcmVfdG9fd2FpdCgpIGhhcyBhIG1lbW9yeSBiYXJyaWVyLCB3 aGljaCBndWFyYW50ZWVzICAgICAgIAogICAgICAgICAgICAgICAgICogb3RoZXIgQ1BVcyBjYW4g c2VlIHRoZSB0YXNrIHN0YXRlIHVwZGF0ZSBieSB0aGUgdGltZSB3ZSAgICAgICAgCiAgICAgICAg ICAgICAgICAgKiByZWFkIHRoZSBzY2FubGluZS4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAqLyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAg ICAgcHJlcGFyZV90b193YWl0KHdxLCAmd2FpdCwgVEFTS19VTklOVEVSUlVQVElCTEUpOyAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgIHNj YW5saW5lID0gaW50ZWxfZ2V0X2NydGNfc2NhbmxpbmUoY3J0Yyk7ICAgICAgICAgICAgICAgICAg ICAgICAgIAogICAgICAgICAgICAgICAgaWYgKHNjYW5saW5lIDwgbWluIHx8IHNjYW5saW5lID4g bWF4KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgaWYgKHRpbWVvdXQg PD0gMCkgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAg ICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiUG90ZW50aWFsIGF0b21pYyB1cGRhdGUg ZmFpbHVyZSBvbiBwaXBlICVjXG4iLCAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHBpcGVfbmFtZShjcnRjLT5waXBlKSk7ICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAg ICAgICAgICAgICAgICAgICBicmVhazsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICB9ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgbG9jYWxfaXJxX2VuYWJsZSgpOyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAKICAgICAgICAgICAgICAgIHRpbWVvdXQgPSBzY2hlZHVsZV90aW1lb3V0KHRpbWVv dXQpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICBsb2NhbF9pcnFfZGlzYWJsZSgpOyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICB9CjEuIEluIHRoZSBhYm92ZSBs b29wIGluc2lkZSBwaXBlX3VwZGF0ZV9zdGFydCwgdGhlICpmaXJzdCB0aW1lKiwgd2UgcmVhZCB0 aGUgUElQRURTTCwgd2l0aCBQU1IxIGFuZCBleHRlcm5hbCBkaXNwbGF5IGNvbm5lY3RlZCwgaXQg YWx3YXlzIHJlYWRzIDE1OTksIGZvciAqYm90aCogdGhlIGtlcm5lbHModXBzdHJlYW0gYW5kIENo cm9tZU9TLTQuNCkgLiBUaGUgUFNSX1NUQVRVUyBhbHNvIHJlYWRzIHRoZSBleGFjdCBzYW1lIGZv ciAqYm90aCoga2VybmVscyBhbmQgc2hvd3MgdGhhdCB3ZSBoYXZlbid0ICpmdWxseSogZXhpdGVk IFBTUi4KCjIuIFRoZSBkaWZmZXJlbmNlIGJldHdlZW4gdGhlIHR3byBrZXJuZWxzIGNvbWVzIGFm dGVyIHRoaXMgZmlyc3QgcmVhZCBvZiB0aGUgUElQRURTTC4gQ2hyb21lT1MtNC40IHNwZW5kcyB+ MSBtc2VjIGluc2lkZSB0aGF0IGxvb3AgYW5kIHVwc3RyZWFtIHNwZW5kcyB+Mm1zZWMuIEkgc3Vz cGVjdCB0aGF0IGl0IGlzIGJlY2F1c2Ugb2YgdGhlIHNjaGVkdWxpbmcgY2hhbmdlcyBiZXR3ZWVu IHRoZSB0d28ga2VybmVscywgYi9jIEkgY2FuJ3QgZmluZCBhbnkgaTkxNSBzcGVjaWZpYyBjb2Rl IHJ1bm5pbmcgaW4gdGhhdCBsb29wLCBleGNlcHQgZm9yIHZibGFuayBwcm9jZXNzaW5nLgoKMy4g U28gdG8gc3VtbWFyaXplIGl0LCBib3RoIHRoZSBrZXJuZWxzIGFyZSBpbiB0aGUgc2FtZSBzdGF0 ZSB3LnIudCBQU1IgYW5kIFBJUEVEU0wgdmFsdWUgd2hlbiB0aGV5IHJlYWQgdGhlIFBJUEVEU0wg Zm9yIHRoZSBmaXJzdCB0aW1lIGluc2lkZSB0aGUgbG9vcC4gKldoZW4qIHRoZSBrZXJuZWxzICp0 cmFuc2l0aW9uKiB0byBhICpmdWxsIFBTUiBleGl0KiBpcyB3aGF0IGlzIGRpZmZlcmluZy4KCk15 IHJhdGlvbmFsZSBmb3IgdGhpcyBwYXRjaCBpcyB0aGF0LCB0aGUgcGlwZV91cGRhdGVfc3RhcnQg ZnVuY3Rpb24gaXMgbWVhbnQgdG8gZXZhZGUgMTAwIHVzZWMgYmVmb3JlIGEgdmJsYW5rLCBidXQs ICppZiogd2UgaGF2ZW4ndCAqZnVsbHkqIGV4aXRlZCBQU1IgKHdoaWNoIGlzIHRydWUgZm9yIGJv dGggdGhlIGtlcm5lbHMgZm9yIHRoZSBmaXJzdCBQSVBFRFNMIHJlYWQpLCB0aGVuIHZibGFuayBl dmFzaW9uIGlzICpub3QgYXBwbGljYWJsZSogYi9jIHRoZSBQSVBFRFNMIHdpbGwgYmUgbWVzc2Vk IHVwLiBTbyB3ZSBzaG91bGRuJ3QgYm90aGVyIGV2YWRpbmcgdmJsYW5rIHVudGlsIHdlIGhhdmUg ZnVsbHkgZXhpdGVkIFBTUi4KClRoYW5rcywKVGFydW4KPiA+IAo+ID4gLS0tCj4gPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCA3ICsrKysrLS0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gaW5kZXggYWExZGZhYTY5MmI5Li4xMzViNDE1Njg1MDMg MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+IEBAIC0xMDcsMTQg KzEwNywxNyBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiA+ICAJCQkJCQkgICAgICBWQkxBTktfRVZB U0lPTl9USU1FX1VTKTsKPiA+ICAJbWF4ID0gdmJsYW5rX3N0YXJ0IC0gMTsKPiA+ICAKPiA+IC0J bG9jYWxfaXJxX2Rpc2FibGUoKTsKPiA+IC0KPiA+ICAJaWYgKG1pbiA8PSAwIHx8IG1heCA8PSAw KQo+ID4gIAkJcmV0dXJuOwo+ID4gIAo+ID4gIAlpZiAoV0FSTl9PTihkcm1fY3J0Y192Ymxhbmtf Z2V0KCZjcnRjLT5iYXNlKSkpCj4gPiAgCQlyZXR1cm47Cj4gPiAgCj4gPiArCWlmKG5ld19jcnRj X3N0YXRlLT5oYXNfcHNyICYmIGRldl9wcml2LT5wc3IuYWN0aXZlKQo+ID4gKwkJaW50ZWxfd2Fp dF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIEVEUF9QU1JfU1RBVFVTLCBFRFBfUFNSX1NUQVRVU19T VEFURV9NQVNLLCBFRFBfUFNSX1NUQVRVU19TVEFURV9JRExFLCA1KTsKPiA+ICsKPiA+ICsJbG9j YWxfaXJxX2Rpc2FibGUoKTsKPiA+ICsKPiA+ICAJY3J0Yy0+ZGVidWcubWluX3ZibCA9IG1pbjsK PiA+ICAJY3J0Yy0+ZGVidWcubWF4X3ZibCA9IG1heDsKPiA+ICAJdHJhY2VfaTkxNV9waXBlX3Vw ZGF0ZV9zdGFydChjcnRjKTsKPiA+IC0tIAo+ID4gMi4xMy41Cj4gPiAKPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK