Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33682 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbeEBSvY (ORCPT ); Wed, 2 May 2018 14:51:24 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w42IoITA142109 for ; Wed, 2 May 2018 14:51:23 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hqg4u7gx4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 02 May 2018 14:51:23 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 May 2018 14:51:22 -0400 From: Murilo Opsfelder Araujo To: muriloo@linux.ibm.com Cc: stable@vger.kernel.org, Alexander Shishkin , Andi Kleen , Arnaldo Carvalho de Melo , David Carrillo-Cisneros , Greg Kroah-Hartman , He Kuang , Ingo Molnar , Jiri Olsa , Masami Hiramatsu , Paul Mackerras , Paul Turner , Peter Zijlstra , Sasha Levin , Simon Que , Stephane Eranian , Wang Nan Subject: [PATCH 3.18 v3] perf session: Fix undeclared 'oe' Date: Wed, 2 May 2018 15:50:44 -0300 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20180502185044.23646-1-muriloo@linux.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: Using linux-3.18.y branch, perf build fails with the following: $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all [...] util/session.c: In function ‘__perf_session__process_pipe_events’: util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function) ordered_events__set_copy_on_queue(oe, true); ^ util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in This patch fixes it for linux-3.18.y branch. Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode") Cc: # 3.18.x Cc: Alexander Shishkin Cc: Andi Kleen Cc: Arnaldo Carvalho de Melo Cc: David Carrillo-Cisneros Cc: Greg Kroah-Hartman Cc: He Kuang Cc: Ingo Molnar Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Paul Mackerras Cc: Paul Turner Cc: Peter Zijlstra Cc: Sasha Levin Cc: Simon Que Cc: Stephane Eranian Cc: Wang Nan Signed-off-by: Murilo Opsfelder Araujo --- Hi, Greg. Perf build on linux-3.18.y is broken since v3.18.101 (v3.18.100 worked just fine). This fixes it. Changes since v2: - rebased on v3.18.108 tools/perf/util/session.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index dc3d3b1b813e..c2d4a7ec40df 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1073,6 +1073,7 @@ volatile int session_done; static int __perf_session__process_pipe_events(struct perf_session *session, struct perf_tool *tool) { + struct ordered_events *oe = &session->ordered_events; int fd = perf_data_file__fd(session->file); union perf_event *event; uint32_t size, cur_size = 0; -- 2.14.3