From: Tom Rini Date: Thu, 17 May 2018 08:02:42 -0400 Subject: [U-Boot] [PATCH] net: MVGBE don't automatically select PHYLIB In-Reply-To: <0b99b4cb-465f-696e-1555-9fea05039ef3@denx.de> References: <20180517090315.30371-1-judge.packham@gmail.com> <20180517110946.GA9871@bill-the-cat.ec.rr.com> <0b99b4cb-465f-696e-1555-9fea05039ef3@denx.de> Message-ID: <20180517120242.GC9871@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Thu, May 17, 2018 at 01:59:36PM +0200, Stefan Roese wrote: > On 17.05.2018 13:53, Chris Packham wrote: > > > > > >On Thu, 17 May 2018, 11:09 PM Tom Rini, >> wrote: > > > > On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote: > > > Not all users of MVGBE need PHYLIB and it increases the size of the > > > openrd images too much. > > > > > > Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE") > > > Signed-off-by: Chris Packham > > > > > Cc: Tom Rini > > > > Cc: Stefan Roese > > > > --- > > > > > >  drivers/net/Kconfig | 1 - > > >  1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > > > index c962d7a72c0c..f2cc75f494e8 100644 > > > --- a/drivers/net/Kconfig > > > +++ b/drivers/net/Kconfig > > > @@ -181,7 +181,6 @@ config FTMAC100 > > >  config MVGBE > > >       bool "Marvell Orion5x/Kirkwood network interface support" > > >       depends on KIRKWOOD || ORION5X > > > -     select PHYLIB > > >       help > > >         This driver supports the network interface units in the > > >         Marvell Orion5x and Kirkwood SoCs > > > > This results in phylib never being set now as the configs were getting > > it implicitly.  Do any of the boards need it? > > > > > >I compile tested the affected boards and they all build. I've fired this > >at github and should have some travis results soon. > > > >My mistake was to copy the mvneta kconfig which had the select. Commit > >ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB > >lines so if they need it it's already in the board.h file or selected > >somewhere else. > > Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for > MVGBE") selected PHYLIB via Kconfig, which changed the configuration > for these Kirkwood boards. *If* some of them needed / selected PHYLIB > before this patch, it was most likely done in their config header. > > So this patch restores the board configuration again. PHYLIB is not > needed for MVGBE - it compiles without it as well. OK, thanks. Can you please do a v2 with a commit message that reflects this and a Fixes tag? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: