From: Tarun Vyas Subject: Re: [PATCH 1/2] drm/i915: Modify psr_wait_for_idle to be reused. Date: Thu, 17 May 2018 13:35:55 -0700 Message-ID: <20180517203555.GA65280@otc-chromeosbuild-5> References: <20180514204922.82073-1-tarun.vyas@intel.com> <152633251911.18532.12845710278597901479@mail.alporthouse.com> <20180514220015.GA194720@otc-chromeosbuild-5> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C21A6EB29 for ; Thu, 17 May 2018 20:35:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180514220015.GA194720@otc-chromeosbuild-5> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXkgMTQsIDIwMTggYXQgMDM6MDA6MTVQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBPbiBNb24sIE1heSAxNCwgMjAxOCBhdCAxMDoxNToxOVBNICswMTAwLCBDaHJpcyBXaWxz b24gd3JvdGU6Cj4gPiBRdW90aW5nIFRhcnVuIFZ5YXMgKDIwMTgtMDUtMTQgMjE6NDk6MjApCj4g PiA+IGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0IGFsc28gbmVlZHMgdG8gd2FpdCBmb3IgUFNSIHRv IGlkbGUKPiA+ID4gb3V0LiBOZWVkIHNvbWUgbWlub3IgbW9kaWZpY2F0aW9ucyBpbiBwc3Jfd2Fp dF9mb3JfaWRsZSBpbgo+ID4gPiBvcmRlciB0byByZXVzZSBpdC4KPiA+ID4gCj4gPiA+IENjOiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+ID4gU2lnbmVkLW9mZi1i eTogVGFydW4gVnlhcyA8dGFydW4udnlhc0BpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCAyOSArKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDExIGRlbGV0 aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gaW5kZXgg ZGIyN2YyZmFhMWRlLi40MGFhZmMwZjQ1MTMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Bzci5jCj4gPiA+IEBAIC04ODksMTEgKzg4OSwxNSBAQCBzdGF0aWMgYm9vbCBwc3Jfd2Fp dF9mb3JfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ICAgICAg ICAgaTkxNV9yZWdfdCByZWc7Cj4gPiA+ICAgICAgICAgdTMyIG1hc2s7Cj4gPiA+ICAgICAgICAg aW50IGVycjsKPiA+ID4gKyAgICAgICBib29sIHdhaXQgPSBmYWxzZTsKPiA+ID4gKwo+ID4gPiAr ICAgICAgIG11dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gPiA+ICAKPiA+ID4gICAg ICAgICBpbnRlbF9kcCA9IGRldl9wcml2LT5wc3IuZW5hYmxlZDsKPiA+ID4gICAgICAgICBpZiAo IWludGVsX2RwKQo+ID4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ID4gPiArICAg ICAgICAgICAgICAgZ290byB1bmxvY2s7Cj4gPiA+ICAKPiA+ID4gKyAgICAgICB3YWl0ID0gdHJ1 ZTsKPiA+ID4gICAgICAgICBpZiAoSEFTX0RESShkZXZfcHJpdikpIHsKPiA+ID4gICAgICAgICAg ICAgICAgIGlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+ID4gPiAgICAgICAgICAg ICAgICAgICAgICAgICByZWcgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gPiA+IEBAIC05MTEsMTUgKzkx NSwxOCBAQCBzdGF0aWMgYm9vbCBwc3Jfd2FpdF9mb3JfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiA+ICAgICAgICAgICAgICAgICBtYXNrID0gVkxWX0VEUF9QU1Jf SU5fVFJBTlM7Cj4gPiA+ICAgICAgICAgfQo+ID4gPiAgCj4gPiA+ICt1bmxvY2s6Cj4gPiA+ICAg ICAgICAgbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ID4gPiAgCj4gPiA+IC0g ICAgICAgZXJyID0gaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIHJlZywgbWFzaywg MCwgNTApOwo+ID4gPiAtICAgICAgIGlmIChlcnIpCj4gPiA+IC0gICAgICAgICAgICAgICBEUk1f RVJST1IoIlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBmb3IgcmUtZW5hYmxlXG4iKTsK PiA+ID4gKyAgICAgICBpZih3YWl0KSB7Cj4gPiA+ICsgICAgICAgICAgICAgICBlcnIgPSBpbnRl bF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwgcmVnLCBtYXNrLCAwLCA1MCk7Cj4gPiA+ICsg ICAgICAgICAgICAgICBpZiAoZXJyKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIERS TV9FUlJPUigiVGltZWQgb3V0IHdhaXRpbmcgZm9yIFBTUiBJZGxlIGZvciByZS1lbmFibGVcbiIp Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICB3YWl0ID0gZmFsc2U7Cj4gPiA+ICsgICAg ICAgICAgICAgICB9Cj4gPiA+ICsgICAgICAgfQo+ID4gPiAgCj4gPiA+IC0gICAgICAgLyogQWZ0 ZXIgdGhlIHVubG9ja2VkIHdhaXQsIHZlcmlmeSB0aGF0IFBTUiBpcyBzdGlsbCB3YW50ZWQhICov Cj4gPiA+IC0gICAgICAgbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiA+ID4gLSAg ICAgICByZXR1cm4gZXJyID09IDAgJiYgZGV2X3ByaXYtPnBzci5lbmFibGVkOwo+ID4gPiArICAg ICAgIHJldHVybiB3YWl0Owo+IEkgd2FudGVkIHRvIGF2b2lkIHRha2luZyB0aGlzIGFkZGl0aW9u YWwgbG9jayBiL2MgYWxsIHdlIG5lZWQgaW5zaWRlIGludGVsX3BpcGVfdXBkYXRlX3N0YXJ0IGlz IGZvciBQU1IgdG8gZ28gaWRsZS4gU28gY2FuIHdlIHJldGFpbiBtb3ZpbmcgaXQgdG8gaW50ZWxf cHNyX3dvcmsgPwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF9wc3Jf d29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gPiA+IEBAIC05MjcsNyArOTM0LDYgQEAg c3RhdGljIHZvaWQgaW50ZWxfcHNyX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4g PiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9Cj4gPiA+ICAgICAg ICAgICAgICAgICBjb250YWluZXJfb2Yod29yaywgdHlwZW9mKCpkZXZfcHJpdiksIHBzci53b3Jr LndvcmspOwo+ID4gPiAgCj4gPiA+IC0gICAgICAgbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBzci5s b2NrKTsKPiA+ID4gIAo+ID4gPiAgICAgICAgIC8qCj4gPiA+ICAgICAgICAgICogV2UgaGF2ZSB0 byBtYWtlIHN1cmUgUFNSIGlzIHJlYWR5IGZvciByZS1lbmFibGUKPiA+ID4gQEAgLTkzNiwxNCAr OTQyLDE1IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bzcl93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAq d29yaykKPiA+ID4gICAgICAgICAgKiBhbmQgYmUgcmVhZHkgZm9yIHJlLWVuYWJsZS4KPiA+ID4g ICAgICAgICAgKi8KPiA+ID4gICAgICAgICBpZiAoIXBzcl93YWl0X2Zvcl9pZGxlKGRldl9wcml2 KSkKPiA+ID4gLSAgICAgICAgICAgICAgIGdvdG8gdW5sb2NrOwo+ID4gPiArICAgICAgICAgICAg ICAgcmV0dXJuOwo+ID4gPiAgCj4gPiA+IC0gICAgICAgLyoKPiA+ID4gKyAgICAgICAvKiBBZnRl ciB0aGUgdW5sb2NrZWQgd2FpdCwgdmVyaWZ5IHRoYXQgUFNSIGlzIHN0aWxsIHdhbnRlZCEKPiA+ ID4gICAgICAgICAgKiBUaGUgZGVsYXllZCB3b3JrIGNhbiByYWNlIHdpdGggYW4gaW52YWxpZGF0 ZSBoZW5jZSB3ZSBuZWVkIHRvCj4gPiA+ICAgICAgICAgICogcmVjaGVjay4gU2luY2UgcHNyX2Zs dXNoIGZpcnN0IGNsZWFycyB0aGlzIGFuZCB0aGVuIHJlc2NoZWR1bGVzIHdlCj4gPiA+ICAgICAg ICAgICogd29uJ3QgZXZlciBtaXNzIGEgZmx1c2ggd2hlbiBiYWlsaW5nIG91dCBoZXJlLgo+ID4g PiAgICAgICAgICAqLwo+ID4gPiAtICAgICAgIGlmIChkZXZfcHJpdi0+cHNyLmJ1c3lfZnJvbnRi dWZmZXJfYml0cykKPiA+ID4gKyAgICAgICBtdXRleF9sb2NrKCZkZXZfcHJpdi0+cHNyLmxvY2sp Owo+ID4gPiArICAgICAgIGlmIChkZXZfcHJpdi0+cHNyLmVuYWJsZWQgJiYgZGV2X3ByaXYtPnBz ci5idXN5X2Zyb250YnVmZmVyX2JpdHMpCj4gPiA+ICAgICAgICAgICAgICAgICBnb3RvIHVubG9j azsKPiA+IAo+ID4gSSdtIG5vdCBzb2xkIG9uIHRoZSBsb2NraW5nIGRyb3BwaW5nIGhlcmUsIGRv aW5nIHNvIGluc2lkZSB0aGUgd2FpdCBpcwo+ID4gYmFkIGVub3VnaC4gKEFuZCBkbyB3ZSBuZWVk IHRvIHRoZXJlIGFueXdheT8pCj4gPiAKUGVyIHRoZSBjb21taXQgbWVzc2FnZSBpbiAiZGFlYjcy NWUgZHJtL2k5MTUvcHNyOiBDaGFzZSBwc3IuZW5hYmxlZCBvbmx5IHVuZGVyIHRoZSBwc3IubG9j ayIsCnRoZSB3YWl0X2Zvcl9yZWdpc3RlciBpcyBkb25lIGFmdGVyIGRyb3BwaW5nIHRoZSBsb2Nr cyBzbyB0aGF0IHdlIGRvbid0IGJsb2NrIHRoZSBtb2Rlc2V0IHBhdGguCj4gPiBTaW5jZSB5b3Ug bmVlZCB0byBpbnRyb2R1Y2UgaW50ZWxfcHNyX3dhaXRfZm9yX2lkbGUoKSBhbnl3YXksIGhvdyBh Ym91dAo+ID4gCj4gPiB2b2lkIGludGVsX3Bzcl93YWl0X2Zvcl9pZGxlKC4uLikKPiA+IHsKPiA+ IAltdXRleF9sb2NrKCZpOTE1LT5wc3IubG9jayk7Cj4gPiAJcHNyX3dhaXRfZm9yX2lkbGUoKTsK PiA+IAltdXRleF91bmxvY2soJmk5MTUtPnBzci5sb2NrKTsKT24gYSBzZWNvbmQgdGhvdWdodCwg SSBuZWVkIHRvIHdhaXQgZm9yIFBTUiBpZGxlIGluc2lkZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFy dC4gTm93LCBpbnRlbF9wc3JfZGlzYWJsZS9pbnRlbF9wc3JfZW5hYmxlIHdpbGwKKm5vdCByYWNl KiBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoKSwgc28gd2UgZG8gbm90IG5lZWQgYW55 IHBzci5sb2NrcywgYXQgYWxsLgpUaGUgbG9ja2luZyBkcm9wcGluZyBpbnNpZGUgcHNyX3dhaXRf Zm9yX2lkbGUgbWFrZXMgaXQgZGlmZmljdWx0IHRvIG1vdmUgdGhlIGNvbW1vbiB3YWl0IGNvZGUs IHNvIEkgd2FzIHRoaW5raW5nIGlmIEkgY2FuIGRvCnNvbWV0aGluZyBsaWtlOgp2b2lkIGludGVs X3Bzcl93YWl0X2Zvcl9pZGxlKC4uLikKewoJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVk KSB7CgkJcmVnID0gRURQX1BTUjJfU1RBVFVTOwoJCW1hc2sgPSBFRFBfUFNSMl9TVEFUVVNfU1RB VEVfTUFTSzsKCX0gZWxzZSB7CgkJcmVnID0gRURQX1BTUl9TVEFUVVM7CgkJbWFzayA9IEVEUF9Q U1JfU1RBVFVTX1NUQVRFX01BU0s7Cgl9CgkKCWludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9w cml2LCByZWcsIG1hc2ssIDAsIDI1KTsKfQp3aGljaCBpcyBlc3NlbnRpYWxseSBhIGxvY2tsZXNz IHZlcnNpb24gb2YgcHNyX3dhaXRfZm9yX2lkbGUoKS4gU28sIHRoZXJlIGlzIGNvZGUgZHVwbGlj YXRpb24gaGVyZSwgYnV0IEkgY2FuJ3QgaGVscCBpdC4KCkFueSB0aG91Z2h0cyA/Cj4gPiB9Cj4g PiAtQ2hyaXMKPiA+PiAgICAgICAgLyogQWZ0ZXIgdGhlIHVubG9ja2VkIHdhaXQsIHZlcmlmeSB0 aGF0IFBTUiBpcyBzdGlsbCB3YW50ZWQhICovCj4gPj4JbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBz ci5sb2NrKTsgCj4gPj4JcmV0dXJuIGVyciA9PSAwICYmIGRldl9wcml2LT5wc3IuZW5hYmxlZDsg Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=