From: Haneen Mohammed Subject: [PATCH v3] drm: Add checks for NULL drm_connector_helper_funcs Date: Fri, 1 Jun 2018 01:10:24 +0300 Message-ID: <20180531221024.GA8016@haneen-vb> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E4F789C9C for ; Thu, 31 May 2018 22:10:36 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id x2-v6so49066465wmh.5 for ; Thu, 31 May 2018 15:10:36 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: rodrigosiqueiramelo@gmail.com, David Airlie , daniel.vetter@ffwll.ch List-Id: dri-devel@lists.freedesktop.org VGhpcyBwYXRjaCBhZGQgY2hlY2tzIGZvciBOVUxMIGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNz CnBvaW50ZXJzIGJlZm9yZSBkZXJlZnJlbmNpbmcgdGhlIHZhcmlhYmxlIHRvIGF2b2lkIE5VTEwg cG9pbnRlcgpkZXJlZmVyZW5jZSBhbmQgbWFrZSB0aGUgaGVscGVyIGZ1bmN0aW9uIG9wdGlvbmFs IGluIHRoZSBmb2xsb3dpbmcKY2FzZXM6CgoxKSB3aGVuIHVzaW5nIGRybV9oZWxwZXJfcHJvYmVf c2luZ2xlX2Nvbm5lY3Rvcl9tb2RlcyBmb3IgZmlsbF9tb2RlcwpjYWxsYmFjayBpbiB0aGUgZHJt X2Nvbm5lY3Rvcl9mdW5jcy4KMikgdXNpbmcgZHJtX2F0b21pY19oZWxwZXJfY2hlY2sgZm9yIGF0 b21pY19jaGVjayBjYWxsYmFja3MgaW4gdGhlCmRybV9tb2RlX2NvbmZpZ19mdW5jcy4KClRoZSBk ZXBlbmRlbmN5IGlzIGFzIGZvbGxvdzoKCmRybV9jb25uZWN0b3JfZnVuY3M6CiogZmlsbF9tb2Rl cyA9IGRybV9oZWxwZXJfcHJvYmVfc2luZ2xlX2Nvbm5lY3Rvcl9tb2RlcwoJYikgZHJtX2hlbHBl cl9wcm9iZV9kZXRlY3QKCmRybV9tb2RlX2NvbmZpZ19mdW5jOgoqIGF0b21pY19jaGVjayA9IGRy bV9hdG9taWNfaGVscGVyX2NoZWNrCglhKSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0 CglhKSBoYW5kbGVfY29uZmxpY3RpbmdfZW5jb2RlcnMKCWMpIHVwZGF0ZV9jb25uZWN0b3Jfcm91 dGluZwoKU2lnbmVkLW9mZi1ieTogSGFuZWVuIE1vaGFtbWVkIDxoYW1vaGFtbWVkLnNhQGdtYWls LmNvbT4KLS0tCkNoYW5nZXMgaW4gdjM6Ci0gYWRkIGNoZWNrcyBmb3IgZHJtX2Nvbm5lY3Rvcl9o ZWxwZXJfZnVuY3Mgb25seSBzaW5jZSBwbGFuZS9jcnRjIAogIGhlbHBlciBmdW5jcyBhcmUgbmVj ZXNzYXJ5IGZvciBhIGZ1bmN0aW9uYWwgZHJpdmVyCgpDaGFuZ2VzIGluIHYyOgotIGFkZCB0aGUg bGVhc3QgYW1vdW50IG9mIGNoZWNrcyB0byBtYWtlIHRoZSBoZWxwZXJzIG9wdGlvbmFsIGZvciB2 a21zCgogZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCAxMCArKysrKy0tLS0t CiBkcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jICB8ICA1ICsrKy0tCiAyIGZpbGVz IGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCmluZGV4IDJhN2NlY2E4MmI5ZS4uMDY1ZTdmZTFmOTc5IDEwMDY0NAot LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwpAQCAtMTEyLDkgKzExMiw5IEBAIHN0YXRpYyBpbnQg aGFuZGxlX2NvbmZsaWN0aW5nX2VuY29kZXJzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSwKIAkJaWYgKCFuZXdfY29ubl9zdGF0ZS0+Y3J0YykKIAkJCWNvbnRpbnVlOwogCi0JCWlmIChm dW5jcy0+YXRvbWljX2Jlc3RfZW5jb2RlcikKKwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5hdG9taWNf YmVzdF9lbmNvZGVyKQogCQkJbmV3X2VuY29kZXIgPSBmdW5jcy0+YXRvbWljX2Jlc3RfZW5jb2Rl cihjb25uZWN0b3IsIG5ld19jb25uX3N0YXRlKTsKLQkJZWxzZSBpZiAoZnVuY3MtPmJlc3RfZW5j b2RlcikKKwkJZWxzZSBpZiAoZnVuY3MgJiYgZnVuY3MtPmJlc3RfZW5jb2RlcikKIAkJCW5ld19l bmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwogCQllbHNlCiAJCQluZXdf ZW5jb2RlciA9IGRybV9hdG9taWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwpAQCAt MzA4LDEwICszMDgsMTAgQEAgdXBkYXRlX2Nvbm5lY3Rvcl9yb3V0aW5nKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSwKIAogCWZ1bmNzID0gY29ubmVjdG9yLT5oZWxwZXJfcHJpdmF0ZTsK IAotCWlmIChmdW5jcy0+YXRvbWljX2Jlc3RfZW5jb2RlcikKKwlpZiAoZnVuY3MgJiYgZnVuY3Mt PmF0b21pY19iZXN0X2VuY29kZXIpCiAJCW5ld19lbmNvZGVyID0gZnVuY3MtPmF0b21pY19iZXN0 X2VuY29kZXIoY29ubmVjdG9yLAogCQkJCQkJCSBuZXdfY29ubmVjdG9yX3N0YXRlKTsKLQllbHNl IGlmIChmdW5jcy0+YmVzdF9lbmNvZGVyKQorCWVsc2UgaWYgKGZ1bmNzICYmIGZ1bmNzLT5iZXN0 X2VuY29kZXIpCiAJCW5ld19lbmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25uZWN0b3Ip OwogCWVsc2UKIAkJbmV3X2VuY29kZXIgPSBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIo Y29ubmVjdG9yKTsKQEAgLTYzOSw3ICs2MzksNyBAQCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19t b2Rlc2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiAJCQkJbmV3X2NydGNfc3RhdGUtPmNvbm5l Y3RvcnNfY2hhbmdlZCA9IHRydWU7CiAJCX0KIAotCQlpZiAoZnVuY3MtPmF0b21pY19jaGVjaykK KwkJaWYgKGZ1bmNzICYmIGZ1bmNzLT5hdG9taWNfY2hlY2spCiAJCQlyZXQgPSBmdW5jcy0+YXRv bWljX2NoZWNrKGNvbm5lY3RvciwgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7CiAJCWlmIChyZXQpCiAJ CQlyZXR1cm4gcmV0OwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxw ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKaW5kZXggNTI3NzQzMzk0 MTUwLi4yZmVhNTRkMTZlYmIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVf aGVscGVyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwpAQCAtMzIw LDcgKzMyMCw3IEBAIGRybV9oZWxwZXJfcHJvYmVfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IsCiAJaWYgKHJldCkKIAkJcmV0dXJuIHJldDsKIAotCWlmIChmdW5jcy0+ZGV0 ZWN0X2N0eCkKKwlpZiAoZnVuY3MgJiYgZnVuY3MtPmRldGVjdF9jdHgpCiAJCXJldHVybiBmdW5j cy0+ZGV0ZWN0X2N0eChjb25uZWN0b3IsIGN0eCwgZm9yY2UpOwogCWVsc2UgaWYgKGNvbm5lY3Rv ci0+ZnVuY3MtPmRldGVjdCkKIAkJcmV0dXJuIGNvbm5lY3Rvci0+ZnVuY3MtPmRldGVjdChjb25u ZWN0b3IsIGZvcmNlKTsKQEAgLTQ4MCw3ICs0ODAsOCBAQCBpbnQgZHJtX2hlbHBlcl9wcm9iZV9z aW5nbGVfY29ubmVjdG9yX21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCiAJ CWdvdG8gcHJ1bmU7CiAJfQogCi0JY291bnQgPSAoKmNvbm5lY3Rvcl9mdW5jcy0+Z2V0X21vZGVz KShjb25uZWN0b3IpOworCWlmIChjb25uZWN0b3JfZnVuY3MgJiYgY29ubmVjdG9yX2Z1bmNzLT5n ZXRfbW9kZXMpCisJCWNvdW50ID0gKCpjb25uZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29ubmVj dG9yKTsKIAogCWlmIChjb3VudCA9PSAwICYmIGNvbm5lY3Rvci0+c3RhdHVzID09IGNvbm5lY3Rv cl9zdGF0dXNfY29ubmVjdGVkKQogCQljb3VudCA9IGRybV9hZGRfbW9kZXNfbm9lZGlkKGNvbm5l Y3RvciwgMTAyNCwgNzY4KTsKLS0gCjIuMTcuMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==