From: Peter Zijlstra Subject: Re: [PATCH v9 04/12] perf/x86/intel/pt: add new capability for Intel PT Date: Thu, 7 Jun 2018 15:51:03 +0200 Message-ID: <20180607135103.GN12198@hirez.programming.kicks-ass.net> References: <1526964735-16566-1-git-send-email-luwei.kang@intel.com> <1526964735-16566-5-git-send-email-luwei.kang@intel.com> <20180607134051.rwu5pqtz45cgq7ve@um.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Luwei Kang , kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, chao.p.peng@linux.intel.com, thomas.lendacky@amd.com, bp@suse.de, Kan.liang@intel.com, Janakarajan.Natarajan@amd.com, dwmw@amazon.co.uk, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, pbonzini@redhat.com, rkrcmar@redhat.com, david@redhat.com, bsd@redhat.com, yu.c.zhang@linux.intel.com, joro@8bytes.org To: Alexander Shishkin Return-path: Content-Disposition: inline In-Reply-To: <20180607134051.rwu5pqtz45cgq7ve@um.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Jun 07, 2018 at 04:40:51PM +0300, Alexander Shishkin wrote: > On Tue, May 22, 2018 at 12:52:07PM +0800, Luwei Kang wrote: > > CPUID(EAX=14H,ECX=0):EBX[bit 3] = 1 indicates support of > > output to Trace Transport subsystem. > > MSR IA32_RTIT_CTL.FabricEn[bit 6] is reserved if > > CPUID.(EAX=14H, ECX=0):ECX[bit 3] = 0. > > This should instead say: > > This adds support for "output to Trace Transport subsystem" capability > of Intel PT, as documented in IA SDM Chapter 36.x.y.z. It means that > PT can output its trace to an MMIO address range rather than system > memory buffer. The $subject also needs attention.