Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA657210FCF41 for ; Thu, 7 Jun 2018 15:31:23 -0700 (PDT) From: Ross Zwisler Subject: [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Date: Thu, 7 Jun 2018 16:31:08 -0600 Message-Id: <20180607223111.27792-2-ross.zwisler@linux.intel.com> In-Reply-To: <20180607223111.27792-1-ross.zwisler@linux.intel.com> References: <20180607223111.27792-1-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Michael S. Tsirkin" Cc: Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov List-ID: Currently if "make check" detects a mismatch in the ASL generated during testing, we print an error such as: acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl, aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-DTWVJZ.dsl, aml:tests/acpi-test-data/q35/SSDT.dimmpxm]. but the testing still exits with good shell status. This is wrong, and makes bisecting such a failure difficult. Signed-off-by: Ross Zwisler --- tests/bios-tables-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 256d463cb8..9b5db1ee8f 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -469,6 +469,7 @@ static void test_acpi_asl(test_data *data) } } } + g_test_fail(); } g_string_free(asl, true); g_string_free(exp_asl, true); -- 2.14.4 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm