Return-Path: Received: from mx2.suse.de ([195.135.220.15]:56905 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517AbeFKKUI (ORCPT ); Mon, 11 Jun 2018 06:20:08 -0400 Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 85EADACF0 for ; Mon, 11 Jun 2018 10:20:07 +0000 (UTC) From: Jan Kara To: Cc: Jan Kara Subject: [PATCH] quota: Cleanup list iteration in dqcache_shrink_scan() Date: Mon, 11 Jun 2018 12:20:02 +0200 Message-Id: <20180611102002.28488-1-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Use list_first_entry() and list_empty() instead of opencoded variants. Signed-off-by: Jan Kara --- fs/quota/dquot.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) I plan to add this patch to my tree. Review is welcome. diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 241b00f835b9..fc20e06c56ba 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -711,21 +711,18 @@ EXPORT_SYMBOL(dquot_quota_sync); static unsigned long dqcache_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct list_head *head; struct dquot *dquot; unsigned long freed = 0; spin_lock(&dq_list_lock); - head = free_dquots.next; - while (head != &free_dquots && sc->nr_to_scan) { - dquot = list_entry(head, struct dquot, dq_free); + while (!list_empty(&free_dquots) && sc->nr_to_scan) { + dquot = list_first_entry(&free_dquots, struct dquot, dq_free); remove_dquot_hash(dquot); remove_free_dquot(dquot); remove_inuse(dquot); do_destroy_dquot(dquot); sc->nr_to_scan--; freed++; - head = free_dquots.next; } spin_unlock(&dq_list_lock); return freed; -- 2.13.7