Return-Path: Received: from gum.cmpxchg.org ([85.214.110.215]:54120 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933223AbeFKOGj (ORCPT ); Mon, 11 Jun 2018 10:06:39 -0400 Date: Mon, 11 Jun 2018 10:08:58 -0400 From: Johannes Weiner To: Josef Bacik Cc: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tj@kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 07/13] memcontrol: schedule throttling if we are congested Message-ID: <20180611140858.GB1507@cmpxchg.org> References: <20180605132948.1664-1-josef@toxicpanda.com> <20180605132948.1664-8-josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180605132948.1664-8-josef@toxicpanda.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jun 05, 2018 at 09:29:42AM -0400, Josef Bacik wrote: > From: Tejun Heo > > Memory allocations can induce swapping via kswapd or direct reclaim. If > we are having IO done for us by kswapd and don't actually go into direct > reclaim we may never get scheduled for throttling. So instead check to > see if our cgroup is congested, and if so schedule the throttling. > Before we return to user space the throttling stuff will only throttle > if we actually required it. > > Signed-off-by: Tejun Heo Looks good to me now, thanks. Acked-by: Johannes Weiner