From: Boris Brezillon Subject: Re: [PATCH] drm/atmel-hlcdc: remove unnecessary if statement Date: Sun, 17 Jun 2018 09:50:33 +0200 Message-ID: <20180617095033.515bd531@bbrezillon> References: <20170807062650.9863-1-stefan@agner.ch> <041e4264a89b5d8ab748f6dc3bf501db@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id DD9856E301 for ; Sun, 17 Jun 2018 07:50:35 +0000 (UTC) In-Reply-To: <041e4264a89b5d8ab748f6dc3bf501db@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: maxime.ripard@bootlin.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAxNyBKdW4gMjAxOCAwMTozNDozNCArMDIwMApTdGVmYW4gQWduZXIgPHN0ZWZhbkBh Z25lci5jaD4gd3JvdGU6Cgo+IEJvcmlzLCBNYXhpbWUsCj4gCj4gT24gMDcuMDguMjAxNyAwODoy NiwgU3RlZmFuIEFnbmVyIHdyb3RlOgo+ID4gVGhlIHN0YXRlbWVudCBhbHdheXMgZXZhbHVhdGVz IHRvIHRydWUgc2luY2UgdGhlIHN0cnVjdCBmaWVsZHMKPiA+IGFyZSBhcnJheXMuIFRoaXMgaGFz IHNob3duIHVwIGFzIGEgd2FybmluZyB3aGVuIGNvbXBpbGluZyB3aXRoCj4gPiBjbGFuZzoKPiA+ ICAgd2FybmluZzogYWRkcmVzcyBvZiBhcnJheSAnZGVzYy0+bGF5b3V0LnhzdHJpZGUnIHdpbGwg YWx3YXlzCj4gPiAgICAgICBldmFsdWF0ZSB0byAndHJ1ZScgWy1XcG9pbnRlci1ib29sLWNvbnZl cnNpb25dICAKPiAKPiBJdCBzZWVtcyB0aGF0IHRoaXMgcGF0Y2ggbmV2ZXIgbWFkZSBpdCB1cHN0 cmVhbS4gSXQgc3RpbGwgcHJvZHVjZXMgYQo+IHdhcm5pbmcgd2hlbiBidWlsZGluZyB3aXRoIGNs YW5nLiBNYXliZSB5b3UgY291bGQgaGF2ZSBhIGxvb2sgYW5kIHF1ZXVlPwoKT29wcywgc29ycnks IEkgbWlzc2VkIHRoYXQgb25lLgoKPiAKPiAtLQo+IFN0ZWZhbgo+IAo+ID4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBTdGVmYW4gQWduZXIgPHN0ZWZhbkBhZ25lci5jaD4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19wbGFuZS5jIHwgMjEgKysrKysrKysr LS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTIgZGVs ZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxj ZGMvYXRtZWxfaGxjZGNfcGxhbmUuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMv YXRtZWxfaGxjZGNfcGxhbmUuYwo+ID4gaW5kZXggMTEyNDIwMGJiMjgwLi45YmQ4YzQ4ODgwMzUg MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRtZWxfaGxjZGNf cGxhbmUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hsY2Rj X3BsYW5lLmMKPiA+IEBAIC04NTQsMjQgKzg1NCwyMSBAQCBzdGF0aWMgaW50Cj4gPiBhdG1lbF9o bGNkY19wbGFuZV9pbml0X3Byb3BlcnRpZXMoc3RydWN0IGF0bWVsX2hsY2RjX3BsYW5lICpwbGFu ZSwKPiA+ICAJCQkJc3RydWN0IGF0bWVsX2hsY2RjX3BsYW5lX3Byb3BlcnRpZXMgKnByb3BzKQo+ ID4gIHsKPiA+ICAJY29uc3Qgc3RydWN0IGF0bWVsX2hsY2RjX2xheWVyX2Rlc2MgKmRlc2MgPSBw bGFuZS0+bGF5ZXIuZGVzYzsKPiA+ICsJaW50IHJldDsKPiA+ICAKPiA+ICAJaWYgKGRlc2MtPnR5 cGUgPT0gQVRNRUxfSExDRENfT1ZFUkxBWV9MQVlFUiB8fAo+ID4gIAkgICAgZGVzYy0+dHlwZSA9 PSBBVE1FTF9ITENEQ19DVVJTT1JfTEFZRVIpCj4gPiAgCQlkcm1fb2JqZWN0X2F0dGFjaF9wcm9w ZXJ0eSgmcGxhbmUtPmJhc2UuYmFzZSwKPiA+ICAJCQkJCSAgIHByb3BzLT5hbHBoYSwgMjU1KTsK PiA+ICAKPiA+IC0JaWYgKGRlc2MtPmxheW91dC54c3RyaWRlICYmIGRlc2MtPmxheW91dC5wc3Ry aWRlKSB7CgpUaGUgdGVzdCBzaG91bGQgYmUgCgoJaWYgKGRlc2MtPmxheW91dC54c3RyaWRlWzBd ICYmIGRlc2MtPmxheW91dC5wc3RyaWRlWzBdKQoKQ2FuIHlvdSBzZW5kIGEgbmV3IHZlcnNpb24g d2l0aCB0aGlzIGNoYW5nZT8KCj4gPiAtCQlpbnQgcmV0Owo+ID4gLQo+ID4gLQkJcmV0ID0gZHJt X3BsYW5lX2NyZWF0ZV9yb3RhdGlvbl9wcm9wZXJ0eSgmcGxhbmUtPmJhc2UsCj4gPiAtCQkJCQkJ CSBEUk1fTU9ERV9ST1RBVEVfMCwKPiA+IC0JCQkJCQkJIERSTV9NT0RFX1JPVEFURV8wIHwKPiA+ IC0JCQkJCQkJIERSTV9NT0RFX1JPVEFURV85MCB8Cj4gPiAtCQkJCQkJCSBEUk1fTU9ERV9ST1RB VEVfMTgwIHwKPiA+IC0JCQkJCQkJIERSTV9NT0RFX1JPVEFURV8yNzApOwo+ID4gLQkJaWYgKHJl dCkKPiA+IC0JCQlyZXR1cm4gcmV0Owo+ID4gLQl9Cj4gPiArCXJldCA9IGRybV9wbGFuZV9jcmVh dGVfcm90YXRpb25fcHJvcGVydHkoJnBsYW5lLT5iYXNlLAo+ID4gKwkJCQkJCSBEUk1fTU9ERV9S T1RBVEVfMCwKPiA+ICsJCQkJCQkgRFJNX01PREVfUk9UQVRFXzAgfAo+ID4gKwkJCQkJCSBEUk1f TU9ERV9ST1RBVEVfOTAgfAo+ID4gKwkJCQkJCSBEUk1fTU9ERV9ST1RBVEVfMTgwIHwKPiA+ICsJ CQkJCQkgRFJNX01PREVfUk9UQVRFXzI3MCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlyZXR1cm4g cmV0Owo+ID4gIAo+ID4gIAlpZiAoZGVzYy0+bGF5b3V0LmNzYykgewo+ID4gIAkJLyogIAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==