From: Daniel Vetter Subject: Re: [PATCH] drm/i915/crt: make intel_crt_reset() static again Date: Thu, 28 Jun 2018 08:45:09 +0200 Message-ID: <20180628064509.GL13978@phenom.ffwll.local> References: <20180621130330.20219-1-jani.nikula@intel.com> <20180621140033.GO20518@intel.com> <87o9fwtpnv.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F2A96EC03 for ; Thu, 28 Jun 2018 06:45:13 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id c1-v6so4478565edt.2 for ; Wed, 27 Jun 2018 23:45:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87o9fwtpnv.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Lyude List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMjcsIDIwMTggYXQgMDI6NDk6NDBQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAyMSBKdW4gMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUaHUsIEp1biAyMSwgMjAxOCBhdCAwNDow MzozMFBNICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+PiBDb21taXQgOTUwNGE4OTI0NzU5 ICgiZHJtL2k5MTUvdmx2OiBSZXNldCB0aGUgQURQQSBpbgo+ID4+IHZsdl9kaXNwbGF5X3Bvd2Vy X3dlbGxfaW5pdCgpIikgc3RhcnRlZCBjYWxsaW5nIGludGVsX2NydF9yZXNldCgpCj4gPj4gZGly ZWN0bHksIHdoaWxlIHdlIGNvdWxkIGp1c3QgYXMgd2VsbCB1c2UgdGhlIGhvb2tzIGFuZCBrZWVw IHRoZQo+ID4+IGZ1bmN0aW9uIHN0YXRpYy4KPiA+PiAKPiA+PiBDYzogTHl1ZGUgPGNwYXVsQHJl ZGhhdC5jb20+Cj4gPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMg ICAgICAgIHwgMiArLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAg ICAgfCAxIC0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwg MiArLQo+ID4+ICAzIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwo+ID4+IGluZGV4IDBjNmJmODJi YjA1OS4uYzJjYjNiN2EyNTViIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2NydC5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMK PiA+PiBAQCAtODgxLDcgKzg4MSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0X2dldF9tb2Rlcyhz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ID4+ICAJcmV0dXJuIHJldDsKPiA+PiAg fQo+ID4+ICAKPiA+PiAtdm9pZCBpbnRlbF9jcnRfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICpl bmNvZGVyKQo+ID4+ICtzdGF0aWMgdm9pZCBpbnRlbF9jcnRfcmVzZXQoc3RydWN0IGRybV9lbmNv ZGVyICplbmNvZGVyKQo+ID4+ICB7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmRldik7Cj4gPj4gIAlzdHJ1Y3QgaW50ZWxfY3J0ICpj cnQgPSBpbnRlbF9lbmNvZGVyX3RvX2NydCh0b19pbnRlbF9lbmNvZGVyKGVuY29kZXIpKTsKPiA+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4+IGluZGV4IDBjM2FjMGVhZmRlMC4uYjIwMDJm ZWUxYjU4IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+PiBAQCAtMTM3 Myw3ICsxMzczLDYgQEAgdm9pZCBnZW45X2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+PiAgYm9vbCBpbnRlbF9jcnRfcG9ydF9lbmFi bGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+PiAgCQkJICAgIGk5MTVf cmVnX3QgYWRwYV9yZWcsIGVudW0gcGlwZSAqcGlwZSk7Cj4gPj4gIHZvaWQgaW50ZWxfY3J0X2lu aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+PiAtdm9pZCBpbnRlbF9j cnRfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiA+PiAgCj4gPj4gIC8qIGlu dGVsX2RkaS5jICovCj4gPj4gIHZvaWQgaW50ZWxfZGRpX2ZkaV9wb3N0X2Rpc2FibGUoc3RydWN0 IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIsCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3J1bnRpbWVfcG0uYwo+ID4+IGluZGV4IGRlM2E4MTAzNGY3Ny4uMGIzZGE1ODE4MzgzIDEw MDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4+IEBA IC05NzIsNyArOTcyLDcgQEAgc3RhdGljIHZvaWQgdmx2X2Rpc3BsYXlfcG93ZXJfd2VsbF9pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+PiAgCS8qIFJlLWVuYWJsZSB0 aGUgQURQQSwgaWYgd2UgaGF2ZSBvbmUgKi8KPiA+PiAgCWZvcl9lYWNoX2ludGVsX2VuY29kZXIo JmRldl9wcml2LT5kcm0sIGVuY29kZXIpIHsKPiA+PiAgCQlpZiAoZW5jb2Rlci0+dHlwZSA9PSBJ TlRFTF9PVVRQVVRfQU5BTE9HKQo+ID4+IC0JCQlpbnRlbF9jcnRfcmVzZXQoJmVuY29kZXItPmJh c2UpOwo+ID4+ICsJCQllbmNvZGVyLT5iYXNlLmZ1bmNzLT5yZXNldCgmZW5jb2Rlci0+YmFzZSk7 Cj4gPgo+ID4gSSBoYXZlIGEgZmVlbGluZyBJIHJlcXVlc3RlZCB0aGUgZGlyZWN0IGNhbGwgdG8g bWFrZSBpdCBsZXNzIGFubm95aW5nIHRvCj4gPiBmaWd1cmUgb3V0IHdoYXQgaXQncyBhY3R1YWxs eSBjYWxsaW5nLiBCdXQgaWYgcGVvcGxlIHByZWZlciB0aGUgZnVuY3Rpb24KPiA+IHBvaW50ZXIg dmVyc2lvbiBJIGNhbiBsaXZlIHdpdGggdGhhdCB0b28uCj4gCj4gVHJ1ZSB0aGF0LCBidXQgSSB0 aG91Z2h0IHRoZSBkaXJlY3QgY2FsbCB3YXMgYSBsYXllcmluZyB2aW9sYXRpb24uCj4gCj4gVG8g cHVzaCwgb3Igbm90IHRvIHB1c2gsIHRoYXQgaXMgdGhlIHF1ZXN0aW9uLgoKTGVtbWEgcGlsZSBt eSBiaWtlc2hlZCBvbiB0b3A6IEdpdmVuIHRoYXQgd2Ugc3BlY2lmaWNhbGx5IGZpbHRlciBmb3Ig dGhlCkNSVCBlbmNvZGVyIEkgdGhpbmsgYSBkaXJlY3QgY2FsbCBpcyBiZXR0ZXIgaGVyZSwgc2lu Y2UgYSBiaXQgbW9yZSBjbGVhcgp3aGF0J3MgZ29pbmcgb24uIGh3IG9jY2FzaW9uYWxseSBlbmNv dXJhZ3NlIGxheWVyaW5nIHZpb2xhdGlvbnMgLi4uCi1EYW5pZWwKCj4gCj4gQlIsCj4gSmFuaS4K PiAKPiA+Cj4gPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+Cj4gPj4gIAl9Cj4gPj4gIAo+ID4+ICAJaTkxNV9yZWRpc2FibGVf dmdhX3Bvd2VyX29uKGRldl9wcml2KTsKPiA+PiAtLSAKPiA+PiAyLjExLjAKPiAKPiAtLSAKPiBK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==