From: Anthony PERARD Subject: Re: [PATCH v3 14/31] libxl_qmp_ev: Introduce libxl__ev_qmp_start() to connect to QMP Date: Thu, 28 Jun 2018 12:28:06 +0100 Message-ID: <20180628112806.GG2052@perard.uk.xensource.com> References: <20180601143720.24637-1-anthony.perard@citrix.com> <20180601143720.24637-15-anthony.perard@citrix.com> <23347.43080.956159.713378@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fYV5u-0003Bo-53 for xen-devel@lists.xenproject.org; Thu, 28 Jun 2018 11:28:10 +0000 Content-Disposition: inline In-Reply-To: <23347.43080.956159.713378@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Ian Jackson Cc: xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjcsIDIwMTggYXQgMDQ6MDc6NTJQTSArMDEwMCwgSWFuIEphY2tzb24gd3Jv dGU6Cj4gQW50aG9ueSBQRVJBUkQgd3JpdGVzICgiW1BBVENIIHYzIDE0LzMxXSBsaWJ4bF9xbXBf ZXY6IEludHJvZHVjZSBsaWJ4bF9fZXZfcW1wX3N0YXJ0KCkgdG8gY29ubmVjdCB0byBRTVAiKToK PiA+IFRoaXMgaXMgYSBmaXJzdCBwYXRjaCB0byBpbXBsZW1lbnQgbGlieGxfX2V2X3FtcCwgaXQg b25seSBjb25uZWN0IHRvIHRoZQo+ID4gUU1QIHNvY2tldCBvZiBRRU1VIGFuZCByZWdpc3RlciBh IGNhbGxiYWNrIHRoYXQgZG9lcyBub3RoaW5nLgo+IC4uLgo+ID4gQEAgLTUwMyw2ICs1MDQsOSBA QCBzdHJ1Y3QgbGlieGxfX2N0eCB7Cj4gPiAgICAgIExJQlhMX0xJU1RfRU5UUlkobGlieGxfY3R4 KSBzaWdjaGxkX3VzZXJzX2VudHJ5Owo+ID4gIAo+ID4gICAgICBsaWJ4bF92ZXJzaW9uX2luZm8g dmVyc2lvbl9pbmZvOwo+ID4gKwo+ID4gKyAgICAvLyBGSVhNRTogTWF5IG5lZWQgYSBsaXN0LCB3 aXRoIG9uIHN0YXRlIGZvciBlYWNoIGRvbWlkCj4gPiArICAgIGxpYnhsX19ldl9xbXBfc3RhdGUg KnFtcF9ldjsKPiAKPiBNeSB0aG91Z2h0IGlzIHRoYXQgdGhlIGxpZmV0aW1lIG9mIHRoaXMgdGhp bmcgc2hvdWxkIHByb2JhYmx5IGJlIGluCj4gZWFjaCByZWxldmFudCBhby4KClRoYXQgc291bmQg cGxhdXNpYmxlLCBJIGNhbiB0cnkgdG8gbW92ZSB0aGlzIHN0YXRlIHRvIGxpYnhsX19hby4gSSBq dXN0Cm5lZWQgdG8gZmluZCBvdXQgd2hhdCdzIGhhcHBlbiBvbiBjb25uZWN0KDMpIHdoZW4gc29t ZXRoaW5nIGVsc2UgaXMKYWxscmVhZHkgY29ubmVjdGVkIHRvIFFFTVUuCgo+IElzIGl0IHRvbyBp bmNvbnZlbmllbnQgdG8gcmVjb25uZWN0IHRvIHFtcCBmb3IgZXZlcnkgbGlieGwgb3BlcmF0aW9u ID8KPiBJZiBpdCBpcyB0aGVuIHRoaXMgbmVlZHMgdG8gYmUgYSBjYWNoZSwgYSBiaXQgbGlrZSBs aWJ4bF9fcG9sbGVyIGJ1dAo+IGRpZmZlcmVudC4gIEJ1dCB0aGF0IGNhbiBiZSBoYW5kbGVkIGlu c2lkZSB3aGF0IHlvdSBhcmUgY2FsbGluZwo+IF9ldl9xbXBfc3RhcnQuCj4gCj4gQWxzbywgSSB0 aGluayBpZiB5b3UgYXJlIGdvaW5nIHRvIGhhdmUgYSBsaWJ4bF9fZXZfcW1wIGl0IG5lZWRzIHRv IGJlCj4ganVzdCBsaWtlIGFsbCB0aGUgb3RoZXIgbGlieGxfX2V2XyB0aGluZ3MuICBJdCdzIG5v dCBjbGVhciB0byBtZSB0aGF0Cj4gUU1QIGlzIHNpbWlsYXIgZW5vdWdoLgo+IAo+IERvIHlvdSBh Y3R1YWxseSBuZWVkIGFuIGV4cGxpY2l0ICJzdGFydCIgb3IgImNvbm5lY3QiIG9wZXJhdGlvbiA/ Cj4gSSB0aGluayBpbiBhbnkgY2FzZSB0aGUgInNlbmQgYSBxbXAgY29tbWFuZCIgb3BlcmF0aW9u cyBzaG91bGQKPiBwcm9iYWJseSBjb25uZWN0IGF1dG9tYXRpY2FsbHkuCgpUaGF0IGlzIHdoYXQg SSBoYXZlIGRvbmUuIFRoZSBsaWJ4bF9fZXZfcW1wX3N0YXJ0KCkgc2hvdWxkIGJlIHN0YXRpYywg aXQKaXMgb25seSB1c2UgZnJvbSB3aXRoaW4gbGlieGxfcW1wLmMuIEJ1dCBJJ3ZlIHB1dCBpdCBp biBsaWJ4bF9pbnRlcmFsLmgKanVzdCB0byBhbGxvdyB0aGlzIHBhdGNoIHRvIGJ1aWxkLgoKVGhl IF9zdG9wIGlzIG5vcm1hbGx5IG5vdCBuZWVkZWQsIHRvIGJlIGNhbGxlZC4gSXQgaXMgYXV0b21h dGljYWxseQpjYWxsZWQgYXMgc29vbiBhcyB0aGVyZSBpcyBubyBtb3JlIFFNUCBjb21tYW5kIGlu IGZsaWdodCAoYWxsIGNvbW1hbmQKaGF2ZSByZWNldmVpZCBhIHJlc3BvbnNlKS4KCj4gU28gc29t ZXRoaW5nIGxpa2UgdGhpczoKPiAKPiAgICAvKiBsaWJ4bF9fcW1wX3N0YXRlIGhhcyB0aGUgZm9s bG93aW5nIHN0YXRlczoKPiAgICAgKiAgIFVuZGVmaW5lZAo+ICAgICAqICAgRGlzY29ubmVjdGVk Cj4gICAgICogICBDb25uZWN0ZWQKPiAgICAgKi8KPiAKPiAgICB2b2lkIGxpYnhsX19xbXBfaW5p dChpYnhsX19xbXBfc3RhdGUgKnFtcCk7IC8qIFUgLT4gRCAqLwo+IAo+ICAgIGludCBsaWJ4bF9f cW1wX2Nvbm5lY3QobGlieGxfX2djICpnYywgdWludDMyX3QgZG9taWQsCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICBsaWJ4bF9fcW1wX3N0YXRlICpxbXBfdXBkKTsgLyogW1VDXSAtPiBDICov Cj4gCj4gICAgaW50IGxpYnhsX19xbXBfZGlzcG9zZShsaWJ4bF9fcW1wX3N0YXRlICpxbXBfdXBk KTsgLyogW0RDXSAtPiBEICovCj4gCj4gICAgaW50IGxpYnhsX19xbXBfY29tbWFuZCggbG90cyBv ZiBwYXJhbWV0ZXJzIGluY2wgY2FsbGJhY2sgKTsgLyogW0RDXSAqLwoKU28gd2hhdCB0aGUgaW50 ZXJmYWNlIGxvb2tzIGxpa2UgYXQgdGhlIGVuZCBvZiB0aGUgc2VyaWVzIGlzOgoKdm9pZCBsaWJ4 bF9fZXZfcW1wX2luaXQobGlieGxfX2V2X3FtcCAqZXYpOwppbnQgbGlieGxfX2V2X3FtcF9yZWdp c3RlcihsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9fZXZfcW1wICpldiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgbGlieGxfX2V2X3FtcF9jYWxsYmFjayAqLAogICAgICAgICAgICAgICAgICAgICAg ICAgICB1aW50MzJfdCBkb21pZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hh ciAqY21kLCBsaWJ4bF9fanNvbl9vYmplY3QgKmFyZ3MpOwp2b2lkIGxpYnhsX19ldl9xbXBfZGVy ZWdpc3RlcihsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9fZXZfcW1wICpldik7CmludCBsaWJ4bF9fZXZf cW1wX2lzcmVnaXN0ZXJlZChjb25zdCBsaWJ4bF9fZXZfcW1wICpldik7CgpUaGUgbGlieGxfX3Ft cF9zdGF0ZSBpcyBub3QgZXhwb3NlZC4gVGhlIF9yZWdpc3RlcigpIHdpbGwgYXR0ZW1wdCB0bwpm aW5kIHRoZSBjdXJyZW50IF9zdGF0ZSBhbmQgdXNlIGl0LCBvciBjcmVhdGUgYSBuZXcgb25lIChj b25uZWN0KS4KClRoZSBsaWJ4bF9fZXZfcW1wX3N0b3AoKSBjYWxsIGluIGxpYnhsX2N0eF9mcmVl KCkgaXMgb25seSB0aGVyZSBpbiBjYXNlCnNvbWV0aGluZyB3ZW50IHdyb25nLCBpdCBzaG91bGQg bm90IGJlIG5lZWRlZC4KCgpJJ2xsIHRyeSB0byB3cml0ZSBiZXR0ZXIgZG9jdW1lbnRhdGlvbiBh Ym91dCB0aGUgcG9zc2libGUgc3RhdGVzIG9mIGJvdGgKbGlieGxfX2V2X3FtcF9zdGF0ZSBhbmQg bGlieGxfX2V2X3FtcCwgYW5kIGhvdyB0aGV5IHJlbGF0ZSB0byBlYWNoCm90aGVyLgoKQlRXLCBJ IHRoaW5rIHFtcCBpcyBraW5kIG9mIHNpbWlsYWlyIHRvIGxpYnhsX19ldl94c3dhdGNoLCB3aGlj aCB3b3VsZApfZXZfZmRfcmVnaXN0ZXIoeGVuc3RvcmVfZmQpIG9uIHRoZSBmaXJzdCBwYXRoIHRv IHdhdGNoLCBhbmQgX2RlcmVnaXN0ZXIKb25jZSB0aGVyZSBpcyBubyBtb3JlIHdhdGNoZXMuIFRo ZSBvbmUgbW9yZSB0aGluZyB0aGF0IHFtcCBuZWVkIHRvIGRvIGlzCm9wZW4gdGhlIHNvY2tldCBh bmQgY2xvc2UgaXQuCgotLSAKQW50aG9ueSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=