From: Daniel Vetter Subject: Re: [PATCH v2 3/9] drm: Add drm_connector_for_each_possible_encoder() Date: Thu, 28 Jun 2018 18:56:40 +0200 Message-ID: <20180628165640.GW13978@phenom.ffwll.local> References: <20180628131315.14156-1-ville.syrjala@linux.intel.com> <20180628131315.14156-4-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180628131315.14156-4-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMDQ6MTM6MDlQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEFkZCBhIGNvbnZlbmllbmNlIG1hY3JvIGZvciBpdGVyYXRpbmcgY29ubmVjdG9y LT5lbmNvZGVyX2lkc1tdLgo+IElzb2xhdGVzIHRoZSB1c2VycyBmcm9tIHRoZSBpbXBsZW1lbnRh dGlvbiBkZXRhaWxzLgo+IAo+IE5vdGUgdGhhdCB3ZSBkb24ndCBzZWVtIHRvIHBhc3MgdGhlIGZp bGVfcHJpdiBkb3duIHRvIGRybV9lbmNvZGVyX2ZpbmQoKQo+IGJlY2F1c2UgZW5jb2RlcnMgYXBw YXJlbnRseSBkb24ndCBnZXQgbGVhc2VkLiBObyBpZGVhIHdoeQo+IGRybV9lbmNvZGVyX2ZpbmMo KSBldmVuIHRha2VzIHRoZSBmaWxlX3ByaXYgYWN0dWFsbHkuCj4gCj4gQWxzbyB1c2UgQVJSQVlf U0laRSgpIHdoZW4gcG9wdWxhdGluZyB0aGUgYXJyYXkgdG8gYXZvaWQgc3ByZWFkaW5nCj4ga25v d2xlZGdlIGFib3V0IHRoZSBhcnJheSBzaXplIGFsbCBvdmVyLgo+IAo+IHYyOiBIaWRlIHRoZSBk cm1fZW5jb2Rlcl9maW5kKCkgaW4gdGhlIG1hY3JvLCBhbmQKPiAgICAgcmVuYW1lIHRoZSBtYWNy byBhcHByb3ByaWF0ZWx5IChEYW5pZWwpCj4gCj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gUmV2aWV3ZWQtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4gI3YxCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9j b25uZWN0b3IuYyAgICB8IDIxICsrKysrKysrKy0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX2ZiX2hlbHBlci5jICAgIHwgMTEgKystLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJt L2RybV9wcm9iZV9oZWxwZXIuYyB8IDEwICsrKy0tLS0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2Nv bm5lY3Rvci5oICAgICAgICB8IDEzICsrKysrKysrKysrKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCAy NyBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9y LmMKPiBpbmRleCAyZjllYmRkZDE3OGUuLjE4NmZlYmNmNGU1NSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9j b25uZWN0b3IuYwo+IEBAIC0zMjEsNyArMzIxLDcgQEAgaW50IGRybV9tb2RlX2Nvbm5lY3Rvcl9h dHRhY2hfZW5jb2RlcihzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJaWYgKFdB Uk5fT04oY29ubmVjdG9yLT5lbmNvZGVyKSkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQlm b3IgKGkgPSAwOyBpIDwgRFJNX0NPTk5FQ1RPUl9NQVhfRU5DT0RFUjsgaSsrKSB7Cj4gKwlmb3Ig KGkgPSAwOyBpIDwgQVJSQVlfU0laRShjb25uZWN0b3ItPmVuY29kZXJfaWRzKTsgaSsrKSB7Cj4g IAkJaWYgKGNvbm5lY3Rvci0+ZW5jb2Rlcl9pZHNbaV0gPT0gMCkgewo+ICAJCQljb25uZWN0b3It PmVuY29kZXJfaWRzW2ldID0gZW5jb2Rlci0+YmFzZS5pZDsKPiAgCQkJcmV0dXJuIDA7Cj4gQEAg LTE3MDgsMjIgKzE3MDgsMTkgQEAgaW50IGRybV9tb2RlX2dldGNvbm5lY3RvcihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJaWYgKCFjb25uZWN0b3IpCj4gIAkJcmV0dXJu IC1FTk9FTlQ7Cj4gIAo+IC0JZm9yIChpID0gMDsgaSA8IERSTV9DT05ORUNUT1JfTUFYX0VOQ09E RVI7IGkrKykKPiAtCQlpZiAoY29ubmVjdG9yLT5lbmNvZGVyX2lkc1tpXSAhPSAwKQo+IC0JCQll bmNvZGVyc19jb3VudCsrOwo+ICsJZHJtX2Nvbm5lY3Rvcl9mb3JfZWFjaF9wb3NzaWJsZV9lbmNv ZGVyKGNvbm5lY3RvciwgZW5jb2RlciwgaSkKPiArCQllbmNvZGVyc19jb3VudCsrOwo+ICAKPiAg CWlmICgob3V0X3Jlc3AtPmNvdW50X2VuY29kZXJzID49IGVuY29kZXJzX2NvdW50KSAmJiBlbmNv ZGVyc19jb3VudCkgewo+ICAJCWNvcGllZCA9IDA7Cj4gIAkJZW5jb2Rlcl9wdHIgPSAodWludDMy X3QgX191c2VyICopKHVuc2lnbmVkIGxvbmcpKG91dF9yZXNwLT5lbmNvZGVyc19wdHIpOwo+IC0J CWZvciAoaSA9IDA7IGkgPCBEUk1fQ09OTkVDVE9SX01BWF9FTkNPREVSOyBpKyspIHsKPiAtCQkJ aWYgKGNvbm5lY3Rvci0+ZW5jb2Rlcl9pZHNbaV0gIT0gMCkgewo+IC0JCQkJaWYgKHB1dF91c2Vy KGNvbm5lY3Rvci0+ZW5jb2Rlcl9pZHNbaV0sCj4gLQkJCQkJICAgICBlbmNvZGVyX3B0ciArIGNv cGllZCkpIHsKPiAtCQkJCQlyZXQgPSAtRUZBVUxUOwo+IC0JCQkJCWdvdG8gb3V0Owo+IC0JCQkJ fQo+IC0JCQkJY29waWVkKys7Cj4gKwo+ICsJCWRybV9jb25uZWN0b3JfZm9yX2VhY2hfcG9zc2li bGVfZW5jb2Rlcihjb25uZWN0b3IsIGVuY29kZXIsIGkpIHsKPiArCQkJaWYgKHB1dF91c2VyKGVu Y29kZXItPmJhc2UuaWQsIGVuY29kZXJfcHRyICsgY29waWVkKSkgewo+ICsJCQkJcmV0ID0gLUVG QVVMVDsKPiArCQkJCWdvdG8gb3V0Owo+ICAJCQl9Cj4gKwkJCWNvcGllZCsrOwo+ICAJCX0KPiAg CX0KPiAgCW91dF9yZXNwLT5jb3VudF9lbmNvZGVycyA9IGVuY29kZXJzX2NvdW50Owo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9mYl9oZWxwZXIuYwo+IGluZGV4IGIzN2YwNjMxN2Q1MS4uZDY5N2MxYzRhMDY3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTIzMjYsMTcgKzIzMjYsMTAgQEAgc3RhdGlj IGJvb2wgZHJtX3RhcmdldF9wcmVmZXJyZWQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBl ciwKPiAgc3RhdGljIGJvb2wgY29ubmVjdG9yX2hhc19wb3NzaWJsZV9jcnRjKHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJCQkJc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7 Cj4gKwlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gIAlpbnQgaTsKPiAgCj4gLQlmb3Ig KGkgPSAwOyBpIDwgRFJNX0NPTk5FQ1RPUl9NQVhfRU5DT0RFUjsgaSsrKSB7Cj4gLQkJc3RydWN0 IGRybV9lbmNvZGVyICplbmNvZGVyOwo+IC0KPiAtCQlpZiAoY29ubmVjdG9yLT5lbmNvZGVyX2lk c1tpXSA9PSAwKQo+IC0JCQlicmVhazsKPiAtCj4gLQkJZW5jb2RlciA9IGRybV9lbmNvZGVyX2Zp bmQoY29ubmVjdG9yLT5kZXYsIE5VTEwsCj4gLQkJCQkJICAgY29ubmVjdG9yLT5lbmNvZGVyX2lk c1tpXSk7Cj4gLQo+ICsJZHJtX2Nvbm5lY3Rvcl9mb3JfZWFjaF9wb3NzaWJsZV9lbmNvZGVyKGNv bm5lY3RvciwgZW5jb2RlciwgaSkgewo+ICAJCWlmIChlbmNvZGVyLT5wb3NzaWJsZV9jcnRjcyAm IGRybV9jcnRjX21hc2soY3J0YykpCj4gIAkJCXJldHVybiB0cnVlOwo+ICAJfQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9wcm9iZV9oZWxwZXIuYwo+IGluZGV4IDUyNzc0MzM5NDE1MC4uMWE5MDFmZTllMjNlIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gQEAgLTg4LDkgKzg4LDkgQEAgZHJt X21vZGVfdmFsaWRhdGVfcGlwZWxpbmUoc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCj4g IAkJCSAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gY29ubmVjdG9yLT5kZXY7Cj4gLQl1aW50MzJfdCAqaWRzID0gY29u bmVjdG9yLT5lbmNvZGVyX2lkczsKPiAgCWVudW0gZHJtX21vZGVfc3RhdHVzIHJldCA9IE1PREVf T0s7Cj4gLQl1bnNpZ25lZCBpbnQgaTsKPiArCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcjsK PiArCWludCBpOwo+ICAKPiAgCS8qIFN0ZXAgMTogVmFsaWRhdGUgYWdhaW5zdCBjb25uZWN0b3Ig Ki8KPiAgCXJldCA9IGRybV9jb25uZWN0b3JfbW9kZV92YWxpZChjb25uZWN0b3IsIG1vZGUpOwo+ IEBAIC05OCwxMyArOTgsOSBAQCBkcm1fbW9kZV92YWxpZGF0ZV9waXBlbGluZShzdHJ1Y3QgZHJt X2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAgCS8qIFN0ZXAgMjog VmFsaWRhdGUgYWdhaW5zdCBlbmNvZGVycyBhbmQgY3J0Y3MgKi8KPiAtCWZvciAoaSA9IDA7IGkg PCBEUk1fQ09OTkVDVE9SX01BWF9FTkNPREVSOyBpKyspIHsKPiAtCQlzdHJ1Y3QgZHJtX2VuY29k ZXIgKmVuY29kZXIgPSBkcm1fZW5jb2Rlcl9maW5kKGRldiwgTlVMTCwgaWRzW2ldKTsKPiArCWRy bV9jb25uZWN0b3JfZm9yX2VhY2hfcG9zc2libGVfZW5jb2Rlcihjb25uZWN0b3IsIGVuY29kZXIs IGkpIHsKPiAgCQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gIAo+IC0JCWlmICghZW5jb2RlcikK PiAtCQkJY29udGludWU7Cj4gLQo+ICAJCXJldCA9IGRybV9lbmNvZGVyX21vZGVfdmFsaWQoZW5j b2RlciwgbW9kZSk7Cj4gIAkJaWYgKHJldCAhPSBNT0RFX09LKSB7Cj4gIAkJCS8qIE5vIHBvaW50 IGluIGNvbnRpbnVpbmcgZm9yIGNydGMgY2hlY2sgYXMgdGhpcyBlbmNvZGVyCj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCBiL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0 b3IuaAo+IGluZGV4IDE0YWI1OGFkZTg3Zi4uOGRlM2EzYWE1MTZhIDEwMDY0NAo+IC0tLSBhL2lu Y2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jb25uZWN0 b3IuaAo+IEBAIC0xMTkzLDQgKzExOTMsMTcgQEAgdm9pZCBkcm1fY29ubmVjdG9yX2xpc3RfaXRl cl9lbmQoc3RydWN0IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyICppdGVyKTsKPiAgI2RlZmluZSBk cm1fZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29ubmVjdG9yLCBpdGVyKSBcCj4gIAl3aGlsZSAo KGNvbm5lY3RvciA9IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyX25leHQoaXRlcikpKQo+ICAKPiAr LyoqCj4gKyAqIGRybV9jb25uZWN0b3JfZm9yX2VhY2hfcG9zc2libGVfZW5jb2RlciAtIGl0ZXJh dGUgY29ubmVjdG9yJ3MgcG9zc2libGUgZW5jb2RlcnMKPiArICogQGNvbm5lY3RvcjogJnN0cnVj dCBkcm1fY29ubmVjdG9yIHBvaW50ZXIgdXNlZCBhcyBjdXJzb3IKPiArICogQGVuY29kZXI6IHRo ZSBlbmNvZGVyCgpJc24ndCB0aGlzIHRoZSBvdGhlciB3YXkgcm91bmQ/IGVuY29kZXIgaXMgdGhl IGN1cnNvciwgY29ubmVjdG9yIGlzIF90aGVfCmNvbm5lY3Rvcj8KCk90aGVyd2lzZSBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gYW5kIGFjayBmcm9t Cm1lIG9uIHRoZSBlbnRpcmUgc2VyaWVzLiBNdWNoIHByZXR0aWVyIQotRGFuaWVsCgo+ICsgKiBA X19pOiBpbnQgaXRlcmF0aW9uIGN1cnNvciwgZm9yIG1hY3JvLWludGVybmFsIHVzZQo+ICsgKi8K PiArI2RlZmluZSBkcm1fY29ubmVjdG9yX2Zvcl9lYWNoX3Bvc3NpYmxlX2VuY29kZXIoY29ubmVj dG9yLCBlbmNvZGVyLCBfX2kpIFwKPiArCWZvciAoKF9faSkgPSAwOyAoX19pKSA8IEFSUkFZX1NJ WkUoKGNvbm5lY3RvciktPmVuY29kZXJfaWRzKSAmJiBcCj4gKwkJICAgICAoY29ubmVjdG9yKS0+ ZW5jb2Rlcl9pZHNbKF9faSldICE9IDA7IChfX2kpKyspIFwKPiArCQlmb3JfZWFjaF9pZigoZW5j b2RlcikgPSBcCj4gKwkJCSAgICBkcm1fZW5jb2Rlcl9maW5kKChjb25uZWN0b3IpLT5kZXYsIE5V TEwsIFwKPiArCQkJCQkgICAgIChjb25uZWN0b3IpLT5lbmNvZGVyX2lkc1soX19pKV0pKSBcCj4g Kwo+ICAjZW5kaWYKPiAtLSAKPiAyLjE2LjQKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK