From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: Link modes representation in phylib
Date: Fri, 29 Jun 2018 15:43:43 +0200
Message-ID: <20180629134343.GE11285@lunn.ch>
References: <20180618170224.321f8264@bootlin.com>
 <20180618154018.GB5865@lunn.ch>
 <20180619113053.11df78a2@bootlin.com>
 <20180619152155.GC26796@lunn.ch>
 <20180629152613.43fcba8d@bootlin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net,
        Russell King - ARM Linux <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:47269 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935810AbeF2Nnt (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 29 Jun 2018 09:43:49 -0400
Content-Disposition: inline
In-Reply-To: <20180629152613.43fcba8d@bootlin.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Thanks for the suggestion. I see how this can be done with
> phydrv->supported and phydev->lp_advertising, however I'm not sure how
> we should deal with the fact that ethernet drivers directly access
> fields such as "advertising" or "supported".

Hi Maxime

I started cleaning up some of the MAC drivers. Take a look at

https://github.com/lunn/linux.git v4.18-rc1-net-next-phy-cleanup

That moved a lot of the MAC code into helpers, making it easier to
update. It might make sense to add a couple of more helpers, for what
remains.

	Andrew