From: Daniel Vetter Subject: Re: [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh Date: Mon, 2 Jul 2018 09:46:23 +0200 Message-ID: <20180702074623.GA13978@phenom.ffwll.local> References: <20180628194301.31694-1-ville.syrjala@linux.intel.com> <20180628194301.31694-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180628194301.31694-6-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjgsIDIwMTggYXQgMTA6NDM6MDFQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFdlIG9ubHkgZXZlciBkcml2ZSB0aGUgcGFuZWwgd2l0aCB0aGUgZml4ZWQgbW9k ZSwgaGVuY2Ugd2UgZG9uJ3QKPiB3YW50IHRvIGFkdmVydGl6ZSBhbnkgbW9kZXMgdGhhdCBoYXZl IGEgZGlmZmVyZW50IHZlcnRpY2FsIHJlZnJlc2ggcmF0ZS4KPiAKPiBXZSB0cmllZCB0byBhbGxv dyBhIHNlY29uZCBsb3dlciBjbG9ja2VkIG1vZGUgdG8gdXNlZCBmb3IgZURQIGJ1dAo+IHRoYXQg d2FzIHJldmVydGVkIGluIGNvbW1pdCBkOTNmYTFiNDdiOGYgKCJSZXZlcnQgImRybS9pOTE1L2Vk cDoKPiBBbGxvdyBhbHRlcm5hdGUgZml4ZWQgbW9kZSBmb3IgZURQIGlmIGF2YWlsYWJsZS4iIiku IFRvIGRvIHRoYXQgcHJvcGVybHkKPiBJIHRoaW5rIHdlIHNob3VsZCBwcm9iYWJseSBqdXN0IGtl ZXAgYWxsIChvciBqdXN0IHNvbWU/KSBvZiB0aGUgcHJvYmVkCj4gbW9kZXMgYXJvdW5kIChwcmVz dW1hYmx5IGFsbCBvZiB0aGVtIGFjdHVhbGx5IHdvcmsgaWYgdGhlIHBhbmVsCj4gYWR2ZXJ0aXpl cyB0aGVtKSwgYW5kIHdlJ2QganVzdCBwaWNrIHRoZSBjbG9zZXN0IG1hdGNoIGJhc2VkIG9uIHRo ZQo+IHVzZXIgbW9kZS4KPiAKPiBGb3Igbm93IHdlIGRvbid0IGhhdmUgYW55IG9mIHRoYXQgc28g d2Ugc2hvdWxkbid0IGxpZSB0byB0aGUgdXNlcgo+IHRoYXQgdGhleSBjYW4gZHJpdmUgdGhlIHBh bmVsIGF0IGRpZmZlcmVudCByZWZyZXNoIHJhdGUuIE5vdGUgdGhhdAo+IHdlIHN0aWxsIGRvbid0 IHJlamVjdCBhbnkgdXNlciBtb2RlIHdpdGggYmFkIHJlZnJlc2ggcmF0ZS4gVGhhdCdzCj4gZ29p bmcgdG8gYmUgc3RlcCB0d28uCj4gCj4gVE9ETzogU2hvdWxkIHdlIGFsbG93IGZvciBhIGxhcmdl ciBlcnJvciBtYXJnaW4/Cj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCk5vdCBzdXJlIHRoZSBjdXJyZW50IHZyZWZyZXNo IGlzIGFueSBnb29kLCBzaW5jZSBpdCdzIEhaIHJlc29sdXRpb24gb25seS4KVGhhdCdzIG5vdCBw cmVjaXNlIGVub3VnaCBmb3IgdGhlIHZpZGVvIGFmaWNpb25hZG9zLCB3aG8gaW5zaXN0IG9uIHRo YXQKZW50aXJlIDEwMDEvMTAwMCBidXNpbmVzcy4KCkkgZGlkIGxvb2sgYXJvdW5kIGEgYml0IHdp dGggYSBxdWljayBnaXQgZ3JlcCwgYW5kIG1vc3QgcGxhY2VzIG9ubHkgdXNlCi0+dnJlZnJlc2gg Zm9yIGRlYnVnIHByaW50aW5nLiBUaGVuIHRoZXJlJ3MgYSBmZXcgdGhhdCB1c2UgaXQgYXMgYW4g aW5kZXgKKGUuZy4gaTkxNSBEUlJTIGNvZGUpLCBhbmQgdGhlbiB0aGVyZSdzIHRoZSB0b3RhbGx5 IG1pc2d1aWRlZCBjb2RlIGluCmFkdjc1MTEgd2hpY2ggdGhpbmtzIHZyZWZyZXNoIGlzIGluIGtI ei4KClRoZXJlJ3MgYWxzbyBxdWl0ZSBhIHBpbGUgb2YgbW9kZS0+dnJlZnJlc2ggPyBtb2RlLT52 cmVmcmVzaCA6CmRybV9tb2RlX3ZyZWZyZXNoKG1vZGUpIGFyb3VuZCwgd2hpY2ggcmVhbGx5IGRv ZXNuJ3QgaW5zcGlyZSBjb25maWRlbmNlCnRoYXQgd2UnbGwgZXZlciBjYXRjaCB0aGVtIGFsbC4g SXQgZmVlbHMgbGlrZSB0aG9zZSAicmVjb21wdXRlIHZyZWZyZXNoIgp0aGluZ3MgaGF2ZSBiZWVu IGNhcmdvLWN1bHRlZCBmb3IgYWdlcy4KCkkgdGhpbmsgd2UgbmVlZCB0byBjbGVhbiB0aGlzIHVw IGhhcmRlcjoKLSBzd2l0Y2ggZXZlcnlvbmUgb3ZlciB0byBkcm1fbW9kZV92cmVmcmVzaCgpCi0g bnVrZSBkcm1fZGlzcGxheV9tb2RlLT52cmVmcmVzaAotIGFkZCBhIG5ldyBkcm1fbW9kZV92cmVm cmVzaF9tSHogKGZvciBtaWxsaS1IeiwgaS5lLiBmaXhlZCBwb2ludCBtYXRoCiAgZnR3KQotIHVz ZSB0aGF0IG5ldyBmdW5jdGlvbiBpbiB0aGUgbW9kZSBmaWx0ZXJpbmcsIHdpdGggYSBiaXQgb2Yg ZnVkZ2UgdGhhdAogIGtlZXBzIHRoZSAxMDAxLzEwMDAgbW9kZXMgc2VwYXJhdGUsIGJ1dCBwYXBl cnMgb3ZlciByb3VuZGluZyBlcnJvcnMuIEkKICB0aGluayB3ZSBjb3VsZCBldmVuIGRvIGEgZHJt X21vZGVfY29tcGFyZV92cmVmcmVzaCBmb3IgdGhhdCwgd2UncmUKICBwcm9iYWJseSBub3QgdGhl IG9ubHkgb25lcyB3aG8nZCBsaWtlIHRvIGhhdmUgc3VjaCBhIGZ1bmN0aW9uLgoKUHJvYmFibHkg YSBiaXQgbW9yZSB3b3JrIHRvIHR5cGUgKGJ1dCBjb2NjaSBtaWdodCBoZWxwIGhlcmUpLCBkZWZp bml0ZWx5Cmxlc3MgcGFpbmZ1bCB0byBtYWtlIHN1cmUgaXQgc3RheXMgY29ycmVjdCBJIHRoaW5r LiBUaG91Z2h0cz8KCkNoZWVycywgRGFuaWVsCgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYyAgIHwgMyArKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNp LmMgIHwgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYyAgfCAyICsrCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYyB8IDIgKysKPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2R2by5jIHwgMiArKwo+ICA1IGZpbGVzIGNoYW5nZWQsIDExIGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA1YmUwN2UxZDgxNmQu LjIyZmViMGIxNDRmNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC00NDYsNiAr NDQ2LDkgQEAgaW50ZWxfZHBfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yLAo+ICAJCWlmIChtb2RlLT52ZGlzcGxheSA+IGZpeGVkX21vZGUtPnZkaXNwbGF5KQo+ICAJ CQlyZXR1cm4gTU9ERV9QQU5FTDsKPiAgCj4gKwkJaWYgKG1vZGUtPnZyZWZyZXNoICE9IGZpeGVk X21vZGUtPnZyZWZyZXNoKQo+ICsJCQlyZXR1cm4gTU9ERV9QQU5FTDsKPiArCj4gIAkJdGFyZ2V0 X2Nsb2NrID0gZml4ZWRfbW9kZS0+Y2xvY2s7Cj4gIAl9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RzaS5jCj4gaW5kZXggM2I3YWNiNWE3MGIzLi4zZDA3NThjZWM4NWEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kc2kuYwo+IEBAIC0xMjc3LDYgKzEyNzcsOCBAQCBpbnRlbF9kc2lfbW9kZV92 YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQlyZXR1cm4gTU9ERV9Q QU5FTDsKPiAgCQlpZiAobW9kZS0+dmRpc3BsYXkgPiBmaXhlZF9tb2RlLT52ZGlzcGxheSkKPiAg CQkJcmV0dXJuIE1PREVfUEFORUw7Cj4gKwkJaWYgKG1vZGUtPnZyZWZyZXNoICE9IGZpeGVkX21v ZGUtPnZyZWZyZXNoKQo+ICsJCQlyZXR1cm4gTU9ERV9QQU5FTDsKPiAgCQlpZiAoZml4ZWRfbW9k ZS0+Y2xvY2sgPiBtYXhfZG90Y2xrKQo+ICAJCQlyZXR1cm4gTU9ERV9DTE9DS19ISUdIOwo+ICAJ fQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2R2by5jCj4gaW5kZXggNGUxNDJmZjQ5NzA4Li4wNzhiYjg0 OGE0OWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHZvLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYwo+IEBAIC0yMjUsNiArMjI1LDgg QEAgaW50ZWxfZHZvX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwK PiAgCQkJcmV0dXJuIE1PREVfUEFORUw7Cj4gIAkJaWYgKG1vZGUtPnZkaXNwbGF5ID4gZml4ZWRf bW9kZS0+dmRpc3BsYXkpCj4gIAkJCXJldHVybiBNT0RFX1BBTkVMOwo+ICsJCWlmIChtb2RlLT52 cmVmcmVzaCAhPSBmaXhlZF9tb2RlLT52cmVmcmVzaCkKPiArCQkJcmV0dXJuIE1PREVfUEFORUw7 Cj4gIAo+ICAJCXRhcmdldF9jbG9jayA9IGZpeGVkX21vZGUtPmNsb2NrOwo+ICAJfQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9sdmRzLmMKPiBpbmRleCBiYjA2NzQ0ZDI4YTQuLmQzMTJhODkxMWI4OSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiBAQCAtMzg0LDYgKzM4NCw4IEBAIGlu dGVsX2x2ZHNfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJ CXJldHVybiBNT0RFX1BBTkVMOwo+ICAJaWYgKG1vZGUtPnZkaXNwbGF5ID4gZml4ZWRfbW9kZS0+ dmRpc3BsYXkpCj4gIAkJcmV0dXJuIE1PREVfUEFORUw7Cj4gKwlpZiAobW9kZS0+dnJlZnJlc2gg IT0gZml4ZWRfbW9kZS0+dnJlZnJlc2gpCj4gKwkJcmV0dXJuIE1PREVfUEFORUw7Cj4gIAlpZiAo Zml4ZWRfbW9kZS0+Y2xvY2sgPiBtYXhfcGl4Y2xrKQo+ICAJCXJldHVybiBNT0RFX0NMT0NLX0hJ R0g7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBpbmRleCBjZDVkNWU4MDA0ODYu LjRiZTRiYWU1MTY1MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9z ZHZvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBAQCAtMTY1 MCw2ICsxNjUwLDggQEAgaW50ZWxfc2R2b19tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IsCj4gIAkJCXJldHVybiBNT0RFX1BBTkVMOwo+ICAKPiAgCQlpZiAobW9kZS0+ dmRpc3BsYXkgPiBmaXhlZF9tb2RlLT52ZGlzcGxheSkKPiArCj4gKwkJaWYgKG1vZGUtPnZyZWZy ZXNoICE9IGZpeGVkX21vZGUtPnZyZWZyZXNoKQo+ICAJCQlyZXR1cm4gTU9ERV9QQU5FTDsKPiAg CX0KPiAgCj4gLS0gCj4gMi4xNi40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==