From: Daniel Vetter Subject: Re: [PATCH 6/6] drm/i915: Filter out modes that don't match the fixed mode vrefresh Date: Tue, 3 Jul 2018 09:03:09 +0200 Message-ID: <20180703070309.GB7880@phenom.ffwll.local> References: <20180628194301.31694-1-ville.syrjala@linux.intel.com> <20180628194301.31694-6-ville.syrjala@linux.intel.com> <20180702074623.GA13978@phenom.ffwll.local> <20180702095231.GG5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180702095231.GG5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdWwgMDIsIDIwMTggYXQgMTI6NTI6MzFQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgSnVsIDAyLCAyMDE4IGF0IDA5OjQ2OjIzQU0gKzAyMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUaHUsIEp1biAyOCwgMjAxOCBhdCAxMDo0MzowMVBNICsw MzAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ID4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiAKPiA+ID4gV2Ugb25seSBldmVyIGRy aXZlIHRoZSBwYW5lbCB3aXRoIHRoZSBmaXhlZCBtb2RlLCBoZW5jZSB3ZSBkb24ndAo+ID4gPiB3 YW50IHRvIGFkdmVydGl6ZSBhbnkgbW9kZXMgdGhhdCBoYXZlIGEgZGlmZmVyZW50IHZlcnRpY2Fs IHJlZnJlc2ggcmF0ZS4KPiA+ID4gCj4gPiA+IFdlIHRyaWVkIHRvIGFsbG93IGEgc2Vjb25kIGxv d2VyIGNsb2NrZWQgbW9kZSB0byB1c2VkIGZvciBlRFAgYnV0Cj4gPiA+IHRoYXQgd2FzIHJldmVy dGVkIGluIGNvbW1pdCBkOTNmYTFiNDdiOGYgKCJSZXZlcnQgImRybS9pOTE1L2VkcDoKPiA+ID4g QWxsb3cgYWx0ZXJuYXRlIGZpeGVkIG1vZGUgZm9yIGVEUCBpZiBhdmFpbGFibGUuIiIpLiBUbyBk byB0aGF0IHByb3Blcmx5Cj4gPiA+IEkgdGhpbmsgd2Ugc2hvdWxkIHByb2JhYmx5IGp1c3Qga2Vl cCBhbGwgKG9yIGp1c3Qgc29tZT8pIG9mIHRoZSBwcm9iZWQKPiA+ID4gbW9kZXMgYXJvdW5kIChw cmVzdW1hYmx5IGFsbCBvZiB0aGVtIGFjdHVhbGx5IHdvcmsgaWYgdGhlIHBhbmVsCj4gPiA+IGFk dmVydGl6ZXMgdGhlbSksIGFuZCB3ZSdkIGp1c3QgcGljayB0aGUgY2xvc2VzdCBtYXRjaCBiYXNl ZCBvbiB0aGUKPiA+ID4gdXNlciBtb2RlLgo+ID4gPiAKPiA+ID4gRm9yIG5vdyB3ZSBkb24ndCBo YXZlIGFueSBvZiB0aGF0IHNvIHdlIHNob3VsZG4ndCBsaWUgdG8gdGhlIHVzZXIKPiA+ID4gdGhh dCB0aGV5IGNhbiBkcml2ZSB0aGUgcGFuZWwgYXQgZGlmZmVyZW50IHJlZnJlc2ggcmF0ZS4gTm90 ZSB0aGF0Cj4gPiA+IHdlIHN0aWxsIGRvbid0IHJlamVjdCBhbnkgdXNlciBtb2RlIHdpdGggYmFk IHJlZnJlc2ggcmF0ZS4gVGhhdCdzCj4gPiA+IGdvaW5nIHRvIGJlIHN0ZXAgdHdvLgo+ID4gPiAK PiA+ID4gVE9ETzogU2hvdWxkIHdlIGFsbG93IGZvciBhIGxhcmdlciBlcnJvciBtYXJnaW4/Cj4g PiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gCj4gPiBOb3Qgc3VyZSB0aGUgY3VycmVudCB2cmVmcmVzaCBp cyBhbnkgZ29vZCwgc2luY2UgaXQncyBIWiByZXNvbHV0aW9uIG9ubHkuCj4gPiBUaGF0J3Mgbm90 IHByZWNpc2UgZW5vdWdoIGZvciB0aGUgdmlkZW8gYWZpY2lvbmFkb3MsIHdobyBpbnNpc3Qgb24g dGhhdAo+ID4gZW50aXJlIDEwMDEvMTAwMCBidXNpbmVzcy4KPiA+IAo+ID4gSSBkaWQgbG9vayBh cm91bmQgYSBiaXQgd2l0aCBhIHF1aWNrIGdpdCBncmVwLCBhbmQgbW9zdCBwbGFjZXMgb25seSB1 c2UKPiA+IC0+dnJlZnJlc2ggZm9yIGRlYnVnIHByaW50aW5nLiBUaGVuIHRoZXJlJ3MgYSBmZXcg dGhhdCB1c2UgaXQgYXMgYW4gaW5kZXgKPiA+IChlLmcuIGk5MTUgRFJSUyBjb2RlKSwgYW5kIHRo ZW4gdGhlcmUncyB0aGUgdG90YWxseSBtaXNndWlkZWQgY29kZSBpbgo+ID4gYWR2NzUxMSB3aGlj aCB0aGlua3MgdnJlZnJlc2ggaXMgaW4ga0h6Lgo+ID4gCj4gPiBUaGVyZSdzIGFsc28gcXVpdGUg YSBwaWxlIG9mIG1vZGUtPnZyZWZyZXNoID8gbW9kZS0+dnJlZnJlc2ggOgo+ID4gZHJtX21vZGVf dnJlZnJlc2gobW9kZSkgYXJvdW5kLCB3aGljaCByZWFsbHkgZG9lc24ndCBpbnNwaXJlIGNvbmZp ZGVuY2UKPiA+IHRoYXQgd2UnbGwgZXZlciBjYXRjaCB0aGVtIGFsbC4gSXQgZmVlbHMgbGlrZSB0 aG9zZSAicmVjb21wdXRlIHZyZWZyZXNoIgo+ID4gdGhpbmdzIGhhdmUgYmVlbiBjYXJnby1jdWx0 ZWQgZm9yIGFnZXMuCj4gPiAKPiA+IEkgdGhpbmsgd2UgbmVlZCB0byBjbGVhbiB0aGlzIHVwIGhh cmRlcjoKPiA+IC0gc3dpdGNoIGV2ZXJ5b25lIG92ZXIgdG8gZHJtX21vZGVfdnJlZnJlc2goKQo+ ID4gLSBudWtlIGRybV9kaXNwbGF5X21vZGUtPnZyZWZyZXNoCj4gPiAtIGFkZCBhIG5ldyBkcm1f bW9kZV92cmVmcmVzaF9tSHogKGZvciBtaWxsaS1IeiwgaS5lLiBmaXhlZCBwb2ludCBtYXRoCj4g PiAgIGZ0dykKPiA+IC0gdXNlIHRoYXQgbmV3IGZ1bmN0aW9uIGluIHRoZSBtb2RlIGZpbHRlcmlu Zywgd2l0aCBhIGJpdCBvZiBmdWRnZSB0aGF0Cj4gPiAgIGtlZXBzIHRoZSAxMDAxLzEwMDAgbW9k ZXMgc2VwYXJhdGUsIGJ1dCBwYXBlcnMgb3ZlciByb3VuZGluZyBlcnJvcnMuIEkKPiA+ICAgdGhp bmsgd2UgY291bGQgZXZlbiBkbyBhIGRybV9tb2RlX2NvbXBhcmVfdnJlZnJlc2ggZm9yIHRoYXQs IHdlJ3JlCj4gPiAgIHByb2JhYmx5IG5vdCB0aGUgb25seSBvbmVzIHdobydkIGxpa2UgdG8gaGF2 ZSBzdWNoIGEgZnVuY3Rpb24uCj4gPiAKPiA+IFByb2JhYmx5IGEgYml0IG1vcmUgd29yayB0byB0 eXBlIChidXQgY29jY2kgbWlnaHQgaGVscCBoZXJlKSwgZGVmaW5pdGVseQo+ID4gbGVzcyBwYWlu ZnVsIHRvIG1ha2Ugc3VyZSBpdCBzdGF5cyBjb3JyZWN0IEkgdGhpbmsuIFRob3VnaHRzPwo+IAo+ IFllYWgsIHdvdWxkIHByb2JhYmx5IG1ha2Ugc2Vuc2UuIEJ1dCBhcGFydCBmcm9tIHRoZSAibWFr ZSBzdXJlIHRoaXMKPiBkb24ndCBicmVhayIgYW5nbGUgaXQgZG9lc24ndCBtYXR0ZXIgZm9yIHRo aXMgY2FzZSB1bmxlc3Mgd2Ugd2FudAo+IHRvIG1ha2UgdGhlIGZpbHRlcmluZyBldmVuIG1vcmUg c3RyaWN0IHRoYW4gdGhlIDEgSHogcmVzb2x1dGlvbi4KCldlbGwgaXQncyBnZW5lcmFsbHkgdmlk ZW8gZm9sa3Mgd2hvIGNhcmUgYWJvdXQgdGhpcywgYW5kIHRob3NlIGZvbGtzIHdpbGwKc3BvdCB0 aGUgMSBIeiBtaXNtYXRjaC4gSSBqdXN0IHJlYWxpemVkIHRoYXQgeW91IGNhbiBpbXBsZW1lbnQg dGhlCmZpbHRlcmluZyB3aXRob3V0IGFsbCB0aGUgcmVmYWN0b3Jpbmc6CgotIEFkZCBkcm1fbW9k ZV92cmVmcmVzaF9tSHouCi0gVXNlIGl0IHRvIGZpbHRlciBtb2Rlcy4KClNpbmNlIGl0J3MgZW50 aXJlbHkgbmV3IHRoZXJlJ3Mgbm8gbmVlZCB0byBjbGVhbiB1cCB0aGUgZW50aXJlIGNvbmZ1c2lv bgphcm91bmQgbW9kZS0+dnJlZnJlc2ggZmlyc3QgYXQgYWxsIDotKQotRGFuaWVsCj4gCj4gPiAK PiA+IENoZWVycywgRGFuaWVsCj4gPiAKPiA+IAo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgICB8IDMgKysrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kc2kuYyAgfCAyICsrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k dm8uYyAgfCAyICsrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgfCAy ICsrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMgfCAyICsrCj4gPiA+ ICA1IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+ID4gPiBpbmRleCA1YmUwN2UxZDgxNmQuLjIyZmViMGIxNDRmNiAxMDA2 NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IEBAIC00NDYsNiArNDQ2LDkg QEAgaW50ZWxfZHBfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ ID4gPiAgCQlpZiAobW9kZS0+dmRpc3BsYXkgPiBmaXhlZF9tb2RlLT52ZGlzcGxheSkKPiA+ID4g IAkJCXJldHVybiBNT0RFX1BBTkVMOwo+ID4gPiAgCj4gPiA+ICsJCWlmIChtb2RlLT52cmVmcmVz aCAhPSBmaXhlZF9tb2RlLT52cmVmcmVzaCkKPiA+ID4gKwkJCXJldHVybiBNT0RFX1BBTkVMOwo+ ID4gPiArCj4gPiA+ICAJCXRhcmdldF9jbG9jayA9IGZpeGVkX21vZGUtPmNsb2NrOwo+ID4gPiAg CX0KPiA+ID4gIAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYwo+ID4gPiBpbmRleCAzYjdh Y2I1YTcwYjMuLjNkMDc1OGNlYzg1YSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHNpLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHNpLmMKPiA+ID4gQEAgLTEyNzcsNiArMTI3Nyw4IEBAIGludGVsX2RzaV9tb2RlX3ZhbGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiA+ICAJCQlyZXR1cm4gTU9ERV9QQU5F TDsKPiA+ID4gIAkJaWYgKG1vZGUtPnZkaXNwbGF5ID4gZml4ZWRfbW9kZS0+dmRpc3BsYXkpCj4g PiA+ICAJCQlyZXR1cm4gTU9ERV9QQU5FTDsKPiA+ID4gKwkJaWYgKG1vZGUtPnZyZWZyZXNoICE9 IGZpeGVkX21vZGUtPnZyZWZyZXNoKQo+ID4gPiArCQkJcmV0dXJuIE1PREVfUEFORUw7Cj4gPiA+ ICAJCWlmIChmaXhlZF9tb2RlLT5jbG9jayA+IG1heF9kb3RjbGspCj4gPiA+ICAJCQlyZXR1cm4g TU9ERV9DTE9DS19ISUdIOwo+ID4gPiAgCX0KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2R2by5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHZvLmMK PiA+ID4gaW5kZXggNGUxNDJmZjQ5NzA4Li4wNzhiYjg0OGE0OWEgMTAwNjQ0Cj4gPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2R2by5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2R2by5jCj4gPiA+IEBAIC0yMjUsNiArMjI1LDggQEAgaW50ZWxfZHZv X21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ID4gIAkJCXJl dHVybiBNT0RFX1BBTkVMOwo+ID4gPiAgCQlpZiAobW9kZS0+dmRpc3BsYXkgPiBmaXhlZF9tb2Rl LT52ZGlzcGxheSkKPiA+ID4gIAkJCXJldHVybiBNT0RFX1BBTkVMOwo+ID4gPiArCQlpZiAobW9k ZS0+dnJlZnJlc2ggIT0gZml4ZWRfbW9kZS0+dnJlZnJlc2gpCj4gPiA+ICsJCQlyZXR1cm4gTU9E RV9QQU5FTDsKPiA+ID4gIAo+ID4gPiAgCQl0YXJnZXRfY2xvY2sgPSBmaXhlZF9tb2RlLT5jbG9j azsKPiA+ID4gIAl9Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9sdmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiA+ID4gaW5kZXgg YmIwNjc0NGQyOGE0Li5kMzEyYTg5MTFiODkgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9sdmRzLmMKPiA+ID4gQEAgLTM4NCw2ICszODQsOCBAQCBpbnRlbF9sdmRzX21vZGVfdmFs aWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ID4gIAkJcmV0dXJuIE1PREVf UEFORUw7Cj4gPiA+ICAJaWYgKG1vZGUtPnZkaXNwbGF5ID4gZml4ZWRfbW9kZS0+dmRpc3BsYXkp Cj4gPiA+ICAJCXJldHVybiBNT0RFX1BBTkVMOwo+ID4gPiArCWlmIChtb2RlLT52cmVmcmVzaCAh PSBmaXhlZF9tb2RlLT52cmVmcmVzaCkKPiA+ID4gKwkJcmV0dXJuIE1PREVfUEFORUw7Cj4gPiA+ ICAJaWYgKGZpeGVkX21vZGUtPmNsb2NrID4gbWF4X3BpeGNsaykKPiA+ID4gIAkJcmV0dXJuIE1P REVfQ0xPQ0tfSElHSDsKPiA+ID4gIAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfc2R2by5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4g PiA+IGluZGV4IGNkNWQ1ZTgwMDQ4Ni4uNGJlNGJhZTUxNjUyIDEwMDY0NAo+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4gPiA+IEBAIC0xNjUwLDYgKzE2NTAsOCBAQCBpbnRlbF9z ZHZvX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ID4gIAkJ CXJldHVybiBNT0RFX1BBTkVMOwo+ID4gPiAgCj4gPiA+ICAJCWlmIChtb2RlLT52ZGlzcGxheSA+ IGZpeGVkX21vZGUtPnZkaXNwbGF5KQo+ID4gPiArCj4gPiA+ICsJCWlmIChtb2RlLT52cmVmcmVz aCAhPSBmaXhlZF9tb2RlLT52cmVmcmVzaCkKPiA+ID4gIAkJCXJldHVybiBNT0RFX1BBTkVMOwo+ ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAtLSAKPiA+ID4gMi4xNi40Cj4gPiA+IAo+ID4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwKPiA+IAo+ID4gLS0gCj4gPiBEYW5pZWwgVmV0dGVyCj4gPiBTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KPiA+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gCj4gLS0gCj4gVmls bGUgU3lyasOkbMOkCj4gSW50ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK