From: Ayan Halder Subject: Re: [RFC PATCH 4/4] drm/arm/malidp: Added support for AFBC modifiers for all layers except DE_SMART Date: Thu, 5 Jul 2018 14:45:12 +0100 Message-ID: <20180705134512.GB31243@arm.com> References: <1529070694-21088-1-git-send-email-ayan.halder@arm.com> <1529070694-21088-5-git-send-email-ayan.halder@arm.com> <20180626132158.GB14974@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by gabe.freedesktop.org (Postfix) with ESMTPS id 345986ED70 for ; Thu, 5 Jul 2018 13:45:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180626132158.GB14974@e110455-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: airlied@linux.ie, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, malidp@foss.arm.com, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMjYsIDIwMTggYXQgMDI6MjE6NThQTSArMDEwMCwgTGl2aXUgRHVkYXUgd3Jv dGU6Cj4gT24gRnJpLCBKdW4gMTUsIDIwMTggYXQgMDI6NTE6MzRQTSArMDEwMCwgQXlhbiBLdW1h ciBIYWxkZXIgd3JvdGU6Cj4gPiBPbiBwbGFuZXMgd2hpY2ggc3VwcG9ydCBBRkJDLCBleHBvc2Ug YW4gQUZCQyBtb2RpZmllciBmb3IgdXNlIHdpdGggQkdSODg4Lgo+ID4gCj4gPiBTaWduZWQtb2Zm LWJ5OiBBeWFuIEt1bWFyIGhhbGRlciA8YXlhbi5oYWxkZXJAYXJtLmNvbT4KPiA+IFJldmlld2Vk LWJ5OiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4gPiAKPiA+IENoYW5n ZS1JZDogSTQ3MzlmZjU1YzBmNmQ1NzE1YjI2OGNiMzk0N2VkMTMzYTllZTdjMmUKPiAKPiBQbGVh c2UgcmVtb3ZlIHRoZSBDaGFuZ2UtSWQKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9h cm0vbWFsaWRwX2Rydi5jICAgIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRw X3BsYW5lcy5jIHwgNDYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ID4g IDIgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jIGIvZHJpdmVy cy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2LmMKPiA+IGluZGV4IDdiNmE4NDguLjdiY2Q2NzkgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2LmMKPiA+IEBAIC0zOTIsNiArMzkyLDcgQEAg c3RhdGljIGludCBtYWxpZHBfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ID4gIAlkcm0t Pm1vZGVfY29uZmlnLm1heF9oZWlnaHQgPSBod2Rldi0+bWF4X2xpbmVfc2l6ZTsKPiA+ICAJZHJt LT5tb2RlX2NvbmZpZy5mdW5jcyA9ICZtYWxpZHBfbW9kZV9jb25maWdfZnVuY3M7Cj4gPiAgCWRy bS0+bW9kZV9jb25maWcuaGVscGVyX3ByaXZhdGUgPSAmbWFsaWRwX21vZGVfY29uZmlnX2hlbHBl cnM7Cj4gPiArCWRybS0+bW9kZV9jb25maWcuYWxsb3dfZmJfbW9kaWZpZXJzID0gdHJ1ZTsKPiA+ ICAKPiA+ICAJcmV0ID0gbWFsaWRwX2NydGNfaW5pdChkcm0pOwo+ID4gIAlpZiAocmV0KSB7Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMuYwo+ID4gaW5kZXggMzk1MDUwNC4uNTVjOWEx ZjYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMKPiA+IEBAIC0xMjQs NiArMTI0LDM1IEBAIHN0YXRpYyB2b2lkIG1hbGlkcF9wbGFuZV9hdG9taWNfcHJpbnRfc3RhdGUo c3RydWN0IGRybV9wcmludGVyICpwLAo+ID4gIAlkcm1fcHJpbnRmKHAsICJcdG5fcGxhbmVzPSV1 XG4iLCBtcy0+bl9wbGFuZXMpOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgYm9vbCBtYWxpZHBf Zm9ybWF0X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiArCQkJCQl1 MzIgZm9ybWF0LCB1NjQgbW9kaWZpZXIpCj4gPiArewo+ID4gKwlpZiAoV0FSTl9PTihtb2RpZmll ciA9PSBEUk1fRk9STUFUX01PRF9JTlZBTElEKSkKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICsK PiA+ICsJLyogQWxsIHRoZSBwaXhlbCBmb3JtYXRzIGFyZSBzdXBwb3J0ZWQgd2l0aG91dCBhbnkg bW9kaWZpZXIgKi8KPiA+ICsJaWYgKG1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikK PiA+ICsJCXJldHVybiB0cnVlOwo+ID4gKwo+ID4gKwlpZiAoKG1vZGlmaWVyID4+IDU2KSAhPSBE Uk1fRk9STUFUX01PRF9WRU5ET1JfQVJNKQo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwo+ID4g KwlpZiAobW9kaWZpZXIgJgo+ID4gKwkgICAgfkRSTV9GT1JNQVRfTU9EX0FSTV9BRkJDKEFGQkNf TU9EX1ZBTElEX0JJVFMpKSB7Cj4gPiArCQlEUk1fRVJST1IoIlVuc3VwcG9ydGVkIG1vZGlmaWVy c1xuIik7Cj4gCj4gSSBkb24ndCB0aGluayB3ZSBzaG91bGQgcG9sdXRlIHRoZSBrZXJuZWwgbG9n IGJ1ZmZlcnMgd2l0aCB0aGlzLiBNYXliZSBhCj4gRFJNX0RFQlVHKCkgaWYgeW91IHJlYWxseSB3 YW50IHRvIGdldCBzb21lIG5vdGlmaWNhdGlvbj8KCkkgYWdyZWUgd2l0aCB5b3UgY29tcGxldGVs eS4gSSB0aGluayB3ZSBzaG91bGQgdXNlIERSTV9ERUJVR19LTVMoKQpsaWtlIGludGVsX2ZyYW1l YnVmZmVyX2luaXQoKSB1c2VzIHRvIGxvZyB1bnN1cHBvcnRlZCBmb3JtYXRzIGFuZAptb2RpZmll cnMuCkkgd2lsbCBzZW5kIGEgdjIgcGF0Y2ggZm9yIHRoaXMuCj4gCj4gV2l0aCB0aG9zZSBjaGFu Z2VzIGFkZGVkOgo+IAo+IFJldmlld2VkLWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJt LmNvbT4KPiAKPiBCZXN0IHJlZ2FyZHMsCj4gTGl2aXUKPiAKPiA+ICsJCXJldHVybiBmYWxzZTsK PiA+ICsJfQo+ID4gKwo+ID4gKwlzd2l0Y2ggKG1vZGlmaWVyKSB7Cj4gPiArCWNhc2UgRFJNX0ZP Uk1BVF9NT0RfQVJNX0FGQkMoQUZCQ19GT1JNQVRfTU9EX0JMT0NLX1NJWkVfMTZ4MTYgfAo+ID4g KwkJCQlBRkJDX0ZPUk1BVF9NT0RfWVRSIHwKPiA+ICsJCQkJQUZCQ19GT1JNQVRfTU9EX1NQQVJT RSk6Cj4gPiArCQlpZiAoZm9ybWF0ID09IERSTV9GT1JNQVRfQkdSODg4KQo+ID4gKwkJCXJldHVy biB0cnVlOwo+ID4gKwl9Cj4gPiArCXJldHVybiBmYWxzZTsKPiA+ICt9Cj4gPiArCj4gPiAgc3Rh dGljIGNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfZnVuY3MgbWFsaWRwX2RlX3BsYW5lX2Z1bmNzID0g ewo+ID4gIAkudXBkYXRlX3BsYW5lID0gZHJtX2F0b21pY19oZWxwZXJfdXBkYXRlX3BsYW5lLAo+ ID4gIAkuZGlzYWJsZV9wbGFuZSA9IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUsCj4g PiBAQCAtMTMyLDYgKzE2MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2Z1bmNz IG1hbGlkcF9kZV9wbGFuZV9mdW5jcyA9IHsKPiA+ICAJLmF0b21pY19kdXBsaWNhdGVfc3RhdGUg PSBtYWxpZHBfZHVwbGljYXRlX3BsYW5lX3N0YXRlLAo+ID4gIAkuYXRvbWljX2Rlc3Ryb3lfc3Rh dGUgPSBtYWxpZHBfZGVzdHJveV9wbGFuZV9zdGF0ZSwKPiA+ICAJLmF0b21pY19wcmludF9zdGF0 ZSA9IG1hbGlkcF9wbGFuZV9hdG9taWNfcHJpbnRfc3RhdGUsCj4gPiArCS5mb3JtYXRfbW9kX3N1 cHBvcnRlZCA9IG1hbGlkcF9mb3JtYXRfbW9kX3N1cHBvcnRlZCwKPiA+ICB9Owo+ID4gIAo+ID4g IHN0YXRpYyBpbnQgbWFsaWRwX3NlX2NoZWNrX3NjYWxpbmcoc3RydWN0IG1hbGlkcF9wbGFuZSAq bXAsCj4gPiBAQCAtNTI0LDYgKzU1NCwxMyBAQCBpbnQgbWFsaWRwX2RlX3BsYW5lc19pbml0KHN0 cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4gPiAgCXUzMiAqZm9ybWF0czsKPiA+ICAJaW50IHJldCwg aSwgaiwgbjsKPiA+ICAKPiA+ICsJc3RhdGljIGNvbnN0IHU2NCBtb2RpZmllcnNbXSA9IHsKPiA+ ICsJCURSTV9GT1JNQVRfTU9EX0FSTV9BRkJDKEFGQkNfRk9STUFUX01PRF9CTE9DS19TSVpFXzE2 eDE2IHwKPiA+ICsJCQlBRkJDX0ZPUk1BVF9NT0RfWVRSIHwgQUZCQ19GT1JNQVRfTU9EX1NQQVJT RSksCj4gPiArCQlEUk1fRk9STUFUX01PRF9MSU5FQVIsCj4gPiArCQlEUk1fRk9STUFUX01PRF9J TlZBTElECj4gPiArCX07Cj4gPiArCj4gPiAgCWZvcm1hdHMgPSBrY2FsbG9jKG1hcC0+bl9waXhl bF9mb3JtYXRzLCBzaXplb2YoKmZvcm1hdHMpLCBHRlBfS0VSTkVMKTsKPiA+ICAJaWYgKCFmb3Jt YXRzKSB7Cj4gPiAgCQlyZXQgPSAtRU5PTUVNOwo+ID4gQEAgLTU0Nyw5ICs1ODQsMTQgQEAgaW50 IG1hbGlkcF9kZV9wbGFuZXNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ID4gIAo+ID4g IAkJcGxhbmVfdHlwZSA9IChpID09IDApID8gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSA6Cj4gPiAg CQkJCQlEUk1fUExBTkVfVFlQRV9PVkVSTEFZOwo+ID4gKwo+ID4gKwkJLyoKPiA+ICsJCSAqIEFs bCB0aGUgbGF5ZXJzIGV4Y2VwdCBzbWFydCBsYXllciBzdXBwb3J0cyBBRkJDIG1vZGlmaWVycy4K PiA+ICsJCSAqLwo+ID4gIAkJcmV0ID0gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KGRybSwgJnBs YW5lLT5iYXNlLCBjcnRjcywKPiA+IC0JCQkJCSAgICAgICAmbWFsaWRwX2RlX3BsYW5lX2Z1bmNz LCBmb3JtYXRzLAo+ID4gLQkJCQkJICAgICAgIG4sIE5VTEwsIHBsYW5lX3R5cGUsIE5VTEwpOwo+ ID4gKwkJCQkmbWFsaWRwX2RlX3BsYW5lX2Z1bmNzLCBmb3JtYXRzLCBuLAo+ID4gKwkJCQkoaWQg PT0gREVfU01BUlQpID8gTlVMTCA6IG1vZGlmaWVycywgcGxhbmVfdHlwZSwgTlVMTCk7Cj4gPiAr Cj4gPiAgCQlpZiAocmV0IDwgMCkKPiA+ICAJCQlnb3RvIGNsZWFudXA7Cj4gPiAgCj4gPiAtLSAK PiA+IDIuNy40Cj4gPiAKPiAKPiAtLSAKPiA9PT09PT09PT09PT09PT09PT09PQo+IHwgSSB3b3Vs ZCBsaWtlIHRvIHwKPiB8IGZpeCB0aGUgd29ybGQsICB8Cj4gfCBidXQgdGhleSdyZSBub3QgfAo+ IHwgZ2l2aW5nIG1lIHRoZSAgIHwKPiAgXCBzb3VyY2UgY29kZSEgIC8KPiAgIC0tLS0tLS0tLS0t LS0tLQo+ICAgICA/P1xfKD8/PylfLz8/Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=