From: Daniel Vetter Subject: Re: [RFC PATCH v2] drm/arm/malidp: Added support for AFBC modifiers for all layers except DE_SMART Date: Thu, 5 Jul 2018 17:48:22 +0200 Message-ID: <20180705154822.GC4273@phenom.ffwll.local> References: <1530800743-2250-1-git-send-email-ayan.halder@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 037AC6EE05 for ; Thu, 5 Jul 2018 15:48:27 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id x5-v6so2858149edr.0 for ; Thu, 05 Jul 2018 08:48:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1530800743-2250-1-git-send-email-ayan.halder@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ayan Kumar Halder Cc: airlied@linux.ie, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, malidp@foss.arm.com, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMDUsIDIwMTggYXQgMDM6MjU6NDNQTSArMDEwMCwgQXlhbiBLdW1hciBIYWxk ZXIgd3JvdGU6Cj4gT24gcGxhbmVzIHdoaWNoIHN1cHBvcnQgQUZCQywgZXhwb3NlIGFuIEFGQkMg bW9kaWZpZXIgZm9yIHVzZSB3aXRoIEJHUjg4OC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBeWFuIEt1 bWFyIGhhbGRlciA8YXlhbi5oYWxkZXJAYXJtLmNvbT4KPiBSZXZpZXdlZC1ieTogQnJpYW4gU3Rh cmtleSA8YnJpYW4uc3RhcmtleUBhcm0uY29tPgo+IFJldmlld2VkLWJ5OiBMaXZpdSBEdWRhdSA8 bGl2aXUuZHVkYXVAYXJtLmNvbT4KPiAKPiBDaGFuZ2VzIGZyb20gdjI6Cj4gLSBSZW1vdmVkIHRo ZSBnZXJyaXQgY2hhbmdlLWlkCj4gLSBSZXBsYWNlZCBEUk1fRVJST1IoKSB3aXRoIERSTV9ERUJV R19LTVMoKSBpbiBtYWxpZHBfZm9ybWF0X21vZF9zdXBwb3J0ZWQoKQo+IHRvIHJlcG9ydCB1bnN1 cHBvcnRlZCBtb2RpZmllcnMuCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Ry di5jICAgIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMuYyB8IDQ2 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMiBmaWxlcyBjaGFuZ2Vk LCA0NSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRw X2Rydi5jCj4gaW5kZXggN2I2YTg0OC4uN2JjZDY3OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRw X2Rydi5jCj4gQEAgLTM5Miw2ICszOTIsNyBAQCBzdGF0aWMgaW50IG1hbGlkcF9pbml0KHN0cnVj dCBkcm1fZGV2aWNlICpkcm0pCj4gIAlkcm0tPm1vZGVfY29uZmlnLm1heF9oZWlnaHQgPSBod2Rl di0+bWF4X2xpbmVfc2l6ZTsKPiAgCWRybS0+bW9kZV9jb25maWcuZnVuY3MgPSAmbWFsaWRwX21v ZGVfY29uZmlnX2Z1bmNzOwo+ICAJZHJtLT5tb2RlX2NvbmZpZy5oZWxwZXJfcHJpdmF0ZSA9ICZt YWxpZHBfbW9kZV9jb25maWdfaGVscGVyczsKPiArCWRybS0+bW9kZV9jb25maWcuYWxsb3dfZmJf bW9kaWZpZXJzID0gdHJ1ZTsKPiAgCj4gIAlyZXQgPSBtYWxpZHBfY3J0Y19pbml0KGRybSk7Cj4g IAlpZiAocmV0KSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3Bs YW5lcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMKPiBpbmRleCAzOTUw NTA0Li45MTRjYzU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3Bs YW5lcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfcGxhbmVzLmMKPiBAQCAt MTI0LDYgKzEyNCwzNSBAQCBzdGF0aWMgdm9pZCBtYWxpZHBfcGxhbmVfYXRvbWljX3ByaW50X3N0 YXRlKHN0cnVjdCBkcm1fcHJpbnRlciAqcCwKPiAgCWRybV9wcmludGYocCwgIlx0bl9wbGFuZXM9 JXVcbiIsIG1zLT5uX3BsYW5lcyk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29sIG1hbGlkcF9mb3Jt YXRfbW9kX3N1cHBvcnRlZChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiArCQkJCQl1MzIgZm9y bWF0LCB1NjQgbW9kaWZpZXIpCj4gK3sKPiArCWlmIChXQVJOX09OKG1vZGlmaWVyID09IERSTV9G T1JNQVRfTU9EX0lOVkFMSUQpKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwkvKiBBbGwgdGhl IHBpeGVsIGZvcm1hdHMgYXJlIHN1cHBvcnRlZCB3aXRob3V0IGFueSBtb2RpZmllciAqLwo+ICsJ aWYgKG1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikKPiArCQlyZXR1cm4gdHJ1ZTsK PiArCj4gKwlpZiAoKG1vZGlmaWVyID4+IDU2KSAhPSBEUk1fRk9STUFUX01PRF9WRU5ET1JfQVJN KQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAobW9kaWZpZXIgJgo+ICsJICAgIH5EUk1f Rk9STUFUX01PRF9BUk1fQUZCQyhBRkJDX01PRF9WQUxJRF9CSVRTKSkgewo+ICsJCURSTV9ERUJV R19LTVMoIlVuc3VwcG9ydGVkIG1vZGlmaWVyc1xuIik7Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJ fQoKSSB0aGluayB0aGUgY29yZSBjaGVja3MgZm9yIHRoYXQgYnkgbm93LCBvciBhdCBsZWFzdCBW aWxsZSBoYWQgc29tZQpwYXRjaGVzIHRvIG1ha2UgdGhhdCBoYXBwZW4gLi4uCgpJIGFsc28gZG9u J3Qgc2VlIHRoZSBBUk1fQUZCQyBtb2RpZmllciBpbiB1cHN0cmVhbSB5ZXQsIGlzIHRoYXQgc3Rp bGwKaW4tZmxpZ2h0IHNvbWV3aGVyZT8KLURhbmllbAoKPiArCj4gKwlzd2l0Y2ggKG1vZGlmaWVy KSB7Cj4gKwljYXNlIERSTV9GT1JNQVRfTU9EX0FSTV9BRkJDKEFGQkNfRk9STUFUX01PRF9CTE9D S19TSVpFXzE2eDE2IHwKPiArCQkJCUFGQkNfRk9STUFUX01PRF9ZVFIgfAo+ICsJCQkJQUZCQ19G T1JNQVRfTU9EX1NQQVJTRSk6Cj4gKwkJaWYgKGZvcm1hdCA9PSBEUk1fRk9STUFUX0JHUjg4OCkK PiArCQkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2Z1bmNzIG1hbGlkcF9kZV9wbGFuZV9mdW5jcyA9 IHsKPiAgCS51cGRhdGVfcGxhbmUgPSBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUsCj4g IAkuZGlzYWJsZV9wbGFuZSA9IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUsCj4gQEAg LTEzMiw2ICsxNjEsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5jcyBtYWxp ZHBfZGVfcGxhbmVfZnVuY3MgPSB7Cj4gIAkuYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSA9IG1hbGlk cF9kdXBsaWNhdGVfcGxhbmVfc3RhdGUsCj4gIAkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBtYWxp ZHBfZGVzdHJveV9wbGFuZV9zdGF0ZSwKPiAgCS5hdG9taWNfcHJpbnRfc3RhdGUgPSBtYWxpZHBf cGxhbmVfYXRvbWljX3ByaW50X3N0YXRlLAo+ICsJLmZvcm1hdF9tb2Rfc3VwcG9ydGVkID0gbWFs aWRwX2Zvcm1hdF9tb2Rfc3VwcG9ydGVkLAo+ICB9Owo+ICAKPiAgc3RhdGljIGludCBtYWxpZHBf c2VfY2hlY2tfc2NhbGluZyhzdHJ1Y3QgbWFsaWRwX3BsYW5lICptcCwKPiBAQCAtNTI0LDYgKzU1 NCwxMyBAQCBpbnQgbWFsaWRwX2RlX3BsYW5lc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0p Cj4gIAl1MzIgKmZvcm1hdHM7Cj4gIAlpbnQgcmV0LCBpLCBqLCBuOwo+ICAKPiArCXN0YXRpYyBj b25zdCB1NjQgbW9kaWZpZXJzW10gPSB7Cj4gKwkJRFJNX0ZPUk1BVF9NT0RfQVJNX0FGQkMoQUZC Q19GT1JNQVRfTU9EX0JMT0NLX1NJWkVfMTZ4MTYgfAo+ICsJCQlBRkJDX0ZPUk1BVF9NT0RfWVRS IHwgQUZCQ19GT1JNQVRfTU9EX1NQQVJTRSksCj4gKwkJRFJNX0ZPUk1BVF9NT0RfTElORUFSLAo+ ICsJCURSTV9GT1JNQVRfTU9EX0lOVkFMSUQKPiArCX07Cj4gKwo+ICAJZm9ybWF0cyA9IGtjYWxs b2MobWFwLT5uX3BpeGVsX2Zvcm1hdHMsIHNpemVvZigqZm9ybWF0cyksIEdGUF9LRVJORUwpOwo+ ICAJaWYgKCFmb3JtYXRzKSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsKPiBAQCAtNTQ3LDkgKzU4NCwx NCBAQCBpbnQgbWFsaWRwX2RlX3BsYW5lc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4g IAo+ICAJCXBsYW5lX3R5cGUgPSAoaSA9PSAwKSA/IERSTV9QTEFORV9UWVBFX1BSSU1BUlkgOgo+ ICAJCQkJCURSTV9QTEFORV9UWVBFX09WRVJMQVk7Cj4gKwo+ICsJCS8qCj4gKwkJICogQWxsIHRo ZSBsYXllcnMgZXhjZXB0IHNtYXJ0IGxheWVyIHN1cHBvcnRzIEFGQkMgbW9kaWZpZXJzLgo+ICsJ CSAqLwo+ICAJCXJldCA9IGRybV91bml2ZXJzYWxfcGxhbmVfaW5pdChkcm0sICZwbGFuZS0+YmFz ZSwgY3J0Y3MsCj4gLQkJCQkJICAgICAgICZtYWxpZHBfZGVfcGxhbmVfZnVuY3MsIGZvcm1hdHMs Cj4gLQkJCQkJICAgICAgIG4sIE5VTEwsIHBsYW5lX3R5cGUsIE5VTEwpOwo+ICsJCQkJJm1hbGlk cF9kZV9wbGFuZV9mdW5jcywgZm9ybWF0cywgbiwKPiArCQkJCShpZCA9PSBERV9TTUFSVCkgPyBO VUxMIDogbW9kaWZpZXJzLCBwbGFuZV90eXBlLCBOVUxMKTsKPiArCj4gIAkJaWYgKHJldCA8IDAp Cj4gIAkJCWdvdG8gY2xlYW51cDsKPiAgCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK