From: Ayan Halder Subject: Re: [RFC PATCH v2] drm/arm/malidp: Added support for AFBC modifiers for all layers except DE_SMART Date: Thu, 5 Jul 2018 17:20:56 +0100 Message-ID: <20180705162056.GA18005@arm.com> References: <1530800743-2250-1-git-send-email-ayan.halder@arm.com> <20180705154822.GC4273@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6182689F97 for ; Thu, 5 Jul 2018 16:21:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180705154822.GC4273@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMDUsIDIwMTggYXQgMDU6NDg6MjJQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEp1bCAwNSwgMjAxOCBhdCAwMzoyNTo0M1BNICswMTAwLCBBeWFuIEt1 bWFyIEhhbGRlciB3cm90ZToKPiA+IE9uIHBsYW5lcyB3aGljaCBzdXBwb3J0IEFGQkMsIGV4cG9z ZSBhbiBBRkJDIG1vZGlmaWVyIGZvciB1c2Ugd2l0aCBCR1I4ODguCj4gPgo+ID4gU2lnbmVkLW9m Zi1ieTogQXlhbiBLdW1hciBoYWxkZXIgPGF5YW4uaGFsZGVyQGFybS5jb20+Cj4gPiBSZXZpZXdl ZC1ieTogQnJpYW4gU3RhcmtleSA8YnJpYW4uc3RhcmtleUBhcm0uY29tPgo+ID4gUmV2aWV3ZWQt Ynk6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRhdUBhcm0uY29tPgo+ID4KPiA+IENoYW5nZXMgZnJv bSB2MjoKPiA+IC0gUmVtb3ZlZCB0aGUgZ2Vycml0IGNoYW5nZS1pZAo+ID4gLSBSZXBsYWNlZCBE Uk1fRVJST1IoKSB3aXRoIERSTV9ERUJVR19LTVMoKSBpbiBtYWxpZHBfZm9ybWF0X21vZF9zdXBw b3J0ZWQoKQo+ID4gdG8gcmVwb3J0IHVuc3VwcG9ydGVkIG1vZGlmaWVycy4KPiA+IC0tLQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jICAgIHwgIDEgKwo+ID4gIGRyaXZlcnMv Z3B1L2RybS9hcm0vbWFsaWRwX3BsYW5lcy5jIHwgNDYgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxp ZHBfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ID4gaW5kZXggN2I2 YTg0OC4uN2JjZDY3OSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRw X2Rydi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ID4gQEAg LTM5Miw2ICszOTIsNyBAQCBzdGF0aWMgaW50IG1hbGlkcF9pbml0KHN0cnVjdCBkcm1fZGV2aWNl ICpkcm0pCj4gPiAgICAgZHJtLT5tb2RlX2NvbmZpZy5tYXhfaGVpZ2h0ID0gaHdkZXYtPm1heF9s aW5lX3NpemU7Cj4gPiAgICAgZHJtLT5tb2RlX2NvbmZpZy5mdW5jcyA9ICZtYWxpZHBfbW9kZV9j b25maWdfZnVuY3M7Cj4gPiAgICAgZHJtLT5tb2RlX2NvbmZpZy5oZWxwZXJfcHJpdmF0ZSA9ICZt YWxpZHBfbW9kZV9jb25maWdfaGVscGVyczsKPiA+ICsgICBkcm0tPm1vZGVfY29uZmlnLmFsbG93 X2ZiX21vZGlmaWVycyA9IHRydWU7Cj4gPgo+ID4gICAgIHJldCA9IG1hbGlkcF9jcnRjX2luaXQo ZHJtKTsKPiA+ICAgICBpZiAocmV0KSB7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FybS9tYWxpZHBfcGxhbmVzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9wbGFuZXMu Ywo+ID4gaW5kZXggMzk1MDUwNC4uOTE0Y2M1OCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hcm0vbWFsaWRwX3BsYW5lcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21h bGlkcF9wbGFuZXMuYwo+ID4gQEAgLTEyNCw2ICsxMjQsMzUgQEAgc3RhdGljIHZvaWQgbWFsaWRw X3BsYW5lX2F0b21pY19wcmludF9zdGF0ZShzdHJ1Y3QgZHJtX3ByaW50ZXIgKnAsCj4gPiAgICAg ZHJtX3ByaW50ZihwLCAiXHRuX3BsYW5lcz0ldVxuIiwgbXMtPm5fcGxhbmVzKTsKPiA+ICB9Cj4g Pgo+ID4gK3N0YXRpYyBib29sIG1hbGlkcF9mb3JtYXRfbW9kX3N1cHBvcnRlZChzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUz MiBmb3JtYXQsIHU2NCBtb2RpZmllcikKPiA+ICt7Cj4gPiArICAgaWYgKFdBUk5fT04obW9kaWZp ZXIgPT0gRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRCkpCj4gPiArICAgICAgICAgICByZXR1cm4gZmFs c2U7Cj4gPiArCj4gPiArICAgLyogQWxsIHRoZSBwaXhlbCBmb3JtYXRzIGFyZSBzdXBwb3J0ZWQg d2l0aG91dCBhbnkgbW9kaWZpZXIgKi8KPiA+ICsgICBpZiAobW9kaWZpZXIgPT0gRFJNX0ZPUk1B VF9NT0RfTElORUFSKQo+ID4gKyAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4gPiArCj4gPiArICAg aWYgKChtb2RpZmllciA+PiA1NikgIT0gRFJNX0ZPUk1BVF9NT0RfVkVORE9SX0FSTSkKPiA+ICsg ICAgICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICsKPiA+ICsgICBpZiAobW9kaWZpZXIgJgo+ID4g KyAgICAgICB+RFJNX0ZPUk1BVF9NT0RfQVJNX0FGQkMoQUZCQ19NT0RfVkFMSURfQklUUykpIHsK PiA+ICsgICAgICAgICAgIERSTV9ERUJVR19LTVMoIlVuc3VwcG9ydGVkIG1vZGlmaWVyc1xuIik7 Cj4gPiArICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiArICAgfQo+Cj4gSSB0aGluayB0aGUg Y29yZSBjaGVja3MgZm9yIHRoYXQgYnkgbm93LCBvciBhdCBsZWFzdCBWaWxsZSBoYWQgc29tZQo+ IHBhdGNoZXMgdG8gbWFrZSB0aGF0IGhhcHBlbiAuLi4KCkNhbiB5b3UgcGFzdGUgdGhlIGxpbmsg KG9yIGF0bGVhc3QgdGhlIHRpdGxlKSBvZiB0aGUgcGF0Y2hlcyB0aGF0IHlvdQphcmUgcmVmZXJy aW5nIHRvID8gSSBtaWdodCB0aGVuIGhhdmUgdG8gcmV3b3JrIG9uIHRoaXMuCj4gSSBhbHNvIGRv bid0IHNlZSB0aGUgQVJNX0FGQkMgbW9kaWZpZXIgaW4gdXBzdHJlYW0geWV0LCBpcyB0aGF0IHN0 aWxsCj4gaW4tZmxpZ2h0IHNvbWV3aGVyZT8KCkkgcmVhbGl6ZWQgdGhhdCBJIHdhcyBtaXNzaW5n IHRoZSBhY2sgb24gbXkgZmlyc3QgcGF0Y2ggb2YgdGhlIHNlcmllcwooaWUKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTgtSnVuZS8xODAxMjUuaHRt bCkKYW5kIHRoZSByZWFzb24gSSBiZWxpZXZlIGlzIHRoYXQgSSBkaWQgbm90IHB1dCB0aGUgY29y cmVjdCBlbWFpbAphZGRyZXNzZXMgaW4gIi0tdG8iIGZvciB0aGUgZHJtX2ZvdXJjYy5oIG1haW50 YWluZXJzLiBJIHdpbGwgcmVzZW5kIHRoZQpwYXRjaCBhbmQgd2FpdCBmb3IgdGhlaXIgYWNrLgoK PiAtRGFuaWVsCj4KPiA+ICsKPiA+ICsgICBzd2l0Y2ggKG1vZGlmaWVyKSB7Cj4gPiArICAgY2Fz ZSBEUk1fRk9STUFUX01PRF9BUk1fQUZCQyhBRkJDX0ZPUk1BVF9NT0RfQkxPQ0tfU0laRV8xNngx NiB8Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgQUZCQ19GT1JNQVRfTU9EX1lUUiB8 Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgQUZCQ19GT1JNQVRfTU9EX1NQQVJTRSk6 Cj4gPiArICAgICAgICAgICBpZiAoZm9ybWF0ID09IERSTV9GT1JNQVRfQkdSODg4KQo+ID4gKyAg ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPiA+ICsgICB9Cj4gPiArICAgcmV0dXJuIGZh bHNlOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5j cyBtYWxpZHBfZGVfcGxhbmVfZnVuY3MgPSB7Cj4gPiAgICAgLnVwZGF0ZV9wbGFuZSA9IGRybV9h dG9taWNfaGVscGVyX3VwZGF0ZV9wbGFuZSwKPiA+ICAgICAuZGlzYWJsZV9wbGFuZSA9IGRybV9h dG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUsCj4gPiBAQCAtMTMyLDYgKzE2MSw3IEBAIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2Z1bmNzIG1hbGlkcF9kZV9wbGFuZV9mdW5jcyA9IHsK PiA+ICAgICAuYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSA9IG1hbGlkcF9kdXBsaWNhdGVfcGxhbmVf c3RhdGUsCj4gPiAgICAgLmF0b21pY19kZXN0cm95X3N0YXRlID0gbWFsaWRwX2Rlc3Ryb3lfcGxh bmVfc3RhdGUsCj4gPiAgICAgLmF0b21pY19wcmludF9zdGF0ZSA9IG1hbGlkcF9wbGFuZV9hdG9t aWNfcHJpbnRfc3RhdGUsCj4gPiArICAgLmZvcm1hdF9tb2Rfc3VwcG9ydGVkID0gbWFsaWRwX2Zv cm1hdF9tb2Rfc3VwcG9ydGVkLAo+ID4gIH07Cj4gPgo+ID4gIHN0YXRpYyBpbnQgbWFsaWRwX3Nl X2NoZWNrX3NjYWxpbmcoc3RydWN0IG1hbGlkcF9wbGFuZSAqbXAsCj4gPiBAQCAtNTI0LDYgKzU1 NCwxMyBAQCBpbnQgbWFsaWRwX2RlX3BsYW5lc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0p Cj4gPiAgICAgdTMyICpmb3JtYXRzOwo+ID4gICAgIGludCByZXQsIGksIGosIG47Cj4gPgo+ID4g KyAgIHN0YXRpYyBjb25zdCB1NjQgbW9kaWZpZXJzW10gPSB7Cj4gPiArICAgICAgICAgICBEUk1f Rk9STUFUX01PRF9BUk1fQUZCQyhBRkJDX0ZPUk1BVF9NT0RfQkxPQ0tfU0laRV8xNngxNiB8Cj4g PiArICAgICAgICAgICAgICAgICAgIEFGQkNfRk9STUFUX01PRF9ZVFIgfCBBRkJDX0ZPUk1BVF9N T0RfU1BBUlNFKSwKPiA+ICsgICAgICAgICAgIERSTV9GT1JNQVRfTU9EX0xJTkVBUiwKPiA+ICsg ICAgICAgICAgIERSTV9GT1JNQVRfTU9EX0lOVkFMSUQKPiA+ICsgICB9Owo+ID4gKwo+ID4gICAg IGZvcm1hdHMgPSBrY2FsbG9jKG1hcC0+bl9waXhlbF9mb3JtYXRzLCBzaXplb2YoKmZvcm1hdHMp LCBHRlBfS0VSTkVMKTsKPiA+ICAgICBpZiAoIWZvcm1hdHMpIHsKPiA+ICAgICAgICAgICAgIHJl dCA9IC1FTk9NRU07Cj4gPiBAQCAtNTQ3LDkgKzU4NCwxNCBAQCBpbnQgbWFsaWRwX2RlX3BsYW5l c19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4gPgo+ID4gICAgICAgICAgICAgcGxhbmVf dHlwZSA9IChpID09IDApID8gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSA6Cj4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fUExBTkVfVFlQRV9PVkVSTEFZOwo+ID4gKwo+ ID4gKyAgICAgICAgICAgLyoKPiA+ICsgICAgICAgICAgICAqIEFsbCB0aGUgbGF5ZXJzIGV4Y2Vw dCBzbWFydCBsYXllciBzdXBwb3J0cyBBRkJDIG1vZGlmaWVycy4KPiA+ICsgICAgICAgICAgICAq Lwo+ID4gICAgICAgICAgICAgcmV0ID0gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KGRybSwgJnBs YW5lLT5iYXNlLCBjcnRjcywKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmbWFsaWRwX2RlX3BsYW5lX2Z1bmNzLCBmb3JtYXRzLAo+ID4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG4sIE5VTEwsIHBsYW5lX3R5cGUsIE5VTEwp Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICZtYWxpZHBfZGVfcGxhbmVfZnVuY3Ms IGZvcm1hdHMsIG4sCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlkID09IERFX1NN QVJUKSA/IE5VTEwgOiBtb2RpZmllcnMsIHBsYW5lX3R5cGUsIE5VTEwpOwo+ID4gKwo+ID4gICAg ICAgICAgICAgaWYgKHJldCA8IDApCj4gPiAgICAgICAgICAgICAgICAgICAgIGdvdG8gY2xlYW51 cDsKPiA+Cj4gPiAtLQo+ID4gMi43LjQKPiA+Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4gZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPgo+IC0tCj4gRGFuaWVsIFZldHRlcgo+ IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xs LmNoCklNUE9SVEFOVCBOT1RJQ0U6IFRoZSBjb250ZW50cyBvZiB0aGlzIGVtYWlsIGFuZCBhbnkg YXR0YWNobWVudHMgYXJlIGNvbmZpZGVudGlhbCBhbmQgbWF5IGFsc28gYmUgcHJpdmlsZWdlZC4g SWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwgcGxlYXNlIG5vdGlmeSB0aGUg c2VuZGVyIGltbWVkaWF0ZWx5IGFuZCBkbyBub3QgZGlzY2xvc2UgdGhlIGNvbnRlbnRzIHRvIGFu eSBvdGhlciBwZXJzb24sIHVzZSBpdCBmb3IgYW55IHB1cnBvc2UsIG9yIHN0b3JlIG9yIGNvcHkg dGhlIGluZm9ybWF0aW9uIGluIGFueSBtZWRpdW0uIFRoYW5rIHlvdS4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==