From: Peter Zijlstra Subject: Re: [RFC PATCH v4 03/12] PM: Introduce an Energy Model management framework Date: Fri, 6 Jul 2018 12:03:53 +0200 Message-ID: <20180706100353.GU2476@hirez.programming.kicks-ass.net> References: <20180628114043.24724-1-quentin.perret@arm.com> <20180628114043.24724-4-quentin.perret@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vincent Guittot Cc: Quentin Perret , "Rafael J. Wysocki" , linux-kernel , "open list:THERMAL" , "gregkh@linuxfoundation.org" , Ingo Molnar , Dietmar Eggemann , Morten Rasmussen , Chris Redpath , Patrick Bellasi , Valentin Schneider , Thara Gopinath , viresh kumar , Todd Kjos , Joel Fernandes , "Cc: Steve Muckle" , adharmap@quicinc.com, "Kannan, Saravana" , pkondeti@codeaurora.o List-Id: linux-pm@vger.kernel.org On Fri, Jul 06, 2018 at 11:57:37AM +0200, Vincent Guittot wrote: > > IIUC the formula above, you consider that all CPUs in a frequency > domain has the same capacity. This sounds a reasonable assumption but > it would be good to write that somewhere Yes, I think there used to be a WARN and kill EM for that, but I cannot seem to locate that in the current code.