Return-Path: Received: from mail.kernel.org ([198.145.29.99]:34084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933336AbeGJOBb (ORCPT ); Tue, 10 Jul 2018 10:01:31 -0400 From: Jeff Layton To: viro@ZenIV.linux.org.uk, dhowells@redhat.com Cc: willy@infradead.org, andres@anarazel.de, cmaiolino@redhat.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2 1/4] vfs: track per-sb writeback errors Date: Tue, 10 Jul 2018 10:01:24 -0400 Message-Id: <20180710140127.20739-2-jlayton@kernel.org> In-Reply-To: <20180710140127.20739-1-jlayton@kernel.org> References: <20180710140127.20739-1-jlayton@kernel.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Jeff Layton Keep a per-sb errseq_t that tracks whether there have been any writeback errors on this superblock. When an error is recorded for an inode via mapping_set_error, record it in s_wb_err as well. Cc: Andres Freund Cc: Matthew Wilcox Signed-off-by: Jeff Layton --- include/linux/fs.h | 3 +++ include/linux/pagemap.h | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 858dd2f3300c..5378a845ca01 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1446,6 +1446,9 @@ struct super_block { /* Being remounted read-only */ int s_readonly_remount; + /* per-sb errseq_t for reporting writeback errors via syncfs */ + errseq_t s_wb_err; + /* AIO completions deferred from interrupt context */ struct workqueue_struct *s_dio_done_wq; struct hlist_head s_pins; diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 442977811b59..c1e36a7b44d2 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -51,7 +51,10 @@ static inline void mapping_set_error(struct address_space *mapping, int error) return; /* Record in wb_err for checkers using errseq_t based tracking */ - filemap_set_wb_err(mapping, error); + __filemap_set_wb_err(mapping, error); + + /* Record it in superblock */ + errseq_set(&mapping->host->i_sb->s_wb_err, error); /* Record it in flags for now, for legacy callers */ if (error == -ENOSPC) -- 2.17.1