From: Huang Rui Subject: Re: [PATCH] drm/amdgpu/vi: fix mixed up state in smu clockgating setup Date: Wed, 11 Jul 2018 16:39:04 +0800 Message-ID: <20180711083903.GA11796@hr-amur2> References: <20180710215339.20378-1-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180710215339.20378-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gVHVlLCBKdWwgMTAsIDIwMTggYXQgMDQ6NTM6MzlQTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IFVzZSB0aGUgUFBfU1RBVEVfU1VQUE9SVF8qIHJhdGhlciB0aGFuIEFNRF9DR19TVVBQ T1JUXyoKPiB3aGVuIGNvbW11bmljYXRpbmcgd2l0aCB0aGUgU01VLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KClJldmlld2VkLWJ5 OiBIdWFuZyBSdWkgPHJheS5odWFuZ0BhbWQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvdmkuYyB8IDEyICsrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS92aS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdmkuYwo+ IGluZGV4IDRhYzEyODhhYjdkZi4uNDJjOGFkMTA1YjA1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L3ZpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS92aS5jCj4gQEAgLTEzNjMsMTEgKzEzNjMsMTEgQEAgc3RhdGljIGludCB2aV9jb21tb25fc2V0 X2Nsb2NrZ2F0aW5nX3N0YXRlX2J5X3NtdSh2b2lkICpoYW5kbGUsCj4gIAo+ICAJaWYgKGFkZXYt PmNnX2ZsYWdzICYgKEFNRF9DR19TVVBQT1JUX01DX0xTIHwgQU1EX0NHX1NVUFBPUlRfTUNfTUdD RykpIHsKPiAgCQlpZiAoYWRldi0+Y2dfZmxhZ3MgJiBBTURfQ0dfU1VQUE9SVF9NQ19MUykgewo+ IC0JCQlwcF9zdXBwb3J0X3N0YXRlID0gQU1EX0NHX1NVUFBPUlRfTUNfTFM7Cj4gKwkJCXBwX3N1 cHBvcnRfc3RhdGUgPSBQUF9TVEFURV9TVVBQT1JUX0xTOwo+ICAJCQlwcF9zdGF0ZSA9IFBQX1NU QVRFX0xTOwo+ICAJCX0KPiAgCQlpZiAoYWRldi0+Y2dfZmxhZ3MgJiBBTURfQ0dfU1VQUE9SVF9N Q19NR0NHKSB7Cj4gLQkJCXBwX3N1cHBvcnRfc3RhdGUgfD0gQU1EX0NHX1NVUFBPUlRfTUNfTUdD RzsKPiArCQkJcHBfc3VwcG9ydF9zdGF0ZSB8PSBQUF9TVEFURV9TVVBQT1JUX0NHOwo+ICAJCQlw cF9zdGF0ZSB8PSBQUF9TVEFURV9DRzsKPiAgCQl9Cj4gIAkJaWYgKHN0YXRlID09IEFNRF9DR19T VEFURV9VTkdBVEUpCj4gQEAgLTEzODIsMTEgKzEzODIsMTEgQEAgc3RhdGljIGludCB2aV9jb21t b25fc2V0X2Nsb2NrZ2F0aW5nX3N0YXRlX2J5X3NtdSh2b2lkICpoYW5kbGUsCj4gIAo+ICAJaWYg KGFkZXYtPmNnX2ZsYWdzICYgKEFNRF9DR19TVVBQT1JUX1NETUFfTFMgfCBBTURfQ0dfU1VQUE9S VF9TRE1BX01HQ0cpKSB7Cj4gIAkJaWYgKGFkZXYtPmNnX2ZsYWdzICYgQU1EX0NHX1NVUFBPUlRf U0RNQV9MUykgewo+IC0JCQlwcF9zdXBwb3J0X3N0YXRlID0gQU1EX0NHX1NVUFBPUlRfU0RNQV9M UzsKPiArCQkJcHBfc3VwcG9ydF9zdGF0ZSA9IFBQX1NUQVRFX1NVUFBPUlRfTFM7Cj4gIAkJCXBw X3N0YXRlID0gUFBfU1RBVEVfTFM7Cj4gIAkJfQo+ICAJCWlmIChhZGV2LT5jZ19mbGFncyAmIEFN RF9DR19TVVBQT1JUX1NETUFfTUdDRykgewo+IC0JCQlwcF9zdXBwb3J0X3N0YXRlIHw9IEFNRF9D R19TVVBQT1JUX1NETUFfTUdDRzsKPiArCQkJcHBfc3VwcG9ydF9zdGF0ZSB8PSBQUF9TVEFURV9T VVBQT1JUX0NHOwo+ICAJCQlwcF9zdGF0ZSB8PSBQUF9TVEFURV9DRzsKPiAgCQl9Cj4gIAkJaWYg KHN0YXRlID09IEFNRF9DR19TVEFURV9VTkdBVEUpCj4gQEAgLTE0MDEsMTEgKzE0MDEsMTEgQEAg c3RhdGljIGludCB2aV9jb21tb25fc2V0X2Nsb2NrZ2F0aW5nX3N0YXRlX2J5X3NtdSh2b2lkICpo YW5kbGUsCj4gIAo+ICAJaWYgKGFkZXYtPmNnX2ZsYWdzICYgKEFNRF9DR19TVVBQT1JUX0hEUF9M UyB8IEFNRF9DR19TVVBQT1JUX0hEUF9NR0NHKSkgewo+ICAJCWlmIChhZGV2LT5jZ19mbGFncyAm IEFNRF9DR19TVVBQT1JUX0hEUF9MUykgewo+IC0JCQlwcF9zdXBwb3J0X3N0YXRlID0gQU1EX0NH X1NVUFBPUlRfSERQX0xTOwo+ICsJCQlwcF9zdXBwb3J0X3N0YXRlID0gUFBfU1RBVEVfU1VQUE9S VF9MUzsKPiAgCQkJcHBfc3RhdGUgPSBQUF9TVEFURV9MUzsKPiAgCQl9Cj4gIAkJaWYgKGFkZXYt PmNnX2ZsYWdzICYgQU1EX0NHX1NVUFBPUlRfSERQX01HQ0cpIHsKPiAtCQkJcHBfc3VwcG9ydF9z dGF0ZSB8PSBBTURfQ0dfU1VQUE9SVF9IRFBfTUdDRzsKPiArCQkJcHBfc3VwcG9ydF9zdGF0ZSB8 PSBQUF9TVEFURV9TVVBQT1JUX0NHOwo+ICAJCQlwcF9zdGF0ZSB8PSBQUF9TVEFURV9DRzsKPiAg CQl9Cj4gIAkJaWYgKHN0YXRlID09IEFNRF9DR19TVEFURV9VTkdBVEUpCj4gLS0gCj4gMi4xMy42 Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBh bWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=