From: Tom Rini Date: Fri, 20 Jul 2018 08:35:09 -0400 Subject: [U-Boot] [U-Boot, 2/4] cmd: nvedit: propagate envflag to set_default_vars In-Reply-To: <20180624161657.32632-3-yaniv.levinsky@compulab.co.il> References: <20180624161657.32632-3-yaniv.levinsky@compulab.co.il> Message-ID: <20180720123509.GF11755@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Jun 24, 2018 at 07:16:55PM +0300, Yaniv Levinsky wrote: > The env_flag in do_env_default() doesn't get propagated and therefore > gets ignored by himport_r(). This breaks to ability to "forcibly" reset > variables to their default values using the environment command. > > Scenario example of the problem: > # setenv kernel uImage > # setenv .flags kernel:so > # env default -f kernel > ## Error: Can't overwrite "kernel" > himport_r: can't insert "kernel=zImage" into hash table > > Change the call path so it will pass the flag correctly. > > Signed-off-by: Yaniv Levinsky > Acked-by: Igor Grinberg Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: