From: Tom Rini Date: Fri, 20 Jul 2018 08:35:13 -0400 Subject: [U-Boot] [U-Boot, 3/4] cmd: nvedit: set H_INTERACTIVE in do_env_default In-Reply-To: <20180624161657.32632-4-yaniv.levinsky@compulab.co.il> References: <20180624161657.32632-4-yaniv.levinsky@compulab.co.il> Message-ID: <20180720123513.GG11755@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Jun 24, 2018 at 07:16:56PM +0300, Yaniv Levinsky wrote: > The function set_default_vars() in common.c adds H_INTERACTIVE to the > h_import() flag, but the function has no way of telling if the command > actually was user directed like this flag suggest. The flag should be > set by the calling function do_env_default() in nvedit.c instead, where > the command is certainty user directed. > > Move the H_INTERACTIVE flag from set_default_vars() to do_env_default(). > > Signed-off-by: Yaniv Levinsky > Acked-by: Igor Grinberg Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: